1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EF2E7431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:23:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id M0IU-S3yUlz4 for <notmuch@notmuchmail.org>;
\r
16 Sun, 15 Apr 2012 10:23:47 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9D626431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:23:47 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id A785768055; Sun, 15 Apr 2012 20:23:43 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
24 Notmuch Mail <notmuch@notmuchmail.org>
\r
25 Subject: [No Subject]
\r
26 In-Reply-To: <1334456272-10376-1-git-send-email-jrollins@finestructure.net>
\r
27 References: <1334448507-16877-1-git-send-email-jrollins@finestructure.net>
\r
28 <1334456272-10376-1-git-send-email-jrollins@finestructure.net>
\r
29 User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sun, 15 Apr 2012 20:23:43 +0300
\r
35 Message-ID: <m2lilwsycg.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 15 Apr 2012 17:23:49 -0000
\r
52 On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
54 > A previous patch [0] replaced blank subject lines with '[No Subject]'
\r
55 > in search and show mode. Apparently this was needed to circumvent
\r
56 > some bug in the printing code, but there was no need for it search or
\r
57 > show, and it is definitely not desirable, so we undo it here (a revert
\r
58 > is no longer feasible). We should not be modifying strings in the
\r
59 > original message without good reason, or without a clear indication
\r
60 > that we are doing so, neither of which apply in this case. For
\r
61 > further discussion see [0].
\r
63 > [0] id:"1327918561-16245-3-git-send-email-dme@dme.org"
\r
70 > Sorry, there was a small bug in the previous version (notmuch-print.el
\r
71 > was mistakenly modified).
\r
73 > emacs/notmuch-show.el | 5 +----
\r
74 > emacs/notmuch.el | 5 ++---
\r
75 > 2 files changed, 3 insertions(+), 7 deletions(-)
\r
77 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
78 > index 30b26d1..1e55099 100644
\r
79 > --- a/emacs/notmuch-show.el
\r
80 > +++ b/emacs/notmuch-show.el
\r
81 > @@ -1075,7 +1075,7 @@ function is used."
\r
82 > (run-hooks 'notmuch-show-hook))
\r
84 > ;; Set the header line to the subject of the first message.
\r
85 > - (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))))
\r
86 > + (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))))
\r
88 > (defun notmuch-show-capture-state ()
\r
89 > "Capture the state of the current buffer.
\r
90 > @@ -1375,9 +1375,6 @@ current thread."
\r
91 > (defun notmuch-show-get-depth ()
\r
92 > (notmuch-show-get-prop :depth))
\r
94 > -(defun notmuch-show-get-pretty-subject ()
\r
95 > - (notmuch-prettify-subject (notmuch-show-get-subject)))
\r
97 > (defun notmuch-show-set-tags (tags)
\r
98 > "Set the tags of the current message."
\r
99 > (notmuch-show-set-prop :tags tags)
\r
100 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
101 > index ba833e6..326645d 100644
\r
102 > --- a/emacs/notmuch.el
\r
103 > +++ b/emacs/notmuch.el
\r
104 > @@ -507,7 +507,7 @@ Complete list of currently available key bindings:
\r
105 > "Display the currently selected thread."
\r
107 > (let ((thread-id (notmuch-search-find-thread-id))
\r
108 > - (subject (notmuch-prettify-subject (notmuch-search-find-subject))))
\r
109 > + (subject (notmuch-search-find-subject)))
\r
110 > (if (> (length thread-id) 0)
\r
111 > (notmuch-show thread-id
\r
113 > @@ -877,8 +877,7 @@ non-authors is found, assume that all of the authors match."
\r
114 > ;; We currently just throw away excluded matches.
\r
115 > (unless (eq (aref count 1) ?0)
\r
116 > (let ((beg (point)))
\r
117 > - (notmuch-search-show-result date count authors
\r
118 > - (notmuch-prettify-subject subject) tags)
\r
119 > + (notmuch-search-show-result date count authors subject tags)
\r
120 > (notmuch-search-color-line beg (point) tag-list)
\r
121 > (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
\r
122 > (put-text-property beg (point) 'notmuch-search-authors authors)
\r
126 > _______________________________________________
\r
127 > notmuch mailing list
\r
128 > notmuch@notmuchmail.org
\r
129 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
projects / notmuch-archives.git / blob