1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7E007431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 01:25:51 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 7nBHU4XNnyTH for <notmuch@notmuchmail.org>;
\r
17 Sat, 14 Apr 2012 01:25:51 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id BCF07431FAE
\r
22 for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 01:25:50 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SIyIi-0004dT-9m; Sat, 14 Apr 2012 09:25:46 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SIyIi-0002XA-0W; Sat, 14 Apr 2012 09:25:44 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v4 0/6] Config-related patches
\r
35 In-Reply-To: <1334367666-10954-1-git-send-email-novalazy@gmail.com>
\r
36 References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>
\r
37 <1334367666-10954-1-git-send-email-novalazy@gmail.com>
\r
38 User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Sat, 14 Apr 2012 09:25:52 +0100
\r
41 Message-ID: <87zkaelnxr.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 94.192.233.223
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: 68ad0dbbae8ef18ebd66d0384a461600 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -1.8
\r
48 X-SpamAssassin-SpamBar: -
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -1.8 points.
\r
53 Summary of the scoring:
\r
54 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
56 * [138.37.6.40 listed in list.dnswl.org]
\r
57 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
58 provider * (markwalters1009[at]gmail.com)
\r
59 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
61 * 0.5 AWL AWL: From: address is in the auto white-list
\r
62 X-QM-Scan-Virus: ClamAV says the message is clean
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Sat, 14 Apr 2012 08:25:51 -0000
\r
77 On Sat, 14 Apr 2012, Peter Wang <novalazy@gmail.com> wrote:
\r
79 > - rephrase part of the 'list' implementation as a separate patch
\r
80 > - test 'set' on an extant key
\r
81 > - test removing keys
\r
83 This looks good to me. +1
\r
85 Two minor comments which you might like to consider (but definitely are
\r
87 1) You could check that there are no further arguments when the user
\r
88 calls `notmuch config list'
\r
89 2) In the man page you could explicitly say what the output is for a
\r
90 configuration item which has not been set.
\r
102 > config: Fix free in 'config get' implementation.
\r
103 > config: Check 'config get' arity exactly
\r
104 > test: Add tests for 'config' command
\r
105 > test: Add broken test for 'config list'
\r
106 > config: Add 'config list' command
\r
107 > man: Document 'config list' command
\r
109 > man/man1/notmuch-config.1 | 14 +++++++++
\r
110 > notmuch-config.c | 68 +++++++++++++++++++++++++++++++++++++++++---
\r
111 > test/config | 60 +++++++++++++++++++++++++++++++++++++++
\r
112 > test/notmuch-test | 1 +
\r
113 > 4 files changed, 138 insertions(+), 5 deletions(-)
\r
114 > create mode 100755 test/config
\r
119 > _______________________________________________
\r
120 > notmuch mailing list
\r
121 > notmuch@notmuchmail.org
\r
122 > http://notmuchmail.org/mailman/listinfo/notmuch
\r