28/34638c91aa839f8e782470dad52f6c6b52aa24

   1 Return-Path: <bacuh@riseup.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 0EFF0431FBD\r
   6         for <notmuch@notmuchmail.org>; Sun,  6 Jul 2014 13:38:28 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.099\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001]\r
  14         autolearn=disabled\r
  15 Received: from olra.theworths.org ([127.0.0.1])\r
  16         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  17         with ESMTP id iYPYKqSpCcnz for <notmuch@notmuchmail.org>;\r
  18         Sun,  6 Jul 2014 13:38:20 -0700 (PDT)\r
  19 Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\r
  20         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
  21         (No client certificate requested)\r
  22         by olra.theworths.org (Postfix) with ESMTPS id 17D83431FAF\r
  23         for <notmuch@notmuchmail.org>; Sun,  6 Jul 2014 13:38:20 -0700 (PDT)\r
  24 Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74])\r
  25         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
  26         (Client CN "*.riseup.net",\r
  27         Issuer "Gandi Standard SSL CA" (not verified))\r
  28         by mx1.riseup.net (Postfix) with ESMTPS id 375CA51BBF;\r
  29         Sun,  6 Jul 2014 13:38:18 -0700 (PDT)\r
  30 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=riseup.net; s=squak;\r
  31         t=1404679098; bh=iplnKch84YHXNLRGW+tCPipGUbWq/PDvi5jxHeGjRlw=;\r
  32         h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:\r
  33         MIME-Version:Content-Type;\r
  34         b=VlQ2JE00rgUxPujW0VFFta1U8cXYA+0FL4NTsd6YZjL+LFGiB9qkjsb2Nv65vtOi/\r
  35         ljsS3pnisNrnFDS5cez3c7PsbgkC4/BQLwLnTBc7EbqMyFVcR8d4teflz3OReqL13p\r
  36         EK16Di1+w5CKuL0lp9Wl9ktqeDgHBCvPaCa3lHzk=\r
  37 Received: from [127.0.0.1] (localhost [127.0.0.1])\r
  38         (Authenticated sender: bacuh@fruiteater.riseup.net)\r
  39         with ESMTPSA id 5B2F28F9\r
  40 From: Sebastian Lipp <bacuh@riseup.net>\r
  41 To: Karl Fogel <kfogel@red-bean.com>\r
  42 Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
  43         notmuch-address.el.\r
  44 In-Reply-To: <87oax6vt4u.fsf@ktab.red-bean.com>\r
  45 References: <87wqsfik5l.fsf@floss.red-bean.com>\r
  46         <87mwtah2hd.fsf@zancas.localnet>\r
  47         <877gkeau42.fsf@floss.red-bean.com>\r
  48         <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
  49         <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
  50         <m2hajgxli5.fsf@guru.guru-group.fi>\r
  51         <87vc7vgbym.fsf@zancas.localnet>\r
  52         <m2ehejykb1.fsf@guru.guru-group.fi>\r
  53         <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  54         <87oax6vt4u.fsf@ktab.red-bean.com>\r
  55 User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1\r
  56         (i686-pc-linux-gnu)\r
  57 Date: Sun, 06 Jul 2014 22:37:40 +0200\r
  58 Message-ID:\r
  59  <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  60 MIME-Version: 1.0\r
  61 Content-Type: text/plain\r
  62 X-Virus-Scanned: clamav-milter 0.98.1 at mx1\r
  63 X-Virus-Status: Clean\r
  64 Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Sun, 06 Jul 2014 20:38:28 -0000\r
  78 \r
  79 Karl Fogel <kfogel@red-bean.com> writes:\r
  80 > Sebastian Lipp <bacuh@riseup.net> writes:\r
  81 >>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
  82 >>index fa65cd5..ee7b169 100644\r
  83 >>--- a/emacs/notmuch-address.el\r
  84 >>+++ b/emacs/notmuch-address.el\r
  85 >>@@ -113,6 +113,59 @@ to know how address selection is made by default."\r
  86 >> (when (notmuch-address-locate-command notmuch-address-command)\r
  87 >>   (notmuch-address-message-insinuate))\r
  88 >> \r
  89 >>+;; functions to add sender / recipients to BBDB\r
  90 >>+\r
  91 >>+(defvar bbdb-get-addresses-headers)\r
  92 >\r
  93 > I think it's good to include an initial value (even an invalid\r
  94 > placeholder one, if the real initialization has not happened yet), and a\r
  95 > doc string.  C-h f defvar RET will say more about how to do that.\r
  96 \r
  97 I hope I got that right now. (I've got no real clue of Lisp yet because\r
  98 I just recently switched to emacs partly because of notmuch. :)\r
  99 \r
 100 How about\r
 101 \r
 102     (defvar bbdb-get-addresses-headers nil\r
 103       "List of Addresses to import into bbdb")\r
 104 \r
 105 ?\r
 106 \r
 107 > (By the way, this isn't a user-customizeable variable, right?  If it\r
 108 > were, then `defcustom' would be better than `defvar'.)\r
 109 \r
 110 As far as I understand it: It's not.\r
 111 \r