1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D887A431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 16:26:08 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id FkeA7KeEoy9B for <notmuch@notmuchmail.org>;
\r
16 Thu, 19 Jan 2012 16:26:08 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 019AB431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 16:26:07 -0800 (PST)
\r
22 Received: by wibhr12 with SMTP id hr12so19836wib.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 16:26:06 -0800 (PST)
\r
24 Received: by 10.180.106.165 with SMTP id gv5mr47662598wib.18.1327019166872;
\r
25 Thu, 19 Jan 2012 16:26:06 -0800 (PST)
\r
26 Received: from localhost ([109.131.97.13])
\r
27 by mx.google.com with ESMTPS id g12sm3250677wiw.10.2012.01.19.16.25.52
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 19 Jan 2012 16:26:06 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Tomi Ollila <tomi.ollila@iki.fi>,
\r
32 Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
33 Ethan Glasser-Camp <glasse@cs.rpi.edu>
\r
34 Subject: Re: [PATCH] test: always report missing prereqs,
\r
35 independent of `--verbose' option
\r
36 In-Reply-To: <yf64nvtce14.fsf@taco2.nixu.fi>
\r
37 References: <87d3aj8rcl.fsf@gmail.com>
\r
38 <1326889181-32311-1-git-send-email-pieter@praet.org>
\r
39 <yf64nvtce14.fsf@taco2.nixu.fi>
\r
40 User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1
\r
41 (x86_64-unknown-linux-gnu)
\r
42 Date: Fri, 20 Jan 2012 01:24:02 +0100
\r
43 Message-ID: <87d3afuspp.fsf@praet.org>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Fri, 20 Jan 2012 00:26:09 -0000
\r
61 On Wed, 18 Jan 2012 15:53:59 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
62 > On Wed, 18 Jan 2012 13:19:41 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
63 > > When tests are skipped due to missing prereqs, those prereqs are only
\r
64 > > displayed when running with the `--verbose' option. This is essential
\r
65 > > information when troubleshooting, so always send to stdout.
\r
69 > Instead of this the test suite could be enchanged so that
\r
70 > full log of the execution is stored somewhere and path
\r
71 > to that file is displayed at the end of test. Generally,
\r
72 > all output could stay available after tests exit so that
\r
73 > those could be investigated furtner.
\r
76 Indeed. AFAIK, this used to be possible using the `--tee' option,
\r
77 but the files it produces appear to be deleted when the tests finish.
\r
79 > (I tried to grep 'missing prerequisites' after running test
\r
80 > but did not find the info. the file opened for >&3 has been
\r
86 Are you sure you were using my patch and/or the `--verbose' option?
\r
88 Works here, using this highly sophisticated Emacs-hiding wizardry:
\r
91 sudo mv /usr/bin/emacs /usr/bin/emacs.bak
\r
92 make test | grep 'missing prerequisites'
\r
93 sudo mv /usr/bin/emacs.bak /usr/bin/emacs
\r
96 (patent pending... ;)
\r
98 > Now I just see huge amounts of missing prerequisites: emacs(1)
\r
99 > in my output (I presume that doesn't happen due to my
\r
100 > hack to "hide" emacs).
\r
103 When using my patch, you mean?
\r
105 Most likely because "$test_subtest_missing_external_prereqs_" is only
\r
106 reset at the beginning of every test series, so if an Emacs-dependent
\r
107 subtest is skipped, all subsequent skipped subtests will report that
\r
108 dependency as well, even if they were skipped due to a missing vi :).
\r
110 > But well, I'm not against applying this patch -- just that
\r
111 > the test system starts to get so rotten touching it gives
\r
115 I wouldn't say it's getting rotten, but yeah, "tread lightly" should
\r
116 probably be mandatory advice to those aspiring to explore its bowels...
\r
121 > > test/test-lib.sh | 4 ++--
\r
122 > > 1 files changed, 2 insertions(+), 2 deletions(-)
\r
124 > > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
125 > > index d1fbc05..6560628 100644
\r
126 > > --- a/test/test-lib.sh
\r
127 > > +++ b/test/test-lib.sh
\r
128 > > @@ -673,8 +673,8 @@ test_skip () {
\r
130 > > test_check_missing_external_prereqs_ () {
\r
131 > > if test -n "$test_subtest_missing_external_prereqs_"; then
\r
132 > > - say_color skip >&3 "missing prerequisites:"
\r
133 > > - echo "$test_subtest_missing_external_prereqs_" >&3
\r
134 > > + say_color skip >&1 "missing prerequisites:"
\r
135 > > + echo "$test_subtest_missing_external_prereqs_" >&1
\r
136 > > test_report_skip_ "$@"
\r
projects / notmuch-archives.git / blob