1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A7567429E42
\r
6 for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:51 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id jMUUV3Lcb6wP for <notmuch@notmuchmail.org>;
\r
16 Fri, 17 Feb 2012 18:06:51 -0800 (PST)
\r
17 Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D7A4E431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:50 -0800 (PST)
\r
22 Received: by lahd3 with SMTP id d3so4636363lah.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:47 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.112.102.68
\r
25 as permitted sender) client-ip=10.112.102.68;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of awg@xvx.ca designates
\r
28 10.112.102.68 as permitted sender) smtp.mail=awg@xvx.ca
\r
29 Received: from mr.google.com ([10.112.102.68])
\r
30 by 10.112.102.68 with SMTP id fm4mr4145680lbb.7.1329530807982 (num_hops
\r
31 = 1); Fri, 17 Feb 2012 18:06:47 -0800 (PST)
\r
33 Received: by 10.112.102.68 with SMTP id fm4mr3476592lbb.7.1329530807890; Fri,
\r
34 17 Feb 2012 18:06:47 -0800 (PST)
\r
36 Received: by 10.112.90.20 with HTTP; Fri, 17 Feb 2012 18:06:47 -0800 (PST)
\r
37 X-Originating-IP: [96.52.216.56]
\r
38 In-Reply-To: <20120217170457.GE5991@mit.edu>
\r
39 References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca>
\r
40 <1329361957-28493-4-git-send-email-awg+notmuch@xvx.ca>
\r
41 <20120217170457.GE5991@mit.edu>
\r
42 Date: Fri, 17 Feb 2012 19:06:47 -0700
\r
43 X-Google-Sender-Auth: ptq-jNVK5uq372Qflo3rlU9g-OA
\r
45 <CAMoJFUt_um9wTVaGEBm+9VmRcb1QZoOnbVCOrBQ7bfhjVQM9zg@mail.gmail.com>
\r
46 Subject: Re: [PATCH v5.2 3/7] reply: Add a JSON reply format.
\r
47 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
48 To: Austin Clements <amdragon@mit.edu>
\r
49 Content-Type: text/plain; charset=ISO-8859-1
\r
50 Content-Transfer-Encoding: quoted-printable
\r
52 ALoCoQkaMo7HnxDrP8TL5I/LdjB6m9F4UbKcxWU9kmtr+vT6Ksq5EHrBqxnpxx3CvJrAngWLrElB
\r
53 Cc: notmuch@notmuchmail.org
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Sat, 18 Feb 2012 02:06:51 -0000
\r
68 On Fri, Feb 17, 2012 at 10:04, Austin Clements <amdragon@mit.edu> wrote:
\r
69 > The first two patches LGTM. =A0A few nits in this one.
\r
71 Thanks for the review. A couple of points to discuss below; everything
\r
72 else I'll change for the next version.
\r
75 >> +format_part_json (const void *ctx, mime_node_t *node, notmuch_bool_t fi=
\r
79 > This is the wrong place for this declaration, since it is not part of
\r
80 > the MIME node abstraction. =A0It should go somewhere above the /*
\r
81 > notmuch-config.c */ comment. =A0Above that, it's a bit of a jumble. =A0I'=
\r
83 > probably put it right after notmuch_show_command.
\r
85 Agreed. I initially had it earlier in the file (with the other
\r
86 show-related functions), but moved it down since it requires the
\r
87 mime_node_t declaration. There are a couple of options: put in a
\r
88 pre-declaration of mime_node_t early in the file, or move the
\r
89 mime_node stuff to a separate header file and include it in
\r
90 notmuch-client.h. I lean toward the latter, since notmuch-client.h is
\r
91 getting very big as it is. Thoughts?
\r
93 >> + =A0 =A0if (notmuch_query_count_messages (query) !=3D 1) {
\r
94 >> + =A0 =A0 fprintf (stderr, "Error: search term did not match precisely o=
\r
96 >> + =A0 =A0 return 1;
\r
99 > Technically count_messages does not have to be accurate, but since
\r
100 > this is the same thing notmuch-show does, it's probably fine for now.
\r
102 Ah, I didn't realize this. I just followed the show example.
\r
104 > Perhaps we should add proper handling of multi-message replies to
\r
107 Probably a good idea, although it means defining what proper handling
\r
108 of multi-message replies in the CLI means. Personally, I don't think
\r
109 it makes much sense to reply to multiple messages. The only place that
\r
110 functionality is actually used (AFAIK) is in notmuch-search.el, which,
\r
111 with my patches, throws an error if you try to reply to a thread
\r
112 containing multiple messages. In my mind, the correct behavior in that
\r
113 specific case is to create a reply to the last message in the thread,
\r
114 which is better handled in the emacs code than the CLI anyway.
\r