1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 5D6516DE0231
\r
6 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 18:21:09 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.308 tagged_above=-999 required=5 tests=[AWL=0.243,
\r
12 RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id jCnQh-uiztbk for <notmuch@notmuchmail.org>;
\r
16 Tue, 9 Feb 2016 18:21:07 -0800 (PST)
\r
17 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 4CA6D6DE021E
\r
19 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 18:21:07 -0800 (PST)
\r
20 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1aTKOE-0001Ro-Q5; Tue, 09 Feb 2016 21:20:22 -0500
\r
23 Received: (nullmailer pid 9755 invoked by uid 1000);
\r
24 Wed, 10 Feb 2016 02:21:01 -0000
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
\r
27 Notmuch Mail <notmuch@notmuchmail.org>
\r
28 Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil
\r
29 In-Reply-To: <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net>
\r
30 References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
\r
31 <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net>
\r
32 User-Agent: Notmuch/0.21+5~gca076ce (http://notmuchmail.org) Emacs/24.5.1
\r
33 (x86_64-pc-linux-gnu)
\r
34 Date: Tue, 09 Feb 2016 22:21:01 -0400
\r
35 Message-ID: <87wpqduwz6.fsf@maritornes.cs.unb.ca>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.20
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 10 Feb 2016 02:21:09 -0000
\r
52 Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
\r
54 > This prepares us for using the crypto object in both the library and
\r
57 > i've prefixed notmuch_crypto with _ to indicate that while this can be
\r
58 > built into the library when needed, it's not something to be exported
\r
59 > or used externally.
\r
63 > diff --git a/mime-node.c b/mime-node.c
\r
64 > index e96e663..a8f5670 100644
\r
67 > @@ -33,7 +33,7 @@ typedef struct mime_node_context {
\r
68 > GMimeMessage *mime_message;
\r
70 > /* Context provided by the caller. */
\r
71 > - notmuch_crypto_t *crypto;
\r
72 > + _notmuch_crypto_t *crypto;
\r
73 > } mime_node_context_t;
\r
75 is this maybe search and replace gone wild? or did you mean
\r
76 to rename the type as well as the functions?
\r
79 > node_verify (mime_node_t *node, GMimeObject *part,
\r
80 > - notmuch_crypto_context_t *cryptoctx)
\r
81 > + GMimeCryptoContext *cryptoctx)
\r
84 This change of parameter type seems significant. Does it deserve a
\r
85 comment in the commit message?
\r
projects / notmuch-archives.git / blob