25/5fde3754ca7c4bcf734d7ce65a43a4b6b8b5fb

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5  by arlo.cworth.org (Postfix) with ESMTP id 4F42D6DE0924\r
   6  for <notmuch@notmuchmail.org>; Sat, 26 Sep 2015 02:37:58 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at cworth.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.525\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.525 tagged_above=-999 required=5 tests=[AWL=0.195,\r
  12   RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01]\r
  13  autolearn=disabled\r
  14 Received: from arlo.cworth.org ([127.0.0.1])\r
  15  by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16  with ESMTP id c9jL9FXIQniP for <notmuch@notmuchmail.org>;\r
  17  Sat, 26 Sep 2015 02:37:56 -0700 (PDT)\r
  18 Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com\r
  19  [209.85.212.171])\r
  20  by arlo.cworth.org (Postfix) with ESMTPS id 0ABDC6DE00AC\r
  21  for <notmuch@notmuchmail.org>; Sat, 26 Sep 2015 02:35:45 -0700 (PDT)\r
  22 Received: by wicge5 with SMTP id ge5so48404252wic.0\r
  23  for <notmuch@notmuchmail.org>; Sat, 26 Sep 2015 02:35:42 -0700 (PDT)\r
  24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25  d=1e100.net; s=20130820;\r
  26  h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\r
  27  :references;\r
  28  bh=IHb2oN5B4FZk2q1bRdNtlR9rHZgU2qvg+XAFJmPm+TQ=;\r
  29  b=cOZfeh7d8a6wdUGVnLE0wWoZ2cpzLE+KTZoULWh3Z3cTlbgIodNQox57y9p1+/x8ig\r
  30  QuCpxVxNHQcDbBv+LvWg+gDfPpdk87OOz7GyMktOw0+VMkr+5T0EqUODzJFy2wvpdrIn\r
  31  WEl2h4iq6eOd6Yw/N6oso45gIMFtseBVruFo1lTLQmcXm40iL2oxV/QkquKH+BIPhIPK\r
  32  YFdg+FuEDEn4bdpnP4mCxuNGy9b+tg63+4fsdbP7sqMyk5KsIETNbTsq0FhSk8KsVUw9\r
  33  LTngSgG4OC1ksaLX/tHxQmB/6Tdl8HinpF2xCMbgu2cS6Gij9su8ssRaOAGojazs+N9z\r
  34  FbCQ==\r
  35 X-Gm-Message-State:\r
  36  ALoCoQlW+0qXNQ5AhCyowipLliVq8VAGKuylcRK3dA5jiTLOMX/uRb0F3LSO5lnSLyGpFZ55T9OK\r
  37 X-Received: by 10.180.37.133 with SMTP id y5mr7802320wij.15.1443260142761;\r
  38  Sat, 26 Sep 2015 02:35:42 -0700 (PDT)\r
  39 Received: from localhost (mobile-access-bcee63-221.dhcp.inet.fi.\r
  40  [188.238.99.221])\r
  41  by smtp.gmail.com with ESMTPSA id pk7sm7566731wjb.2.2015.09.26.02.35.40\r
  42  (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  43  Sat, 26 Sep 2015 02:35:42 -0700 (PDT)\r
  44 From: Jani Nikula <jani@nikula.org>\r
  45 To: David Bremner <david@tethera.net>, Johannes Schauer <josch@debian.org>,\r
  46  notmuch@notmuchmail.org\r
  47 Subject: [PATCH 1/2] lib: content disposition values are not case-sensitive\r
  48 Date: Sat, 26 Sep 2015 12:35:21 +0300\r
  49 Message-Id: <1443260122-5122-1-git-send-email-jani@nikula.org>\r
  50 X-Mailer: git-send-email 2.1.4\r
  51 In-Reply-To: <871tdvvoyf.fsf@tesseract.cs.unb.ca>\r
  52 References: <871tdvvoyf.fsf@tesseract.cs.unb.ca>\r
  53 X-BeenThere: notmuch@notmuchmail.org\r
  54 X-Mailman-Version: 2.1.18\r
  55 Precedence: list\r
  56 List-Id: "Use and development of the notmuch mail system."\r
  57  <notmuch.notmuchmail.org>\r
  58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  59  <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  60 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
  61 List-Post: <mailto:notmuch@notmuchmail.org>\r
  62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  64  <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  65 X-List-Received-Date: Sat, 26 Sep 2015 09:37:58 -0000\r
  66 \r
  67 Per RFC 2183, the values for Content-Disposition values are not\r
  68 case-sensitive. While at it, use the gmime function for getting at the\r
  69 disposition string instead of referencing the field directly.\r
  70 \r
  71 This fixes "attachment" tagging and filename term generation for\r
  72 attachments while indexing.\r
  73 ---\r
  74  lib/index.cc | 3 ++-\r
  75  1 file changed, 2 insertions(+), 1 deletion(-)\r
  76 \r
  77 diff --git a/lib/index.cc b/lib/index.cc\r
  78 index e81aa8190288..f166aefd2fc1 100644\r
  79 --- a/lib/index.cc\r
  80 +++ b/lib/index.cc\r
  81 @@ -377,7 +377,8 @@ _index_mime_part (notmuch_message_t *message,\r
  82  \r
  83      disposition = g_mime_object_get_content_disposition (part);\r
  84      if (disposition &&\r
  85 -       strcmp (disposition->disposition, GMIME_DISPOSITION_ATTACHMENT) == 0)\r
  86 +       strcasecmp (g_mime_content_disposition_get_disposition (disposition),\r
  87 +                   GMIME_DISPOSITION_ATTACHMENT) == 0)\r
  88      {\r
  89         const char *filename = g_mime_part_get_filename (GMIME_PART (part));\r
  90  \r
  91 -- \r
  92 2.1.4\r
  93 \r