1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 59729429E31
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:54 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id gvvyZ6GP4BXJ for <notmuch@notmuchmail.org>;
\r
16 Thu, 12 Jan 2012 09:21:54 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 B7FD5429E29 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:53 -0800
\r
22 Received: by wgbds11 with SMTP id ds11so1959821wgb.2
\r
23 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:52 -0800 (PST)
\r
24 Received: by 10.180.14.161 with SMTP id q1mr2066499wic.1.1326388912568;
\r
25 Thu, 12 Jan 2012 09:21:52 -0800 (PST)
\r
26 Received: from localhost ([109.131.126.209])
\r
27 by mx.google.com with ESMTPS id o1sm5552156wbh.9.2012.01.12.09.21.51
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 12 Jan 2012 09:21:51 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
32 Notmuch Mail <notmuch@notmuchmail.org>
\r
33 Subject: Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in
\r
34 buttonised id: links
\r
35 In-Reply-To: <1324616352-15337-1-git-send-email-jrollins@finestructure.net>
\r
36 References: <1324616352-15337-1-git-send-email-jrollins@finestructure.net>
\r
37 User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-unknown-linux-gnu)
\r
39 Date: Thu, 12 Jan 2012 18:20:12 +0100
\r
40 Message-ID: <874nw0ltwz.fsf@praet.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Thu, 12 Jan 2012 17:21:54 -0000
\r
57 On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
58 > Since message-ids necessarily match just a single message, there's no
\r
59 > reason to do a search for the id before viewing the actual message;
\r
60 > the search just becomes an extra screen to click through. Clicking on
\r
61 > an id: links now just jumps straight to the message itself.
\r
63 > This just fixes the subject of the patch, which had a typo. Sorry.
\r
65 > emacs/notmuch-show.el | 2 +-
\r
66 > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
68 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
69 > index 98db8f2..623d521 100644
\r
70 > --- a/emacs/notmuch-show.el
\r
71 > +++ b/emacs/notmuch-show.el
\r
72 > @@ -803,7 +803,7 @@ a corresponding notmuch search."
\r
73 > (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
\r
74 > (make-text-button (match-beginning 0) (match-end 0)
\r
75 > 'action `(lambda (arg)
\r
76 > - (notmuch-search ,(match-string-no-properties 0)))
\r
77 > + (notmuch-show ,(match-string-no-properties 0)))
\r
79 > 'help-echo "Mouse-1, RET: search for this message"
\r
80 > 'face goto-address-mail-face))))
\r
86 However... If no message with that id: exists, `notmuch-show'
\r
87 will drop us to a blank screen.
\r
89 See id:"87lisjzrsc.fsf@kepler.schwinge.homeip.net" for some mock
\r
90 'id:' links which demonstrate this nicely.
\r