24/530881c2bc5a572cfdfa258d5a04c82da9cf87

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 4F7CE431FB6\r
   6         for <notmuch@notmuchmail.org>; Wed,  5 Dec 2012 07:59:12 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id u9b540Wn1WBX for <notmuch@notmuchmail.org>;\r
  16         Wed,  5 Dec 2012 07:59:08 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
  18         [18.9.25.12])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 2F6CA431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed,  5 Dec 2012 07:59:08 -0800 (PST)\r
  21 X-AuditID: 1209190c-b7f886d000000936-37-50bf6f4bff2a\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 11.80.02358.B4F6FB05; Wed,  5 Dec 2012 10:59:07 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qB5Fx6lA005707; \r
  27         Wed, 5 Dec 2012 10:59:07 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB5Fx4AD003807\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Wed, 5 Dec 2012 10:59:06 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1TgHNI-0007ss-G6; Wed, 05 Dec 2012 10:59:04 -0500\r
  37 From: Austin Clements <aclements@csail.mit.edu>\r
  38 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH v2] emacs: show: refresh buffer did not remove overlays\r
  40 In-Reply-To: <1354709509-22123-1-git-send-email-markwalters1009@gmail.com>\r
  41 References: <20121203164730.GE1020@mit.edu>\r
  42         <1354709509-22123-1-git-send-email-markwalters1009@gmail.com>\r
  43 User-Agent: Notmuch/0.14+100~gcb9b0b0 (http://notmuchmail.org) Emacs/23.4.1\r
  44         (i486-pc-linux-gnu)\r
  45 Date: Wed, 05 Dec 2012 10:59:04 -0500\r
  46 Message-ID: <87mwxscwxj.fsf@awakening.csail.mit.edu>\r
  47 MIME-Version: 1.0\r
  48 Content-Type: text/plain; charset=us-ascii\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsUixCmqrOudvz/A4OxZFYvVc3ksrt+cyezA\r
  51         5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZTzeZF1wkKfi/dppzA2Mfzi7GDk5JARMJBZ1\r
  52         vGSCsMUkLtxbz9bFyMUhJLCPUeJoYzsrhLOeUWL+sxZmCOcCk8TVma+YIJwljBJ/nvxlBOln\r
  53         E9CXWLF2EiuILSLgKvH022dmEFtYwFvizo77QDUcHJwCXhJNPdwgppBApsTmGREgpqhAvMTl\r
  54         pQogxSwCqhIf7t8CG8ILdNz2pctYIGxBiZMzn4DZzAJaEjf+vWSawCgwC0lqFpLUAkamVYyy\r
  55         KblVurmJmTnFqcm6xcmJeXmpRbqGermZJXqpKaWbGMGhKMmzg/HNQaVDjAIcjEo8vJLG+wKE\r
  56         WBPLiitzDzFKcjApifL+zN0fIMSXlJ9SmZFYnBFfVJqTWnyIUYKDWUmEt9gPKMebklhZlVqU\r
  57         D5OS5mBREue9nHLTX0ggPbEkNTs1tSC1CCYrw8GhJMFbkQfUKFiUmp5akZaZU4KQZuLgBBnO\r
  58         AzQ8DqSGt7ggMbc4Mx0if4pRUUqcdwJIQgAkkVGaB9cLSxWvGMWBXhHmnQhSxQNMM3Ddr4AG\r
  59         MwENjmIHG1ySiJCSamAMaLje6+FS2zVRwqjp9DWp1+5Tk9/cDLjPf3DRnflywlO1z1YtEY1T\r
  60         vW9bMO/EzXUdZ5W9jNlcbnnzf/+7U7l2kVL0F5ny7JlSl2f2cGW/1GWr+O5rtfjVu8mdk902\r
  61         enUJtL9m5RUx4VknZjrlmF/WtL60qW3PbR9+j7Dbr7mxoDrCRTi1yVOJpTgj0VCLuag4EQD+\r
  62         XroU8AIAAA==\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Wed, 05 Dec 2012 15:59:12 -0000\r
  76 \r
  77 LGTM.\r
  78 \r
  79 On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
  80 > Previously refreshing the notmuch show buffer did not remove overlays\r
  81 > which meant that if the user refreshed a message with images the\r
  82 > images would remain and then the new text was added after.\r
  83 >\r
  84 > One might have guessed that erase-buffer would have removed them but\r
  85 > it seems not.  Thus force the removal of overlays with remove-overlays.\r
  86 > ---\r
  87 >\r
  88 > This version fixes the problems that Austin mentioned in his review. I\r
  89 > have not investigated whether the erase-buffer here can be removed: it\r
  90 > looks like it could be but the worst that this does is call\r
  91 > erase-buffer twice (slightly wasteful but no harm).\r
  92 >\r
  93 > Best wishes\r
  94 >\r
  95 > Mark\r
  96 >\r
  97 >\r
  98 >  emacs/notmuch-show.el |    4 ++++\r
  99 >  1 files changed, 4 insertions(+), 0 deletions(-)\r
 100 >\r
 101 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
 102 > index 4d6c014..20f8997 100644\r
 103 > --- a/emacs/notmuch-show.el\r
 104 > +++ b/emacs/notmuch-show.el\r
 105 > @@ -1185,6 +1185,10 @@ reset based on the original query."\r
 106 >    (let ((inhibit-read-only t)\r
 107 >       (state (unless reset-state\r
 108 >                (notmuch-show-capture-state))))\r
 109 > +    ;; erase-buffer does not seem to remove overlays, which can lead\r
 110 > +    ;; to weird effects such as remaining images, so remove them\r
 111 > +    ;; manually.\r
 112 > +    (remove-overlays)\r
 113 >      (erase-buffer)\r
 114 >      (notmuch-show-build-buffer)\r
 115 >      (if state\r
 116 > -- \r
 117 > 1.7.9.1\r
 118 >\r
 119 > _______________________________________________\r
 120 > notmuch mailing list\r
 121 > notmuch@notmuchmail.org\r
 122 > http://notmuchmail.org/mailman/listinfo/notmuch\r