22/42e47713a6526fabef7931ce9f806a6edb7fc3

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id CD10C431FAE\r
   6         for <notmuch@notmuchmail.org>; Sun, 22 Apr 2012 11:07:01 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id ARNz0npJAY42 for <notmuch@notmuchmail.org>;\r
  16         Sun, 22 Apr 2012 11:07:01 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
  18         [18.9.25.15])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 3694E431FAF\r
  20         for <notmuch@notmuchmail.org>; Sun, 22 Apr 2012 11:07:01 -0700 (PDT)\r
  21 X-AuditID: 1209190f-b7f8a6d000000914-82-4f9448c44bd4\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id C9.BC.02324.4C8449F4; Sun, 22 Apr 2012 14:07:00 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q3MI70Le020364; \r
  27         Sun, 22 Apr 2012 14:07:00 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3MI6x1u019455\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Sun, 22 Apr 2012 14:06:59 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SM1Ba-00080L-TJ; Sun, 22 Apr 2012 14:06:58 -0400\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions\r
  40 In-Reply-To:\r
  41  <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  42 References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de>\r
  43         <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  44 User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1\r
  45         (i486-pc-linux-gnu)\r
  46 Date: Sun, 22 Apr 2012 14:06:58 -0400\r
  47 Message-ID: <87wr57hc8t.fsf@awakening.csail.mit.edu>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsUixCmqrHvEY4q/wfsFphazW38wWVy/OZPZ\r
  52         gclj4vnTbB7PVt1iDmCK4rJJSc3JLEst0rdL4MpYeKmZqWAtW8XEky+YGxhXsXYxcnJICJhI\r
  53         3Nk0gx3CFpO4cG89WxcjF4eQwD5Giad7v0A5Gxgl1t3dzwzhnGSS+Hv7GyOEs4RR4uKbhWCz\r
  54         2AQ0JLbtX84IYosI+Em8ejiHCcQWFvCQ2HFtD1icUyBIYu3qRqjmdkaJg78Wgi0XFYiX+NO7\r
  55         mQ3EZhFQlfi7cjtYAy/Qgbv3HWGFsAUlTs58wgJiMwtoSdz495JpAqPALCSpWUhSCxiZVjHK\r
  56         puRW6eYmZuYUpybrFicn5uWlFuma6OVmluilppRuYgSHpST/DsZvB5UOMQpwMCrx8L4ymewv\r
  57         xJpYVlyZe4hRkoNJSZQ3BBjUQnxJ+SmVGYnFGfFFpTmpxYcYJTiYlUR4P4sAlfOmJFZWpRbl\r
  58         w6SkOViUxHnVtN75CQmkJ5akZqemFqQWwWRlODiUJHg1QIYKFqWmp1akZeaUIKSZODhBhvMA\r
  59         DVcGqeEtLkjMLc5Mh8ifYlSUEud95w6UEABJZJTmwfXC0sYrRnGgV4R52UDaeYApB677FdBg\r
  60         JqDBCTGTQAaXJCKkpBoY+7curpwvMd05obYxYAL/ldxVXGZ3/O5wm7/esHrheqMpmpc9t2rZ\r
  61         HM2aEXPN5cuWA1N7LDweNvT4vevNDFztsfXf65uuNQdfXSreojljBc+nsEIz35t8QU/spQUj\r
  62         21LFDMKmfW/fmXNtU+Jq+R8fJ1RNySl/mH3r1trzvbOVpfhCkhY857reqsRSnJFoqMVcVJwI\r
  63         AJUR5Ar2AgAA\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Sun, 22 Apr 2012 18:07:01 -0000\r
  77 \r
  78 On Sun, 22 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:\r
  79 > Formerly notmuch_database_close closed the xapian database and\r
  80 > destroyed the talloc structure associated with the notmuch database\r
  81 > object. Split notmuch_database_close into notmuch_database_close and\r
  82 > notmuch_database_destroy.\r
  83 >\r
  84 > This makes it possible for long running programs to close the xapian\r
  85 > database and thus release the lock associated with it without\r
  86 > destroying the data structures obtained from it.\r
  87 >\r
  88 > This also makes the api more consistent since every other data\r
  89 > structure has a destructor function.\r
  90 >\r
  91 > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
  92 \r
  93 Other than my comments comment, this series LGTM.  I think adding those\r
  94 comments should also address Felipe's question.\r