1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E5D24429E26
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 12:55:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id M1t2XusPGHpo for <notmuch@notmuchmail.org>;
\r
16 Tue, 13 Dec 2011 12:55:58 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id EBAB0429E25
\r
21 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 12:55:57 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBDKtJrQ006165;
\r
24 Tue, 13 Dec 2011 22:55:19 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs0t4nn-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Tue, 13 Dec 2011 22:55:19 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 pBDKtIkE025920; Tue, 13 Dec 2011 22:55:18 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
34 David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
35 Subject: Re: [PATCH] test: optionally print subtest number
\r
36 In-Reply-To: <87ty54ut1s.fsf@gmail.com>
\r
37 References: <1323806207-31888-1-git-send-email-david@tethera.net>
\r
38 <87ty54ut1s.fsf@gmail.com>
\r
39 User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1
\r
41 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
42 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
43 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
44 Date: Tue, 13 Dec 2011 22:55:18 +0200
\r
45 Message-ID: <yf61us8tcnd.fsf@taco2.nixu.fi>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
49 1.0.211, 0.0.0000 definitions=2011-12-13_03:2011-12-13, 2011-12-13,
\r
50 1970-01-01 signatures=0
\r
51 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
52 ipscore=0 suspectscore=0
\r
53 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
55 scancount=1 engine=6.0.2-1012030000 definitions=main-1112130225
\r
56 Cc: David Bremner <bremner@debian.org>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Tue, 13 Dec 2011 20:55:59 -0000
\r
71 On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner <david@tethera.net> wrote:
\r
73 > > From: David Bremner <bremner@debian.org>
\r
75 > > The idea is that $test_count could be used in tests to label
\r
76 > > intermediate files. The output enabled by this patch (and --debug)
\r
77 > > helps figure out which OUTPUT.nn file belongs to which test in case
\r
78 > > several subtests write to OUTPUT.$test_count
\r
81 > > Is there something that depends on the test format? I find it pretty
\r
82 > > handy to have the subtest numbers, but I don't want to break some
\r
83 > > other tools. I followed the existing style of conditionally defining
\r
84 > > functions, but maybe someone with more bash-fu can improve that.
\r
87 > Looks good to me. Except for tabs taking too much space. Perhaps the
\r
88 > following would be better?
\r
90 > printf "%-4s" "[$(($test_count - 1))]"
\r
92 I attempted the same size reduction. Therefore I know that
\r
93 this should to be either
\r
95 printf " %-4s" "[$(($test_count - 1))]"
\r
97 printf "\t%-4s" "[$(($test_count - 1))]"
\r
99 (or something similar) so that there is space betweem BROKEN and [num]
\r
101 This takes 4 bytes out from width (and drops tab as field separator)
\r
102 (and only few lines goes over 80 char width (some goes even with this
\r