21/53a7af3d93d447760293a3b1f80660e888607b

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 336EA429E47\r
   6         for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:22:28 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id Alv4rioNuHIU for <notmuch@notmuchmail.org>;\r
  16         Tue, 22 Oct 2013 17:22:21 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id A25B4429E28\r
  20         for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:22:08 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7f528e0000009b4-73-526716b0a6d9\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 1C.30.02484.0B617625; Tue, 22 Oct 2013 20:22:08 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r9N0M562012255; \r
  27         Tue, 22 Oct 2013 20:22:05 -0400\r
  28 Received: from drake.dyndns.org\r
  29         (216-15-114-40.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
  30         [216.15.114.40]) (authenticated bits=0)\r
  31         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  32         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9N0M3LB005835\r
  33         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  34         Tue, 22 Oct 2013 20:22:04 -0400\r
  35 Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
  36         (envelope-from <amdragon@mit.edu>)\r
  37         id 1VYmD5-0008KC-FJ; Tue, 22 Oct 2013 20:22:03 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: notmuch@notmuchmail.org\r
  40 Subject: [PATCH v2 1/8] emacs: Fix misuse of `notmuch-tag'\r
  41 Date: Tue, 22 Oct 2013 20:21:54 -0400\r
  42 Message-Id: <1382487721-31776-2-git-send-email-amdragon@mit.edu>\r
  43 X-Mailer: git-send-email 1.8.4.rc3\r
  44 In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
  45 References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
  46 X-Brightmail-Tracker:\r
  47  H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsUixCmqrLtBLD3I4N11CYvVc3ksrt+cyezA\r
  48         5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcxvnMBeMJWj4tj+J0wNjI/Yuhg5OSQETCRm\r
  49         TJwMZYtJXLi3Hsjm4hAS2Mco8fTtBlYIZyOjxMtLH5kgnDtMEm9WP4YqmwtUtvAJWD+bgIbE\r
  50         tv3LGUFsEQFpiZ13Z7OC2MwCjhKf9y8CquHgEBawkjjWogBisgioSrxeywdSwSvgIHF813d2\r
  51         iCuUJBae2gbWyQnU+WbHB7DpQkA1U3aeYZnAyL+AkWEVo2xKbpVubmJmTnFqsm5xcmJeXmqR\r
  52         rpFebmaJXmpK6SZGcBhJ8u5gfHdQ6RCjAAejEg+vRXtakBBrYllxZe4hRkkOJiVRXnX+9CAh\r
  53         vqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrzNvkDlvCmJlVWpRfkwKWkOFiVx3psc9kFCAumJJanZ\r
  54         qakFqUUwWRkODiUJXl9RoKGCRanpqRVpmTklCGkmDk6Q4TxAw1eA1PAWFyTmFmemQ+RPMSpK\r
  55         ifPygyQEQBIZpXlwvbA4f8UoDvSKMO8XEaAqHmCKgOt+BTSYCWjwlCUgVxeXJCKkpBoYq8MN\r
  56         j5maBbraX7Av3np88/F7i2Ws/ureDG2aqcMqcuiRQYIwk8f+zR5MZ5Yu5rd/E27Q+PG2B+Oj\r
  57         N2aroh/lJ37a7z/nVf0Oh4pNzFu7i89ybm1S4H4SPb/kYGqYR8Kyh3P9ZFj9V3y7vuSA3K6l\r
  58         zSqB+1deO865UGO16Xd5foENthNdV04/r8RSnJFoqMVcVJwIAG7fbDDOAgAA\r
  59 X-BeenThere: notmuch@notmuchmail.org\r
  60 X-Mailman-Version: 2.1.13\r
  61 Precedence: list\r
  62 List-Id: "Use and development of the notmuch mail system."\r
  63         <notmuch.notmuchmail.org>\r
  64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  65         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  67 List-Post: <mailto:notmuch@notmuchmail.org>\r
  68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  71 X-List-Received-Date: Wed, 23 Oct 2013 00:22:28 -0000\r
  72 \r
  73 The calling convention for `notmuch-tag' changed in commit 97aa3c06 to\r
  74 take a list of tag changes instead of a &rest argument, but the call\r
  75 from `notmuch-search-tag-all' still passed a &rest argument.  This\r
  76 happened to work for interactive calls because tag-changes would be\r
  77 nil, so the `apply' call would pass only the query string to\r
  78 `notmuch-tag' and simply omit the &optional tag-changes argument.\r
  79 ---\r
  80  emacs/notmuch.el | 2 +-\r
  81  1 file changed, 1 insertion(+), 1 deletion(-)\r
  82 \r
  83 diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
  84 index c47c6b5..e0511c8 100644\r
  85 --- a/emacs/notmuch.el\r
  86 +++ b/emacs/notmuch.el\r
  87 @@ -837,7 +837,7 @@ non-authors is found, assume that all of the authors match."\r
  88  \r
  89  See `notmuch-tag' for information on the format of TAG-CHANGES."\r
  90    (interactive)\r
  91 -  (apply 'notmuch-tag notmuch-search-query-string tag-changes))\r
  92 +  (notmuch-tag notmuch-search-query-string tag-changes))\r
  93  \r
  94  (defun notmuch-search-buffer-title (query)\r
  95    "Returns the title for a buffer with notmuch search results."\r
  96 -- \r
  97 1.8.4.rc3\r
  98 \r