1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E270F431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:05:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id hKUkiUW3VL9T for <notmuch@notmuchmail.org>;
\r
16 Fri, 3 Jun 2011 13:05:07 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 1F619431FB6
\r
19 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:05:06 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id 65F8B29A604;
\r
22 Fri, 3 Jun 2011 13:05:01 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id 1F90E25417E; Fri, 3 Jun 2011 13:05:01 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
27 Notmuch Mail <notmuch@notmuchmail.org>
\r
28 Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.
\r
29 In-Reply-To: <87lixkpw16.fsf@gmail.com>
\r
30 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
\r
31 <1306619520-25730-2-git-send-email-jrollins@finestructure.net>
\r
32 <1306619520-25730-3-git-send-email-jrollins@finestructure.net>
\r
33 <1306619520-25730-4-git-send-email-jrollins@finestructure.net>
\r
34 <1306619520-25730-5-git-send-email-jrollins@finestructure.net>
\r
35 <1306619520-25730-6-git-send-email-jrollins@finestructure.net>
\r
36 <1306619520-25730-7-git-send-email-jrollins@finestructure.net>
\r
37 <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
\r
38 <1306619520-25730-9-git-send-email-jrollins@finestructure.net>
\r
39 <1306619520-25730-10-git-send-email-jrollins@finestructure.net>
\r
40 <1306619520-25730-11-git-send-email-jrollins@finestructure.net>
\r
41 <1306619520-25730-12-git-send-email-jrollins@finestructure.net>
\r
42 <1306619520-25730-13-git-send-email-jrollins@finestructure.net>
\r
43 <1306619520-25730-14-git-send-email-jrollins@finestructure.net>
\r
44 <1306619520-25730-15-git-send-email-jrollins@finestructure.net>
\r
45 <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>
\r
46 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
48 Date: Fri, 03 Jun 2011 13:05:00 -0700
\r
49 Message-ID: <87oc2ellzn.fsf@yoom.home.cworth.org>
\r
51 Content-Type: multipart/signed; boundary="=-=-=";
\r
52 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 03 Jun 2011 20:05:08 -0000
\r
69 On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
70 > Well, it says that changes are in notmuch 0.5. So "old" and "previous"
\r
71 > refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5.
\r
73 Sure, but I happen to ahve already forgotten the details of how the
\r
74 variable could be configured in 0.4 and in 0.5. More importantly, anyone
\r
75 in the future reading the commit log is much more likely not to
\r
78 > Any configuration when `notmuch-fcc-dirs' is a list. That variable has
\r
79 > a nice documentation.
\r
81 Again, I'd like our commit messages to be self-contained. They are much
\r
82 more useful if the describe the change being made without assuming to
\r
83 much outside knowledge.
\r
85 > > It would be easier to understand the code if there were a corresponding
\r
86 > > test case for it.
\r
88 > I do not think we need a test for this fix. What we need are tests for
\r
89 > FCC functionality when notmuch-fcc-dirs is a list.
\r
93 > Old configuration format was changed in 0.5 in an incompatible way.
\r
94 > There is a check for the unsupported old-style configuration. But the
\r
95 > check is broken and results in an error when running with a valid
\r
96 > new-style configuration.
\r
98 This is actually what I meant by "corresponding test case". If the bug
\r
99 here is that a "new-style configuration" doesn't work , (and I still
\r
100 don't like that wording---don't say "new style"---explain what it
\r
101 actually *is*), then yes, we need a test case showing that bug.
\r
103 > I am not sure what you expect from the commit message here. IMO it is
\r
104 > enough for this small bugfix and those who interested can always refer
\r
105 > to documentation for details.
\r
107 The commit message should provide a self-contained description of the
\r
108 change. It should be along the lines of:
\r
110 When fcc-dirs is set to
\r
111 <some-particular-datatype-that-should-work> notmuch was
\r
112 incorecctly detecting this as the
\r
113 <old-style-that-is-no-longer-supported> and generating an error
\r
114 message. Fix the test so that this configuration now works.
\r
116 Where the <phrases> above should be replaced with actual descriptions,
\r
117 not relative pointers to information like "old style" or "new style".
\r
119 Does that make sense?
\r
124 Content-Type: application/pgp-signature
\r
126 -----BEGIN PGP SIGNATURE-----
\r
127 Version: GnuPG v1.4.11 (GNU/Linux)
\r
129 iEYEARECAAYFAk3pPmwACgkQ6JDdNq8qSWggNwCfUZIISt65QlMf1PZ3c+x22s6/
\r
130 LlMAn1r3/eY8b1ov4Z4rmnkbjMG8pA7Q
\r
132 -----END PGP SIGNATURE-----
\r
projects / notmuch-archives.git / blob