1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4C18D431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 12 Apr 2013 23:55:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id qn-jWJJw9HSo for <notmuch@notmuchmail.org>;
\r
17 Fri, 12 Apr 2013 23:55:43 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id C1A15431FAE
\r
22 for <notmuch@notmuchmail.org>; Fri, 12 Apr 2013 23:55:42 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1UQuN3-0002sE-C2; Sat, 13 Apr 2013 07:55:35 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1UQuN3-0004Mq-38; Sat, 13 Apr 2013 07:55:33 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
\r
34 In-Reply-To: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi>
\r
35 References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi>
\r
36 User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Sat, 13 Apr 2013 07:55:50 +0100
\r
39 Message-ID: <87eheekjgp.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: 5edd4fb3551830af940f6b21fc8b121a (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: -1.8
\r
46 X-SpamAssassin-SpamBar: -
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored -1.8 points.
\r
51 Summary of the scoring:
\r
52 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
54 * [138.37.6.40 listed in list.dnswl.org]
\r
55 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
56 provider * (markwalters1009[at]gmail.com)
\r
57 * 0.5 AWL AWL: From: address is in the auto white-list
\r
58 X-QM-Scan-Virus: ClamAV says the message is clean
\r
59 Cc: tomi.ollila@iki.fi
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Sat, 13 Apr 2013 06:55:44 -0000
\r
75 On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
76 > Some (declare-function ...) definitions were drifted away from the
\r
77 > actual (defun ...)'s. To find the drifts and to verify changes
\r
78 > the following command line was used:
\r
80 > $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
\r
82 This patch looks good to me +1.
\r
84 Is it worth making the above command into a test?
\r
91 > emacs/notmuch-hello.el | 2 +-
\r
92 > emacs/notmuch-show.el | 1 -
\r
93 > emacs/notmuch-wash.el | 2 +-
\r
94 > 3 files changed, 2 insertions(+), 3 deletions(-)
\r
96 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
97 > index cda79f1..c1c6f4b 100644
\r
98 > --- a/emacs/notmuch-hello.el
\r
99 > +++ b/emacs/notmuch-hello.el
\r
100 > @@ -26,7 +26,7 @@
\r
101 > (require 'notmuch-lib)
\r
102 > (require 'notmuch-mua)
\r
104 > -(declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation))
\r
105 > +(declare-function notmuch-search "notmuch" (&optional query oldest-first target-thread target-line continuation))
\r
106 > (declare-function notmuch-poll "notmuch" ())
\r
108 > (defcustom notmuch-hello-recent-searches-max 10
\r
109 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
110 > index a4d2c12..face2a0 100644
\r
111 > --- a/emacs/notmuch-show.el
\r
112 > +++ b/emacs/notmuch-show.el
\r
113 > @@ -38,7 +38,6 @@
\r
114 > (require 'notmuch-print)
\r
116 > (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))
\r
117 > -(declare-function notmuch-fontify-headers "notmuch" nil)
\r
118 > (declare-function notmuch-search-next-thread "notmuch" nil)
\r
119 > (declare-function notmuch-search-show-thread "notmuch" nil)
\r
121 > diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
\r
122 > index 826b6f4..80c475c 100644
\r
123 > --- a/emacs/notmuch-wash.el
\r
124 > +++ b/emacs/notmuch-wash.el
\r
125 > @@ -23,7 +23,7 @@
\r
129 > -(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth))
\r
130 > +(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth &optional hide))
\r
137 > _______________________________________________
\r
138 > notmuch mailing list
\r
139 > notmuch@notmuchmail.org
\r
140 > http://notmuchmail.org/mailman/listinfo/notmuch
\r