1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1ADFF431FC2
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:18:41 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id EmHcPX3ikwcc for <notmuch@notmuchmail.org>;
\r
18 Mon, 12 May 2014 15:18:33 -0700 (PDT)
\r
19 Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
\r
20 [209.85.212.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 9368A431FAF
\r
23 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:18:33 -0700 (PDT)
\r
24 Received: by mail-wi0-f180.google.com with SMTP id hi2so5304364wib.1
\r
25 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:18:32 -0700 (PDT)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
28 :mime-version:content-type;
\r
29 bh=6A6OTx7djqhJ/kVwXJ/HVfQImNrTkqpToAi0Bu00olY=;
\r
30 b=Op+7NskID5EKT/1M2FzF74cvsPUZtUUg6UvGypL5pGjv35mjZY60lOrKJ3rn3HtdlJ
\r
31 kg1MR+TOUq8vlkptDxVy0ig1SRfeEZQP5al0nwjviDyazzHVJE1L7a3U7smiPdWijI0A
\r
32 I7mucKs8mqgg2bY9qOJ1tORkAstmxPXiNLpfDF6srkL8YzcOyQrzkMPEOR2Xc2o/wHHk
\r
33 Pipo2C4pHvjRCIPMa3w89eMRnE4Gvud6uHErMFw6qhrz1yJR7EToQpzFBvdqO4ba3Y5g
\r
34 lQUAW6CI7JulDtQbrxeYfusg+SVKfFx6xmzQZ+B5T2fvqHBkK2H2NmaWyz6iQTLK9PRJ
\r
36 X-Received: by 10.180.198.48 with SMTP id iz16mr17804746wic.29.1399933112434;
\r
37 Mon, 12 May 2014 15:18:32 -0700 (PDT)
\r
38 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
39 by mx.google.com with ESMTPSA id
\r
40 dn4sm18384696wib.18.2014.05.12.15.18.31 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
42 Mon, 12 May 2014 15:18:31 -0700 (PDT)
\r
43 From: Mark Walters <markwalters1009@gmail.com>
\r
44 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
45 Subject: Re: [PATCH v3 5/9] emacs/show: Remove the 'no-buttons option of
\r
46 `notmuch-show-insert-bodypart'
\r
47 In-Reply-To: <1399897769-26809-6-git-send-email-dme@dme.org>
\r
48 References: <87sixdujkv.fsf@qmul.ac.uk>
\r
49 <1399897769-26809-1-git-send-email-dme@dme.org>
\r
50 <1399897769-26809-6-git-send-email-dme@dme.org>
\r
51 User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Mon, 12 May 2014 23:18:29 +0100
\r
54 Message-ID: <87k39qk5e2.fsf@qmul.ac.uk>
\r
56 Content-Type: text/plain; charset=us-ascii
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Mon, 12 May 2014 22:18:41 -0000
\r
71 On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:
\r
72 > No code uses the 'no-buttons argument to
\r
73 > `notmuch-show-insert-bodypart', so remove it.
\r
75 > emacs/notmuch-show.el | 9 +++------
\r
76 > 1 file changed, 3 insertions(+), 6 deletions(-)
\r
78 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
79 > index e511655..981b922 100644
\r
80 > --- a/emacs/notmuch-show.el
\r
81 > +++ b/emacs/notmuch-show.el
\r
82 > @@ -915,9 +915,7 @@ message at DEPTH in the current thread."
\r
84 > HIDE determines whether to show or hide the part and the button
\r
85 > as follows: If HIDE is nil, show the part and the button. If HIDE
\r
86 > -is t, hide the part initially and show the button. If HIDE is
\r
87 > -'no-buttons, show the part but do not add any buttons (this is
\r
88 > -useful for quoting in replies)."
\r
89 > +is t, hide the part initially and show the button."
\r
91 > (let* ((content-type (downcase (plist-get part :content-type)))
\r
92 > (mime-type (notmuch-show-mime-type part))
\r
93 > @@ -926,9 +924,8 @@ useful for quoting in replies)."
\r
94 > ;; Hide the part initially if HIDE is t.
\r
95 > (show-part (not (equal hide t)))
\r
97 Just a triviality: we might as well make the above (not hide) now.
\r
101 > ;; We omit the part button for the first (or only) part if
\r
102 > - ;; this is text/plain, or HIDE is 'no-buttons.
\r
103 > - (button (when (and (not (equal hide 'no-buttons))
\r
104 > - (funcall notmuch-show-insert-header-p-function part))
\r
105 > + ;; this is text/plain.
\r
106 > + (button (when (funcall notmuch-show-insert-header-p-function part)
\r
107 > (notmuch-show-insert-part-header nth mime-type content-type (plist-get part :filename))))
\r
108 > (content-beg (point)))
\r
113 > _______________________________________________
\r
114 > notmuch mailing list
\r
115 > notmuch@notmuchmail.org
\r
116 > http://notmuchmail.org/mailman/listinfo/notmuch
\r