1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D3D2A431FC1
\r
6 for <notmuch@notmuchmail.org>; Wed, 14 Apr 2010 10:47:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id FA2urYu1afWg; Wed, 14 Apr 2010 10:47:59 -0700 (PDT)
\r
17 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
18 by olra.theworths.org (Postfix) with ESMTP id EE6B74196F3;
\r
19 Wed, 14 Apr 2010 10:47:58 -0700 (PDT)
\r
20 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
21 id A0F09568DE1; Wed, 14 Apr 2010 10:47:58 -0700 (PDT)
\r
22 From: Carl Worth <cworth@cworth.org>
\r
23 To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 2/4] Fix up Makefile for build.
\r
25 In-Reply-To: <1271029494-89014-2-git-send-email-aaronecay@gmail.com>
\r
26 References: <4bc25ea0.86c3f10a.45a3.ffff80d3@mx.google.com>
\r
27 <1271029494-89014-2-git-send-email-aaronecay@gmail.com>
\r
28 Date: Wed, 14 Apr 2010 10:47:58 -0700
\r
29 Message-ID: <87tyreexip.fsf@yoom.home.cworth.org>
\r
31 Content-Type: multipart/signed; boundary="=-=-=";
\r
32 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
33 X-BeenThere: notmuch@notmuchmail.org
\r
34 X-Mailman-Version: 2.1.13
\r
36 List-Id: "Use and development of the notmuch mail system."
\r
37 <notmuch.notmuchmail.org>
\r
38 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
39 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
40 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
41 List-Post: <mailto:notmuch@notmuchmail.org>
\r
42 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
43 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
45 X-List-Received-Date: Wed, 14 Apr 2010 17:48:00 -0000
\r
49 On Sun, 11 Apr 2010 19:44:52 -0400, Aaron Ecay <aaronecay@gmail.com> wrote:
\r
50 > Must set extra_c(xx)flags before including subdir Makefile.local's,
\r
51 > so that there is a blank slate that the subdirs can add on to.
\r
53 That part looks just fine, but it's intermixed with:
\r
55 > Must include subdir Makefile.local's before global one, otherwise
\r
56 > the compat sources are not added to the list of those to be
\r
59 This part, which seems not ideal. I would have preferred it if we could
\r
60 have avoided fiddly ordering issues with our Makefile includes. The
\r
61 concept is that we are writing a single, flat Makefile but just
\r
62 maintaining it in pieces. And traditional Makefile rules don't depend on
\r
63 ordering so much. But the change of this variable assignment:
\r
65 But the patch switches to an order-dependent variable assignment for
\r
66 notmuch_compat_srcs here:
\r
68 > -notmuch_compat_srcs =
\r
69 > +notmuch_compat_srcs :=
\r
71 And testing this a bit, it does seem necessary to do this since we are
\r
72 already using the order-dependent $(dir) variable in the expansion of
\r
73 notmuch_compat_srcs.
\r
75 So I've convinced myself, and pushed this patch as well. (I even tested
\r
76 by manually setting HAVE_GETLINE to 0 in Makefile.config)
\r
81 Content-Type: application/pgp-signature
\r
83 -----BEGIN PGP SIGNATURE-----
\r
84 Version: GnuPG v1.4.10 (GNU/Linux)
\r
86 iD8DBQFLxf/O6JDdNq8qSWgRAnIkAKCRRMbJt7fOOp0OgA+RKYggNw5KiwCfXN6F
\r
87 Wyf1zdNhyVT/COrP71TAkco=
\r
89 -----END PGP SIGNATURE-----
\r