1a/276f70e8a7761105672dd6978ebae16a464f2d

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2D4D5431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 09:35:55 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id dlNIcv7vEw1H for <notmuch@notmuchmail.org>;\r
  16         Wed, 18 Jan 2012 09:35:54 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B47A5431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 09:35:54 -0800 (PST)\r
  21 X-AuditID: 12074423-b7f9c6d0000008c3-46-4f1702faa838\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 7E.B0.02243.AF2071F4; Wed, 18 Jan 2012 12:35:54 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q0IHZrmS016427; \r
  27         Wed, 18 Jan 2012 12:35:53 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0IHZmcJ012538\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Wed, 18 Jan 2012 12:35:51 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RnZQ6-0001TS-OH; Wed, 18 Jan 2012 12:35:34 -0500\r
  37 Date: Wed, 18 Jan 2012 12:35:34 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  40 Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6\r
  41 Message-ID: <20120118173534.GB16740@mit.edu>\r
  42 References: <8739bea9lc.fsf@thor.loria.fr>\r
  43         <1326797453-9405-1-git-send-email-schnouki@schnouki.net>\r
  44         <1326797453-9405-2-git-send-email-schnouki@schnouki.net>\r
  45         <20120117222546.GT16740@mit.edu> <yf639bd5suz.fsf@taco2.nixu.fi>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <yf639bd5suz.fsf@taco2.nixu.fi>\r
  50 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  51 X-Brightmail-Tracker:\r
  52  H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixG6novuLSdzfYO4RPovrN2cyW7xZOY/V\r
  53         gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4Mr4t+Qua8FLzoqelUtZGxj3sHcxcnBICJhI\r
  54         TPmp0MXICWSKSVy4t56ti5GLQ0hgH6PE5D+z2SGcDYwSs6a+Y4ZwTjJJbJ71GKpsCaNEz8r/\r
  55         LCD9LAKqEneunmIDsdkENCS27V/OCGKLCKhIPGhbzwpiMwtIS3z73cwEYgsLOEusWX4TrJdX\r
  56         QEei8epEqKFPGSUefv/HBJEQlDg58wkLRLOWxI1/L5lA7gYZtPwfB0iYE6i3eWYHM4gtCrRr\r
  57         ysltbBMYhWYh6Z6FpHsWQvcCRuZVjLIpuVW6uYmZOcWpybrFyYl5ealFumZ6uZkleqkppZsY\r
  58         wYHtoryD8c9BpUOMAhyMSjy8EhtE/YVYE8uKK3MPMUpyMCmJ8qoD40KILyk/pTIjsTgjvqg0\r
  59         J7X4EKMEB7OSCG/JLTF/Id6UxMqq1KJ8mJQ0B4uSOK+G1js/IYH0xJLU7NTUgtQimKwMB4eS\r
  60         BK8RyFDBotT01Iq0zJwShDQTByfIcB6g4R4gNbzFBYm5xZnpEPlTjLocJ9deOccoxJKXn5cq\r
  61         Jc6bAFIkAFKUUZoHNweWkF4xigO9JcwrBVLFA0xmcJNeAS1hAlnSBPJBcUkiQkqqgbFujmtE\r
  62         doIiu5v+A/vdbpONb131+H9oS87fzwLhyU82bjh3a++X634T9t9JFdl9wWkLo2anm/nD9RLm\r
  63         XN/f6/NYrMj9IXvwz3StX4Xlgo3XOQwFJjlVO13LO38k/v2d624vfs9YJ3w2QzBpcRCj5rGG\r
  64         PQdbqlYwafNvYGG281i1kcHsId9dkQglluKMREMt5qLiRACmGqPjIwMAAA==\r
  65 Cc: notmuch@notmuchmail.org\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Wed, 18 Jan 2012 17:35:55 -0000\r
  79 \r
  80 Quoth Tomi Ollila on Jan 18 at 10:15 am:\r
  81 > On Tue, 17 Jan 2012 17:25:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
  82 > > Quoth Thomas Jost on Jan 17 at 11:50 am:\r
  83 > > >  \r
  84 > > > +#ifdef GMIME_26\r
  85 > > > +    /* sig_list may be created in both above cases, so we need to\r
  86 > > > +     * cleanly handle it here. */\r
  87 > > > +    if (node->sig_list) {\r
  88 > > > + GMimeSignatureList **proxy =\r
  89 > > > +     talloc (node, GMimeSignatureList *);\r
  90 > > \r
  91 > > This doesn't need to be split into two lines.\r
  92 > > \r
  93 > > > + *proxy = node->sig_list;\r
  94 > > > + talloc_set_destructor (proxy, _signature_list_free);\r
  95 > > > +    }\r
  96 > > > +#else\r
  97 > > >      if (node->verify_attempted && !node->sig_validity)\r
  98 > > >   fprintf (stderr, "Failed to verify signed part: %s\n",\r
  99 > > >            (err ? err->message : "no error explanation given"));\r
 100 > > > +#endif\r
 101 > > \r
 102 > > I'd rather see the above as a separate #ifdef GMIME_26 and #ifndef\r
 103 > > GMIME_26, since they aren't logical alternates of each other.\r
 104 > \r
 105 > That reminds me that it should then be like GMIME_ATLEAST_26, so\r
 106 > that this might be useful when GMIME > 2.6 is available...\r
 107 \r
 108 Hopefully before GMIME 2.8 comes out, we'll be able to remove all of\r
 109 the GMIME 2.4 compatibility.  But GMIME_ATLEAST_26 would be fine, too.\r