1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D6DCA431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 1 Sep 2012 19:38:15 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yCFyi2Poomlf for <notmuch@notmuchmail.org>;
\r
16 Sat, 1 Sep 2012 19:38:15 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 7BC7E431FAF
\r
21 for <notmuch@notmuchmail.org>; Sat, 1 Sep 2012 19:38:15 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@unb.ca>)
\r
27 id 1T804k-0007XT-Pz; Sat, 01 Sep 2012 23:38:14 -0300
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1T804f-0003ke-AS; Sat, 01 Sep 2012 23:38:09 -0300
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
\r
34 In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
35 References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
36 User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Sat, 01 Sep 2012 23:38:09 -0300
\r
39 Message-ID: <87sjb1b14e.fsf@zancas.localnet>
\r
41 Content-Type: text/plain
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Sun, 02 Sep 2012 02:38:16 -0000
\r
57 Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:
\r
59 > Before the change, test_expect_equal_file() function treated the first
\r
60 > argument as "actual output file" and the second argument as "expected
\r
61 > output file". When the test fails, the files are copied for later
\r
62 > inspection. The first files was copied to "$testname.output" and the
\r
63 > second file to "$testname.expected". The argument order for
\r
64 > test_expect_equal_file() is often wrong which results in confusing
\r
65 > diff output and incorrectly named files.
\r