1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B092E431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 15 Oct 2013 00:53:08 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id QGccc8wuvx-o for <notmuch@notmuchmail.org>;
\r
16 Tue, 15 Oct 2013 00:53:01 -0700 (PDT)
\r
17 Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com
\r
18 [74.125.83.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 4D335431FAE for <notmuch@notmuchmail.org>; Tue, 15 Oct 2013 00:53:01 -0700
\r
22 Received: by mail-ee0-f51.google.com with SMTP id c1so3796864eek.24
\r
23 for <notmuch@notmuchmail.org>; Tue, 15 Oct 2013 00:53:00 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=kvllRqfCmmS28k0NWRZuQKawj8xkNOVUMUYEAANDR/Y=;
\r
29 b=YaaPROuMDjwiVXeMlopqBAmSAhVe/vgy42GZJH2e8SoEl4sU/nd54J7qP15VxwbDnF
\r
30 Yj2wHHMYCPgFmOmOgmEDcLrcrF27OPiyOuCGLw40NTGZLmyUDOXOfbQMUB3qmIfH53nj
\r
31 2Ar3dlR931VLWbl7KZRYoxOQIGQ2g59tR3Wa15YUZGqEEoF6lqqaIzC3bXtcTiKA4+z0
\r
32 Acj8+7Oe/+RamYo1kpr+0Wssk7fz+2GVnZs0/ygUlGJU3xDmc51rqKYEljv/7IOT8a1S
\r
33 WQytqEjkNc9UFnoL35q29da6QxpG47H/H44PyTHciWe3w2z7Zg20r6hA9X7wVX8NmPtW
\r
36 ALoCoQk8rvE+LGAIdF1r7dim9PSw2cSJHWakW6mjLNWco4bHuuLqhhNDoA6IHi/hX/ZWS5mE6ZhY
\r
37 X-Received: by 10.14.29.67 with SMTP id h43mr63381927eea.7.1381823580125;
\r
38 Tue, 15 Oct 2013 00:53:00 -0700 (PDT)
\r
39 Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])
\r
40 by mx.google.com with ESMTPSA id
\r
41 l49sm79193692eeo.12.1969.12.31.16.00.00
\r
42 (version=TLSv1.1 cipher=RC4-SHA bits=128/128);
\r
43 Tue, 15 Oct 2013 00:52:59 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Moritz Wilhelmy <mw+notmuch@barfooze.de>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH] Place extra_cflags before CONFIGURE_CFLAGS
\r
47 In-Reply-To: <1381822245-95400-1-git-send-email-mw+notmuch@barfooze.de>
\r
48 References: <1381822245-95400-1-git-send-email-mw+notmuch@barfooze.de>
\r
49 User-Agent: Notmuch/0.16+62~g9f2ae2e (http://notmuchmail.org) Emacs/23.2.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Tue, 15 Oct 2013 09:52:48 +0200
\r
52 Message-ID: <87wqlf2cof.fsf@nikula.org>
\r
54 Content-Type: text/plain; charset=us-ascii
\r
55 Cc: Moritz Wilhelmy <moritz+git@wzff.de>
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 15 Oct 2013 07:53:08 -0000
\r
70 On Tue, 15 Oct 2013, Moritz Wilhelmy <mw+notmuch@barfooze.de> wrote:
\r
71 > From: Moritz Wilhelmy <moritz+git@wzff.de>
\r
73 > This ensures that the build will not attempt to use an existing notmuch.h when
\r
74 > an older version of notmuch is already installed elsewhere (e.g. in /usr/local)
\r
75 > and /usr/local/include is added to CONFIGURE_CFLAGS by one of the libraries
\r
76 > (talloc, in my case)
\r
78 LGTM. I reached the exact same solution independently when we were
\r
79 debugging this on IRC.
\r
86 > Makefile.local | 4 ++--
\r
87 > 1 file changed, 2 insertions(+), 2 deletions(-)
\r
89 > diff --git a/Makefile.local b/Makefile.local
\r
90 > index 0464a50..72524eb 100644
\r
91 > --- a/Makefile.local
\r
92 > +++ b/Makefile.local
\r
93 > @@ -39,8 +39,8 @@ GPG_FILE=$(SHA1_FILE).asc
\r
94 > PV_FILE=bindings/python/notmuch/version.py
\r
96 > # Smash together user's values with our extra values
\r
97 > -FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags)
\r
98 > -FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags)
\r
99 > +FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
\r
100 > +FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS)
\r
101 > FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lutil -Llib -lnotmuch $(AS_NEEDED_LDFLAGS) $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS)
\r
102 > FINAL_NOTMUCH_LINKER = CC
\r
103 > ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
\r
107 > _______________________________________________
\r
108 > notmuch mailing list
\r
109 > notmuch@notmuchmail.org
\r
110 > http://notmuchmail.org/mailman/listinfo/notmuch
\r