1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F34C2431FC2
\r
6 for <notmuch@notmuchmail.org>; Fri, 23 Aug 2013 01:37:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id CNbk3HRYZTtp for <notmuch@notmuchmail.org>;
\r
18 Fri, 23 Aug 2013 01:37:05 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 0D093431FAE
\r
23 for <notmuch@notmuchmail.org>; Fri, 23 Aug 2013 01:37:05 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1VCmrT-0001ci-0R; Fri, 23 Aug 2013 09:36:55 +0100
\r
28 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1VCmrS-00012V-OV; Fri, 23 Aug 2013 09:36:50 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
34 Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org
\r
35 Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts
\r
36 In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>
\r
37 References: <m3r4dtgz9k.fsf@zsu.kismala.com>
\r
38 <87fvu4fl25.fsf@servo.finestructure.net>
\r
39 User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
\r
41 Date: Fri, 23 Aug 2013 09:36:49 +0100
\r
42 Message-ID: <87d2p44xcu.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 93.97.24.31
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: 7cedcee375505232f81e04db53dd705d (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: 0.6
\r
49 X-SpamAssassin-SpamBar: /
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored 0.6 points. Summary of the scoring:
\r
54 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
55 provider * (markwalters1009[at]gmail.com)
\r
56 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
57 * -0.4 AWL AWL: From: address is in the auto white-list
\r
58 X-QM-Scan-Virus: ClamAV says the message is clean
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Fri, 23 Aug 2013 08:37:11 -0000
\r
74 Jameson Graef Rollins <jrollins@finestructure.net> writes:
\r
76 > On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:
\r
77 >> When text/html parts include images as multipart/related and the
\r
78 >> text/plain alternative is used these images can be completely hidden
\r
79 >> with no easy way to access them or even find out that they are there.
\r
81 >> Make notmuch-show-insert-part-multipart/related add buttons for all
\r
82 >> parts, the first one visible the rest hidden.
\r
84 > Hey, Istvan. Thanks so much for this patch. It seems to be addressing
\r
85 > the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.
\r
87 > However, the behavior of the part button that now appears seems to be a
\r
88 > bit strange. Clicking/hitting enter on the part attempts to save it
\r
89 > rather than open it. I wouldn't be surprised if has nothing to do with
\r
90 > the correctness of this patch, though. So is it possible that the
\r
91 > button is not inserted in the most ideal way, or is there some other
\r
92 > issue preventing it from behaving properly (could it have to do with the
\r
93 > part being "inline"?)?
\r
98 I think I have diagnosed this bug. There is a potential fix in
\r
99 id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com
\r
101 The bug is nothing to do with Istvan's patch: his patch just triggers the
\r
102 underlying bug in the lazy part handling.
\r