1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B0C5540CAE4
\r
6 for <notmuch@notmuchmail.org>; Mon, 9 Apr 2012 11:42:06 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id VPUgNIrZDc2p for <notmuch@notmuchmail.org>;
\r
17 Mon, 9 Apr 2012 11:42:06 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D14C340CAC7
\r
22 for <notmuch@notmuchmail.org>; Mon, 9 Apr 2012 11:42:05 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SHJXP-0008GX-Qq; Mon, 09 Apr 2012 19:42:04 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SHJXP-0004D0-HY; Mon, 09 Apr 2012 19:42:03 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
34 Notmuch Mail <notmuch@notmuchmail.org>
\r
35 Subject: Re: [PATCH 7/8] emacs: modify show tag functions to use new
\r
36 notmuch-tag interface
\r
37 In-Reply-To: <1333845338-22960-8-git-send-email-jrollins@finestructure.net>
\r
38 References: <1333354853-25729-1-git-send-email-jrollins@finestructure.net>
\r
39 <1333845338-22960-1-git-send-email-jrollins@finestructure.net>
\r
40 <1333845338-22960-2-git-send-email-jrollins@finestructure.net>
\r
41 <1333845338-22960-3-git-send-email-jrollins@finestructure.net>
\r
42 <1333845338-22960-4-git-send-email-jrollins@finestructure.net>
\r
43 <1333845338-22960-5-git-send-email-jrollins@finestructure.net>
\r
44 <1333845338-22960-6-git-send-email-jrollins@finestructure.net>
\r
45 <1333845338-22960-7-git-send-email-jrollins@finestructure.net>
\r
46 <1333845338-22960-8-git-send-email-jrollins@finestructure.net>
\r
47 User-Agent: Notmuch/0.12+111~g5c30f66 (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Mon, 09 Apr 2012 19:42:20 +0100
\r
50 Message-ID: <87y5q4lpbn.fsf@qmul.ac.uk>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-Sender-Host-Address: 94.192.233.223
\r
54 X-QM-SPAM-Info: Sender has good ham record. :)
\r
55 X-QM-Body-MD5: b6ab2e450acd5a52c128883779276f2e (of first 20000 bytes)
\r
56 X-SpamAssassin-Score: -1.8
\r
57 X-SpamAssassin-SpamBar: -
\r
58 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
60 spam. We require at least 5.0 points to mark a message as spam.
\r
61 This message scored -1.8 points.
\r
62 Summary of the scoring:
\r
63 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
65 * [138.37.6.40 listed in list.dnswl.org]
\r
66 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
67 provider * (markwalters1009[at]gmail.com)
\r
68 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
70 * 0.5 AWL AWL: From: address is in the auto white-list
\r
71 X-QM-Scan-Virus: ClamAV says the message is clean
\r
72 X-BeenThere: notmuch@notmuchmail.org
\r
73 X-Mailman-Version: 2.1.13
\r
75 List-Id: "Use and development of the notmuch mail system."
\r
76 <notmuch.notmuchmail.org>
\r
77 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
79 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
80 List-Post: <mailto:notmuch@notmuchmail.org>
\r
81 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
82 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
83 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
84 X-List-Received-Date: Mon, 09 Apr 2012 18:42:06 -0000
\r
86 On Sun, 08 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
87 > The main change here is to modify argument parsing so as to not force
\r
88 > tag-changes to be a list, and to let notmuch-tag handle prompting the
\r
89 > user when required. doc strings are also updated and cleaned up.
\r
91 One other comment on this patch is that it would be nice to have a tag
\r
92 region in show view as well. Of course that is a feature request rather
\r
93 than a requirement for this patch series!
\r
100 > emacs/notmuch-show.el | 26 +++++++++++++++-----------
\r
101 > 1 files changed, 15 insertions(+), 11 deletions(-)
\r
103 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
104 > index a4c313d..69bca02 100644
\r
105 > --- a/emacs/notmuch-show.el
\r
106 > +++ b/emacs/notmuch-show.el
\r
107 > @@ -1641,22 +1641,26 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
108 > (let* ((current-tags (notmuch-show-get-tags))
\r
109 > (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
110 > (unless (equal current-tags new-tags)
\r
111 > - (apply 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
112 > + (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
113 > (notmuch-show-set-tags new-tags))))
\r
115 > -(defun notmuch-show-tag (&optional initial-input)
\r
116 > - "Change tags for the current message, read input from the minibuffer."
\r
117 > +(defun notmuch-show-tag (&optional tag-changes)
\r
118 > + "Change tags for the current message.
\r
120 > +See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
122 > - (let ((tag-changes (notmuch-read-tag-changes
\r
123 > - initial-input (notmuch-show-get-message-id))))
\r
124 > - (apply 'notmuch-show-tag-message tag-changes)))
\r
125 > + (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
126 > + (let* ((current-tags (notmuch-show-get-tags))
\r
127 > + (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
128 > + (unless (equal current-tags new-tags)
\r
129 > + (notmuch-show-set-tags new-tags))))
\r
131 > -(defun notmuch-show-tag-all (&rest tag-changes)
\r
132 > - "Change tags for all messages in the current buffer.
\r
133 > +(defun notmuch-show-tag-all (&optional tag-changes)
\r
134 > + "Change tags for all messages in the current show buffer.
\r
136 > -TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
137 > - (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))
\r
138 > - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
139 > +See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
141 > + (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
142 > (notmuch-show-mapc
\r
144 > (let* ((current-tags (notmuch-show-get-tags))
\r
148 > _______________________________________________
\r
149 > notmuch mailing list
\r
150 > notmuch@notmuchmail.org
\r
151 > http://notmuchmail.org/mailman/listinfo/notmuch
\r