1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 70170431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 8 Nov 2012 00:55:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YFKg8TAXYXcK for <notmuch@notmuchmail.org>;
\r
16 Thu, 8 Nov 2012 00:55:37 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id BC8DB431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 8 Nov 2012 00:55:37 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id A6991100094;
\r
22 Thu, 8 Nov 2012 10:55:36 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Blake Jones <blakej@foo.net>
\r
25 Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output
\r
27 In-Reply-To: <24582.1352356152@foo.net>
\r
28 References: <24582.1352356152@foo.net>
\r
29 User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Thu, 08 Nov 2012 10:55:36 +0200
\r
35 Message-ID: <m2bof8fp87.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 Cc: notmuch@notmuchmail.org
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Thu, 08 Nov 2012 08:55:38 -0000
\r
53 On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote:
\r
55 >>> @@ -11,10 +12,44 @@ fi
\r
59 >>> +if [ `uname -s` == SunOS ] ; then
\r
61 >>> + # Using Solaris "nm", a defined symbol looks like this:
\r
64 >> The POSIX / Bourne -comformant equality comparison is '='.
\r
66 > Sigh, of course it is. Fixed.
\r
70 >> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x'
\r
71 >> ./heirloom-sh/sh: test: unknown operator ==
\r
72 >> zsh: exit 1 ./heirloom-sh/sh -c ' [ a == b ] || echo x'
\r
74 >> Interesting that Solaris /bin/sh did not fail there...
\r
76 > I was running on Solaris 11.1, which uses ksh93 as its /bin/sh. You're
\r
77 > absolutely right that Solaris 10 would fall over, though.
\r
79 > Similarly, the following line:
\r
81 > demangled=$(demangle $sym)
\r
83 > doesn't work on traditional sh. I've replaced $() with ``.
\r
85 >> Hmm, gen-version-script doesn't have shebang... it is run like:
\r
87 >> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@
\r
89 >> in lib/Makefile.local -- taking sh fron PATH.
\r
91 > I updated the first line from the #! invocation to a comment saying
\r
93 > # This script is invoked via "sh .../gen-version-script.sh".
\r
97 > Would a respun version of these patches help toward testing?
\r
100 zsh: exit 1 grep vim test/*
\r
102 i.e. no vim tests...
\r
104 Also, as *I* will execute my tests in Linux these won't make things
\r
105 fail -- and probably no-one else eager to test won't have problems
\r
108 So I think these patches are good until someone(tm) finds other
\r