1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5397E429E26
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:42:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id NymrvpofC8HU for <notmuch@notmuchmail.org>;
\r
16 Thu, 12 Jan 2012 06:42:57 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 85325431FB6
\r
21 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:42:57 -0800 (PST)
\r
22 Received: by werm12 with SMTP id m12so1653512wer.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:42:56 -0800 (PST)
\r
24 Received: by 10.216.139.94 with SMTP id b72mr1669456wej.38.1326379376008;
\r
25 Thu, 12 Jan 2012 06:42:56 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id fq7sm6023034wbb.1.2012.01.12.06.42.54
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Thu, 12 Jan 2012 06:42:54 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id D1BA99FF01; Thu, 12 Jan 2012 14:42:52 +0000 (GMT)
\r
33 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts,
\r
36 In-Reply-To: <878vldgg3b.fsf@gmail.com>
\r
37 References: <1326279001-28427-1-git-send-email-dme@dme.org>
\r
38 <87k44ym6ka.fsf@gmail.com>
\r
39 <cun8vldm8q9.fsf@hotblack-desiato.hh.sledj.net>
\r
40 <878vldgg3b.fsf@gmail.com>
\r
41 User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org)
\r
42 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
43 From: David Edmondson <dme@dme.org>
\r
44 Date: Thu, 12 Jan 2012 14:42:49 +0000
\r
45 Message-ID: <cunr4z5kmmu.fsf@hotblack-desiato.hh.sledj.net>
\r
47 Content-Type: multipart/signed; boundary="=-=-=";
\r
48 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Thu, 12 Jan 2012 14:42:58 -0000
\r
64 Content-Type: text/plain
\r
65 Content-Transfer-Encoding: quoted-printable
\r
67 On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
\r
69 > I think there is a record of useful features and fixes that were not
\r
70 > accepted to notmuch because of some implementation issues. And
\r
71 > interested people were using them in private repos for years. (I do not
\r
72 > say that it is always the right thing to do, or that it is the right
\r
73 > thing in this particular case.)
\r
75 I agree that this has happened. I think that it's a failure of the
\r
76 project that it has become common, necessary and generally accepted.
\r
78 > I would like to see the following changes:
\r
80 > * Properly handle charset with parameters in Emacs UI. Currently it is
\r
81 > broken by your patch in one place at least:
\r
82 > `notmuch-show-handlers-for' would produce incorrect results for
\r
83 > content-type string with parameters. In my patch [1] I did parse the
\r
84 > charset at top level and then changed all usages of it accordingly.
\r
85 > Making `notmuch-show-handlers-for' smarter about parameters may be
\r
86 > sufficient, but I would like to see some more details on why adding
\r
87 > parameters to content-type string does not break Emacs UI code in
\r
90 Your patch modifies the output of 'notmuch show' such that it included
\r
91 the full value of the content-type header, which means that it is
\r
92 necessary to parse it more carefully in emacs to discover and (as
\r
93 necessary) remove the parameters. The patch I posted doesn't do this,
\r
94 preferring to pass the charset (if any) as a supplementary parameter and
\r
95 leave the content-type as-is. This distinction means that the patch I
\r
96 posted isn't broken in the way that you describe.
\r
98 > * Add charset parameter for text/html parts only.
\r
100 Version 2 of the patch does this.
\r
102 > * Use `mail-header-parse-content-type' to parse content-type instead of
\r
103 > contructing the list for `mm-make-handle' manually.
\r
105 That's not required, see above.
\r
107 > * Add a proper XXX comment to notmuch-show code.
\r
109 I'm happy to do that.
\r
111 > I cannot say I would be happy about this patch after these changes.
\r
113 Can you say why? I agree that it is not a solution to all problems, but
\r
114 it is a workable solution to a specific problem.
\r
116 > It would be a temporary hack anyway.
\r
118 Agreed. Do you have any idea when you might be able to spend time on the
\r
122 Content-Type: application/pgp-signature
\r
124 -----BEGIN PGP SIGNATURE-----
\r
125 Version: GnuPG v1.4.11 (GNU/Linux)
\r
127 iEYEARECAAYFAk8O8WkACgkQaezQq/BJZRbongCfREmIxN1aW/3klf2Zv3spzWXg
\r
128 jc4AniupkJ2WWp/R+OalxBMXkwjd9pek
\r
130 -----END PGP SIGNATURE-----
\r
projects / notmuch-archives.git / blob