1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 04C19431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 25 Feb 2013 22:48:10 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id kEyIqVH0qCmL for <notmuch@notmuchmail.org>;
\r
16 Mon, 25 Feb 2013 22:48:09 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id F3E44431FAF
\r
19 for <notmuch@notmuchmail.org>; Mon, 25 Feb 2013 22:48:08 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id A1373100044;
\r
22 Tue, 26 Feb 2013 08:47:56 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2] lib: Fix name reordering to handle commas without
\r
27 In-Reply-To: <1361832433-13036-1-git-send-email-awg+notmuch@xvx.ca>
\r
28 References: <m238xavdkt.fsf@guru.guru-group.fi>
\r
29 <1361832433-13036-1-git-send-email-awg+notmuch@xvx.ca>
\r
30 User-Agent: Notmuch/0.15.2+45~g5d28a00 (http://notmuchmail.org) Emacs/24.2.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Tue, 26 Feb 2013 08:47:56 +0200
\r
36 Message-ID: <m238wjr2oz.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 26 Feb 2013 06:48:10 -0000
\r
53 On Tue, Feb 26 2013, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
\r
55 > Notmuch automatically re-orders names of the format "Last, First" to
\r
56 > "First Last" when the associated email address is
\r
57 > First.Last@example.com. But, if a name is of the format "Last,First"
\r
58 > then notmuch will format the name as "irst Last". Handle any number of
\r
59 > spaces after the comma, including none.
\r
62 > Good idea, Tomi. This version handles any number of spaces.
\r
69 > lib/thread.cc | 12 ++++++++++--
\r
70 > 1 file changed, 10 insertions(+), 2 deletions(-)
\r
72 > diff --git a/lib/thread.cc b/lib/thread.cc
\r
73 > index e976d64..ce6b0ef 100644
\r
74 > --- a/lib/thread.cc
\r
75 > +++ b/lib/thread.cc
\r
76 > @@ -186,8 +186,16 @@ _thread_cleanup_author (notmuch_thread_t *thread,
\r
77 > if (comma && strlen(comma) > 1) {
\r
78 > /* let's assemble what we think is the correct name */
\r
79 > lname = comma - author;
\r
80 > - fname = strlen(author) - lname - 2;
\r
81 > - strncpy(clean_author, comma + 2, fname);
\r
83 > + /* Skip all the spaces after the comma */
\r
84 > + fname = strlen(author) - lname - 1;
\r
86 > + while (*comma == ' ') {
\r
90 > + strncpy(clean_author, comma, fname);
\r
92 > *(clean_author+fname) = ' ';
\r
93 > strncpy(clean_author + fname + 1, author, lname);
\r
94 > *(clean_author+fname+1+lname) = '\0';
\r
98 > _______________________________________________
\r
99 > notmuch mailing list
\r
100 > notmuch@notmuchmail.org
\r
101 > http://notmuchmail.org/mailman/listinfo/notmuch
\r