1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A0403431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id KoDjMDmB6xyX for <notmuch@notmuchmail.org>;
\r
17 Mon, 15 Oct 2012 10:12:08 -0700 (PDT)
\r
18 Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com
\r
19 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id A10C5431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:08 -0700 (PDT)
\r
23 Received: by mail-qc0-f181.google.com with SMTP id x40so4820367qcp.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:08 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=kGBkaDph+R6AE03TuTZwYu6VSGhYX9zXYOtvflAl4dg=;
\r
29 b=wGKBwVe5qezSjb8c2WTwQH9kagDllaJZS89NmtNSvp/Teyk4b+BQ3i1Zx516KGOr+4
\r
30 9PDu9+7aF+/4kdP0kMxWjj9FSTo0XId2+Ntz5c9QBfElL1oYcpx9p7AzekvvDHXIN4bB
\r
31 jFyxq7ALRZRrl2FmV1ybDJX9jiCyBNW7BVBkLvKGrBvSebJo6XUldWMB8OvnItaRDHtL
\r
32 ipG/LpmK1jT7VQIL4FeH1HRWQjjAKncnEKkq/viQ7HXl6oAkcXSoto+gS1xhfW0qq49R
\r
33 0ooey+mOmqFJyqsN6N3P+peh5T9keX/9b+dw9AVuoH6RqRI4T1zm0wyGG/iRpqbJruVY
\r
35 Received: by 10.224.31.204 with SMTP id z12mr12704102qac.32.1350321127827;
\r
36 Mon, 15 Oct 2012 10:12:07 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id hk10sm7707580qab.22.2012.10.15.10.12.05
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Mon, 15 Oct 2012 10:12:06 -0700 (PDT)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
43 Notmuch Mail <notmuch@notmuchmail.org>
\r
44 Subject: Re: [PATCH 1/2] test: emacs mailto: URI handling
\r
45 In-Reply-To: <1327865624-7673-1-git-send-email-jrollins@finestructure.net>
\r
46 References: <1327865624-7673-1-git-send-email-jrollins@finestructure.net>
\r
47 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Mon, 15 Oct 2012 13:12:04 -0400
\r
50 Message-ID: <877gqracd7.fsf@betacantrips.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Mon, 15 Oct 2012 17:12:10 -0000
\r
67 Jameson Graef Rollins <jrollins@finestructure.net> writes:
\r
69 > This adds a test for proposed rfc6068 "mailto:" URI handling. The
\r
70 > proposed function would be called 'notmuch-mua-mailto'. The test
\r
71 > provides an example mailto: string that should test some subset of the
\r
72 > rfc6068 specification: http://tools.ietf.org/html/rfc6068
\r
74 Hi! Just going through the patch queue. This test, at least, looks
\r
75 sane, so why not apply it?
\r
77 As for the mailto: handler itself, you wrote in
\r
78 id:"87vcin2fo6.fsf@servo.finestructure.net" that you would add something
\r
79 to the next version, thereby implying that there would be a next
\r
80 version. Do you still intend to release such a new version soon? I would
\r
81 love to review it. This version looks fine to me, with one minor concern.
\r
83 > + ;; FIXME: need to decode all html encodings in uri.
\r
84 > + (mailto (replace-regexp-in-string "&" "&" mailto))
\r
86 This is odd. Shouldn't the navigator be decoding all that stuff while
\r
87 parsing, before you even get to it? How often do you get mailto links
\r
88 with & in them? You obviously wouldn't have put it in there if it
\r
91 I would be +1 on merging this patch or the next version.
\r