1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0D4F9431FC7
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 11:02:20 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id QLYHjzkY+Xs7 for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 May 2014 11:02:16 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A7963431FC2
\r
19 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 11:02:16 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 04CEA100051;
\r
22 Mon, 12 May 2014 21:02:08 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] build: fix order of rpath
\r
26 In-Reply-To: <1399861345-25397-1-git-send-email-felipe.contreras@gmail.com>
\r
27 References: <1399861345-25397-1-git-send-email-felipe.contreras@gmail.com>
\r
28 User-Agent: Notmuch/0.18+11~gb21401f (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 12 May 2014 21:02:07 +0300
\r
34 Message-ID: <m2oaz2zxi8.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 Cc: Moritz Wilhelmy <moritz+git@wzff.de>
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 12 May 2014 18:02:20 -0000
\r
52 On Mon, May 12 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
\r
54 > In my system `pkg-config --libs talloc` returns
\r
55 > 'Wl,-rpath,/usr/lib -ltalloc' (probably wrongly) which causes the final
\r
56 > LDFLAGS to be something like '-Wl,-rpath,/usr/lib
\r
57 > -Wl,-rpath,/opt/notmuch/lib', which causes the RUNPATH to be
\r
58 > '/usr/lib:/opt/notmuch/lib', so basically defeating the whole purpose of
\r
61 > I noticed this when my /opt/notmuch/bin/notmuch (0.17) started updating
\r
62 > the database after I updated the system (which updated the system's
\r
63 > notmuch). This shouldn't happen.
\r
65 > Let's move the RUNPATH flags before other external flags have a chance of
\r
66 > screwing the build.
\r
68 > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
71 LGTM. Works for me (i.e. did not break my RPATH setting for notmuch-shared binary.
\r
76 > Makefile.local | 9 +++++----
\r
77 > 1 file changed, 5 insertions(+), 4 deletions(-)
\r
79 > diff --git a/Makefile.local b/Makefile.local
\r
80 > index fa07d81..af79b5c 100644
\r
81 > --- a/Makefile.local
\r
82 > +++ b/Makefile.local
\r
83 > @@ -46,15 +46,16 @@ PV_FILE=bindings/python/notmuch/version.py
\r
84 > # Smash together user's values with our extra values
\r
85 > FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
\r
86 > FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS)
\r
87 > -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lutil -Llib -lnotmuch $(AS_NEEDED_LDFLAGS) $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS) $(ZLIB_LDFLAGS)
\r
88 > +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lutil -Llib -lnotmuch
\r
89 > +ifeq ($(LIBDIR_IN_LDCONFIG),0)
\r
90 > +FINAL_NOTMUCH_LDFLAGS += $(RPATH_LDFLAGS)
\r
92 > +FINAL_NOTMUCH_LDFLAGS += $(AS_NEEDED_LDFLAGS) $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS) $(ZLIB_LDFLAGS)
\r
93 > FINAL_NOTMUCH_LINKER = CC
\r
94 > ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
\r
95 > FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)
\r
96 > FINAL_NOTMUCH_LINKER = CXX
\r
98 > -ifeq ($(LIBDIR_IN_LDCONFIG),0)
\r
99 > -FINAL_NOTMUCH_LDFLAGS += $(RPATH_LDFLAGS)
\r
101 > FINAL_LIBNOTMUCH_LDFLAGS = $(LDFLAGS) $(AS_NEEDED_LDFLAGS) $(CONFIGURE_LDFLAGS)
\r
105 > 1.9.2+fc1~45~g3953d93
\r
107 > _______________________________________________
\r
108 > notmuch mailing list
\r
109 > notmuch@notmuchmail.org
\r
110 > http://notmuchmail.org/mailman/listinfo/notmuch
\r