1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 561DA431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 10 Nov 2011 16:18:34 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id K7Q3rpT2RG5c for <notmuch@notmuchmail.org>;
\r
16 Thu, 10 Nov 2011 16:18:33 -0800 (PST)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 99B08431FB6
\r
21 for <notmuch@notmuchmail.org>; Thu, 10 Nov 2011 16:18:33 -0800 (PST)
\r
22 Received: by wyg8 with SMTP id 8so3713465wyg.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 10 Nov 2011 16:18:30 -0800 (PST)
\r
24 Received: by 10.227.197.199 with SMTP id el7mr6177292wbb.12.1320970710704;
\r
25 Thu, 10 Nov 2011 16:18:30 -0800 (PST)
\r
26 Received: from localhost (26.48-242-81.adsl-dyn.isp.belgacom.be.
\r
28 by mx.google.com with ESMTPS id j29sm2938985wbn.5.2011.11.10.16.18.29
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Thu, 10 Nov 2011 16:18:30 -0800 (PST)
\r
31 From: Pieter Praet <pieter@praet.org>
\r
32 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
33 Notmuch Mail <notmuch@notmuchmail.org>
\r
34 Subject: Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.
\r
35 In-Reply-To: <1320963737-1666-1-git-send-email-jrollins@finestructure.net>
\r
36 References: <yf6mxc3ab4t.fsf@taco2.nixu.fi>
\r
37 <1320963737-1666-1-git-send-email-jrollins@finestructure.net>
\r
38 User-Agent: Notmuch/0.9+37~g8861220 (http://notmuchmail.org) Emacs/23.3.1
\r
39 (x86_64-unknown-linux-gnu)
\r
40 Date: Fri, 11 Nov 2011 01:17:37 +0100
\r
41 Message-ID: <87hb2btsv2.fsf@praet.org>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Fri, 11 Nov 2011 00:18:34 -0000
\r
58 On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
59 > From: Tomi Ollila <tomi.ollila@iki.fi>
\r
61 > dtach is lighter than screen and is not setuid/setgid program so
\r
62 > TMPDIR does not get reset by dynamic loader when executed.
\r
65 `dtach' may be lighter than `screen', but contrary to my expectations,
\r
66 it appears to be far less efficient:
\r
68 | | original [1] | w/ screen [2] | w/ dtach [3] |
\r
69 |------+--------------+---------------+--------------|
\r
70 | real | 0m17.570s | 0m20.132s | 0m28.567s |
\r
71 | user | 0m2.453s | 0m2.593s | 0m2.753s |
\r
72 | sys | 0m1.700s | 0m1.577s | 0m1.753s |
\r
74 > Signed-off-by: Jameson Graef Rollins <jrollins@finestructure.net>
\r
76 > This tweaks the original patch slightly by removing the no-longer needed
\r
77 > screenrc variables.
\r
79 > test/test-lib.sh | 5 ++---
\r
80 > 1 files changed, 2 insertions(+), 3 deletions(-)
\r
82 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
83 > index c81c709..c0fe037 100755
\r
84 > --- a/test/test-lib.sh
\r
85 > +++ b/test/test-lib.sh
\r
86 > @@ -50,8 +50,6 @@ TZ=UTC
\r
88 > export LANG LC_ALL PAGER TERM TZ
\r
89 > GIT_TEST_CMP=${GIT_TEST_CMP:-diff -u}
\r
90 > -export SCREENRC=/dev/null
\r
91 > -export SYSSCREENRC=/dev/null
\r
93 > # Protect ourselves from common misconfiguration to export
\r
94 > # CDPATH into the environment
\r
95 > @@ -844,7 +842,8 @@ test_emacs () {
\r
96 > if [ -z "$EMACS_SERVER" ]; then
\r
97 > EMACS_SERVER="notmuch-test-suite-$$"
\r
98 > # start a detached screen session with an emacs server
\r
99 > - screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \
\r
100 > + TERM=xterm dtach -n "$TMP_DIRECTORY/dtach-emacs-socket-$$" \
\r
102 It's worth noting that $TERM is only set to "xterm" to deceive `dtach',
\r
103 so thankfully, xterm (and all its deps) aren't actually required to run
\r
106 > + "$TMP_DIRECTORY/run_emacs" \
\r
107 > --no-window-system \
\r
108 > --eval "(setq server-name \"$EMACS_SERVER\")" \
\r
109 > --eval '(server-start)' \
\r
113 > _______________________________________________
\r
114 > notmuch mailing list
\r
115 > notmuch@notmuchmail.org
\r
116 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
124 [1] @ commit 749abb74
\r
125 [2] @ commit 760b311b
\r
126 [3] @ commit 760b311b + id:"1320963737-1666-1-git-send-email-jrollins@finestructure.net"
\r