1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16DD6431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Hp2jRqMtQuQP for <notmuch@notmuchmail.org>;
\r
17 Sat, 20 Oct 2012 08:49:09 -0700 (PDT)
\r
18 Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com
\r
19 [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 8160C431FAE
\r
22 for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:09 -0700 (PDT)
\r
23 Received: by mail-vb0-f53.google.com with SMTP id fc21so1630032vbb.26
\r
24 for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:07 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=HVdoChQffd+po/3Q/yJr4BjVUzLpd3dHtL4jKVB88GU=;
\r
29 b=vz5pMIiXD0SHDWcfYK8cbgGbNIuF7xJ0FygQTkmR+6aUdhxEIPQKCILJ86twmY0UzA
\r
30 fuK3D8G7ZeeEQEvrteBkaNFzF/sKj3V3Ie74AF5ivFOkGI1Wn8bNfdN22DjP19pl7tG1
\r
31 hXxEg/M0t+XI2p8Cv0QOVdwGESbAhTYeFpyn3ADXR3zUlY7FfxowquC+xIIuydmwXNph
\r
32 BA6wja7PL37hcsIkTKgIjY59BApllH0KmQnWc3kAz6HSR3/sLZeFYVN0ktqZb/z9gQqf
\r
33 YjtbH3iHUWQgueq2NC4MSx05/+QK3jXv7T5ecuhjxdDhhOnVgvxN4MlNYt2ozwd1TlsY
\r
35 Received: by 10.220.221.203 with SMTP id id11mr6211516vcb.42.1350748147266;
\r
36 Sat, 20 Oct 2012 08:49:07 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id g5sm4347339vez.6.2012.10.20.08.49.05
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Sat, 20 Oct 2012 08:49:06 -0700 (PDT)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Jani Nikula <jani@nikula.org>, Adrien Bustany <adrien@bustany.org>,
\r
43 notmuch@notmuchmail.org
\r
44 Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t
\r
45 In-Reply-To: <87vce7yllt.fsf@nikula.org>
\r
46 References: <1342723401-26103-1-git-send-email-adrien@bustany.org>
\r
47 <1350510742-13447-1-git-send-email-adrien@bustany.org>
\r
48 <87vce7yllt.fsf@nikula.org>
\r
49 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Sat, 20 Oct 2012 11:49:04 -0400
\r
52 Message-ID: <87y5j15ekv.fsf@betacantrips.com>
\r
54 Content-Type: text/plain; charset=us-ascii
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Sat, 20 Oct 2012 15:49:10 -0000
\r
69 Jani Nikula <jani@nikula.org> writes:
\r
71 > On Wed, 17 Oct 2012, Adrien Bustany <adrien@bustany.org> wrote:
\r
72 >> The code of the patches in unchanged, but the formatting issues are now
\r
75 > Hi Adrien, please check at what version flush and reopen have been
\r
76 > introduced to xapian. If they are new-ish (I don't know, didn't have the
\r
77 > time to check), please add appropriate #ifdefs. [1] lays the groundwork
\r
78 > for this. We'll also need to decide what is the minimum xapian version
\r
79 > required in general, i.e. features earlier than that don't need
\r
80 > conditional compilation.
\r
82 Hi! The new versions of these patches are still pretty trivial and they
\r
83 still look OK to me, but based on Jani's prompting I decided to look up
\r
84 the methods. Seems that flush() is a very old (pre-1.1.0, 2009-04) name
\r
85 for commit(), which is the preferred name these days. You should
\r
86 probably therefore rename the function notmuch_database_commit, and have
\r
87 it call the WritableDatabase::commit() method.
\r
89 reopen() is a very very old method, seems like it has been around since
\r
92 So I think Adrien is safe from having to do version checks, but we
\r
93 should probably use commit() instead of flush().
\r