0f/6fcdaad4f7c8d313a5d79bee9781fffac21933

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 45E3E431FB6\r
   6         for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 19:24:40 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id L3PlHmwNuVtH for <notmuch@notmuchmail.org>;\r
  16         Thu,  5 Apr 2012 19:24:39 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B0F43431FAE\r
  20         for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 19:24:39 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7fbf6d0000008ba-b4-4f7e53e780e5\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 84.C0.02234.7E35E7F4; Thu,  5 Apr 2012 22:24:39 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q362Oc4M010151; \r
  27         Thu, 5 Apr 2012 22:24:39 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q362ObRI026334\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 5 Apr 2012 22:24:38 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SFyqq-0004x3-S0; Thu, 05 Apr 2012 22:24:37 -0400\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)\r
  40 In-Reply-To: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com>\r
  41 References: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com>\r
  42 User-Agent: Notmuch/0.12+107~gf2d67c3 (http://notmuchmail.org) Emacs/23.3.1\r
  43         (i486-pc-linux-gnu)\r
  44 Date: Thu, 05 Apr 2012 22:24:36 -0400\r
  45 Message-ID: <87lim97g2j.fsf@awakening.csail.mit.edu>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6nrvs8uM7f4EWHkMXquTwW12/OZHZg\r
  50         8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4MtqaLjIXNLFVLJ08k7WB8R1LFyMnh4SAicS1\r
  51         addZIWwxiQv31rN1MXJxCAnsY5T4PWEBM4SznlHi+qzXLBDOCSaJp/t2QpUtYZSYtek42Cw2\r
  52         AQ2JbfuXM4LYIgKuEk+/fWYGsYUFfCQOvf8KFucU8JL4ceUaO4gtJOApsenRZrBeUYF4iXUN\r
  53         78HuYBFQlXjZv58NxOYFum9nywYmCFtQ4uTMJ2D1zAJaEjf+vWSawCgwC0lqFpLUAkamVYyy\r
  54         KblVurmJmTnFqcm6xcmJeXmpRbpGermZJXqpKaWbGEEhySnJu4Px3UGlQ4wCHIxKPLwnt9b6\r
  55         C7EmlhVX5h5ilORgUhLlPR9U5y/El5SfUpmRWJwRX1Sak1p8iFGCg1lJhDfcAyjHm5JYWZVa\r
  56         lA+TkuZgURLnVdV65yckkJ5YkpqdmlqQWgSTleHgUJLgnQkyVLAoNT21Ii0zpwQhzcTBCTKc\r
  57         B2i4aTDI8OKCxNzizHSI/ClGRSlxXg6QhABIIqM0D64XljJeMYoDvSLMqwNSxQNMN3Ddr4AG\r
  58         MwENPvm1GmRwSSJCSqqB0XOVwJYtZwKOXyk9++epjYvYtdhtLzkOu77+5Faz7uLJha6cbHEa\r
  59         j/yK7u/sEX7bZmK68Khnxuyq//sDb/48n3dnl2r3n0vXdB5XSQc+XtdiWuc4k6HeSyXF2/Wx\r
  60         6pz+aK79OzXcgo8vFJ360n3WUY6H2Tazky5n+arxtQrkz33vvTbz36/7H5RYijMSDbWYi4oT\r
  61         AVj7Koj0AgAA\r
  62 X-BeenThere: notmuch@notmuchmail.org\r
  63 X-Mailman-Version: 2.1.13\r
  64 Precedence: list\r
  65 List-Id: "Use and development of the notmuch mail system."\r
  66         <notmuch.notmuchmail.org>\r
  67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  70 List-Post: <mailto:notmuch@notmuchmail.org>\r
  71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  73         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  74 X-List-Received-Date: Fri, 06 Apr 2012 02:24:40 -0000\r
  75 \r
  76 On Sat, 31 Mar 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
  77 > This is version 2 of the exclude= series (version 1 is [1]).\r
  78 >\r
  79 > The main changes are the addition of some systematic notmuch-search\r
  80 > tests for all the exclude options, and I no longer add the\r
  81 > exclude=flag option to notmuch-show.c (the output was too similar to\r
  82 > exclude=false to be worth keeping).\r
  83 >\r
  84 > Best wishes\r
  85 >\r
  86 > Mark\r
  87 >\r
  88 >\r
  89 > id:"1331836925-31437-1-git-send-email-markwalters1009@gmail.com".\r
  90 \r
  91 Sorry for the slow review.  Besides my fairly superficial comments,\r
  92 everything else LGTM.\r
  93 \r
  94 It's great to see exclude really turning into a robust feature!  I had\r
  95 no idea the path would be this long when I wrote that original little\r
  96 hack.  I'm thankful you're sticking with it.\r