1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 27BA7429E5B
\r
6 for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 01:25:14 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id gTB6cI26+Afj for <notmuch@notmuchmail.org>;
\r
16 Wed, 29 Jun 2011 01:25:12 -0700 (PDT)
\r
17 Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
\r
18 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 48E66429E55
\r
21 for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 01:25:12 -0700 (PDT)
\r
22 Received: by qwb7 with SMTP id 7so602992qwb.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 01:25:11 -0700 (PDT)
\r
24 Received: by 10.224.70.143 with SMTP id d15mr350663qaj.171.1309335911461;
\r
25 Wed, 29 Jun 2011 01:25:11 -0700 (PDT)
\r
26 Received: from localhost (nikula.org [92.243.24.172])
\r
27 by mx.google.com with ESMTPS id g11sm755758qcm.3.2011.06.29.01.25.09
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 29 Jun 2011 01:25:09 -0700 (PDT)
\r
30 From: Jani Nikula <jani@nikula.org>
\r
31 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 1/3] test: `notmuch-show-advance-and-archive' with
\r
34 In-Reply-To: <87pqlxw7d0.fsf@gmail.com>
\r
35 References: <1309312132-14564-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
36 <87pqlxw7d0.fsf@gmail.com>
\r
37 User-Agent: Notmuch/0.5-232-g917e874 (http://notmuchmail.org) Emacs/23.1.1
\r
39 Date: Wed, 29 Jun 2011 08:25:06 +0000
\r
40 Message-ID: <87ei2dujrx.fsf@nikula.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Wed, 29 Jun 2011 08:25:14 -0000
\r
57 On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
58 > On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
59 > > This patch series fixes the bug reported by Sebastien in [1]. I
\r
60 > > was able to reproduce it and confirm that the second patch from
\r
61 > > this series fixes the problem. Unfortunately, I can not explain
\r
62 > > why it fixes it. The patch uses a cleaner approach for visible
\r
63 > > text search. But the old approach should work fine as well.
\r
64 > > Apparently, it does not work when `invisible' property is not a
\r
65 > > single symbol but a list (which was changed in
\r
66 > > 95ef8da29439f2e79115c36ab4d2a80aef1a1462). I suspect that it is
\r
67 > > an Emacs bug. I plan to look at it later.
\r
70 > Turns out that `point-invisible-p' is a function from notmuch-lib.el, I
\r
71 > did not realize that before. It implements a custom visibility check
\r
72 > which is incomplete and does not work correctly when `invisible'
\r
73 > property is a list. That is why the previous code (which used
\r
74 > `point-invisible-p') had the bug. I sent another patch that removes
\r
75 > `point-invisible-p' function.
\r
77 > > Another issue is that the test does not demonstrate the bug.
\r
78 > > Again, I do not really know why. It passes both before and after
\r
79 > > the fix. Although if I run the test commands by hand I hit the
\r
80 > > bug. I guess it has something to do with emacs daemon mode when
\r
81 > > the buffer is not visible. I hope someone with a better elisp
\r
82 > > knowledge can tell what is going on and how to make the test
\r
86 > Now it is clear where the bug was. Remaining question is how to test
\r
89 Hi, I applied the series, and I can confirm it fixes the bug. Hiding of
\r
90 messages also seems to work as expected, including the un-hidden
\r
91 signatures, which is what the commit that introduced this bug originally
\r
92 fixed. Many thanks. I have no insights on the automated tests, though.
\r