1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 706E4429E27
\r
6 for <notmuch@notmuchmail.org>; Sat, 1 Nov 2014 17:54:08 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Yk3LWgHdpr4N for <notmuch@notmuchmail.org>;
\r
16 Sat, 1 Nov 2014 17:54:03 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 5C125429E26
\r
19 for <notmuch@notmuchmail.org>; Sat, 1 Nov 2014 17:54:03 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.7])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id B9A6E5CD288;
\r
22 Sun, 2 Nov 2014 01:54:02 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP STYX AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,
\r
27 with ESMTP id ZFiLrnN3PHBq; Sun, 2 Nov 2014 01:53:58 +0100 (CET)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 7B1A85CD287;
\r
30 Sun, 2 Nov 2014 01:53:57 +0100 (CET)
\r
31 Received: from wsh by steelpick.2x.cz with local (Exim 4.84)
\r
32 (envelope-from <sojkam1@fel.cvut.cz>)
\r
33 id 1XkjQb-0008Cc-4b; Sun, 02 Nov 2014 01:53:57 +0100
\r
34 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
35 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH v6 6/7] cli: search: Add --output=count
\r
37 In-Reply-To: <87r3xnu3dn.fsf@qmul.ac.uk>
\r
38 References: <1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz>
\r
39 <1414792441-29555-7-git-send-email-sojkam1@fel.cvut.cz>
\r
40 <87r3xnu3dn.fsf@qmul.ac.uk>
\r
41 User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Sun, 02 Nov 2014 01:53:57 +0100
\r
44 Message-ID: <87bnoqbexm.fsf@steelpick.2x.cz>
\r
46 Content-Type: text/plain
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Sun, 02 Nov 2014 00:54:08 -0000
\r
61 On Sat, Nov 01 2014, Mark Walters wrote:
\r
62 > On Fri, 31 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
63 >> This output can be used with --output=recipients or --output=sender
\r
64 >> and in addition to the addresses, it prints how many times was each
\r
65 >> address encountered during search.
\r
69 > I have a couple comments on this patch.
\r
72 >> completion/notmuch-completion.bash | 2 +-
\r
73 >> completion/notmuch-completion.zsh | 2 +-
\r
74 >> doc/man1/notmuch-search.rst | 9 +++++--
\r
75 >> notmuch-search.c | 51 ++++++++++++++++++++++++++++++++------
\r
76 >> 4 files changed, 52 insertions(+), 12 deletions(-)
\r
78 >> diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash
\r
79 >> index cfbd389..39cd829 100644
\r
80 >> --- a/completion/notmuch-completion.bash
\r
81 >> +++ b/completion/notmuch-completion.bash
\r
82 >> @@ -294,7 +294,7 @@ _notmuch_search()
\r
86 >> - COMPREPLY=( $( compgen -W "summary threads messages files tags sender recipients" -- "${cur}" ) )
\r
87 >> + COMPREPLY=( $( compgen -W "summary threads messages files tags sender recipients count" -- "${cur}" ) )
\r
91 >> diff --git a/completion/notmuch-completion.zsh b/completion/notmuch-completion.zsh
\r
92 >> index 3e52a00..d7e5a5e 100644
\r
93 >> --- a/completion/notmuch-completion.zsh
\r
94 >> +++ b/completion/notmuch-completion.zsh
\r
95 >> @@ -53,7 +53,7 @@ _notmuch_search()
\r
96 >> '--max-threads=[display only the first x threads from the search results]:number of threads to show: ' \
\r
97 >> '--first=[omit the first x threads from the search results]:number of threads to omit: ' \
\r
98 >> '--sort=[sort results]:sorting:((newest-first\:"reverse chronological order" oldest-first\:"chronological order"))' \
\r
99 >> - '--output=[select what to output]:output:((summary threads messages files tags sender recipients))'
\r
100 >> + '--output=[select what to output]:output:((summary threads messages files tags sender recipients count))'
\r
104 >> diff --git a/doc/man1/notmuch-search.rst b/doc/man1/notmuch-search.rst
\r
105 >> index 42f17e4..ec89200 100644
\r
106 >> --- a/doc/man1/notmuch-search.rst
\r
107 >> +++ b/doc/man1/notmuch-search.rst
\r
108 >> @@ -96,9 +96,14 @@ Supported options for **search** include
\r
109 >> Like **sender** but for addresses from *To*, *Cc* and
\r
113 >> + Can be used in combination with **sender** or
\r
114 >> + **recipients** to print the count of how many times was
\r
115 >> + the address encountered during search.
\r
117 >> This option can be given multiple times to combine different
\r
118 >> - outputs. Currently, this is only supported for **sender** and
\r
119 >> - **recipients** outputs.
\r
120 >> + outputs. Currently, this is only supported for **sender**,
\r
121 >> + **recipients** and **count** outputs.
\r
123 > It might be worth saying that the results will be slower if count is
\r
126 I wrote something like this in
\r
127 id:1414889400-30977-10-git-send-email-sojkam1@fel.cvut.cz.
\r
130 >> ``--sort=``\ (**newest-first**\ \|\ **oldest-first**)
\r
132 > I think sort works as expected if count is not specified, but does not
\r
137 > Maybe count can be done by doing two passes?
\r
139 What do you mean by pass?
\r
141 > If it is difficult it might be sufficient to just document that sort
\r
144 I'd do it this way :)
\r