1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C149F431E62
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 02:36:44 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5aYkz0O2cG+d for <notmuch@notmuchmail.org>;
\r
16 Mon, 16 Jan 2012 02:36:44 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 0EE72431FC0
\r
21 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 02:36:43 -0800 (PST)
\r
22 Received: by wibhr12 with SMTP id hr12so2263675wib.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 02:36:42 -0800 (PST)
\r
24 Received: by 10.180.82.5 with SMTP id e5mr13282465wiy.18.1326710202927;
\r
25 Mon, 16 Jan 2012 02:36:42 -0800 (PST)
\r
26 Received: from localhost ([109.131.75.86])
\r
27 by mx.google.com with ESMTPS id q34sm21704500wbm.15.2012.01.16.02.36.41
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Mon, 16 Jan 2012 02:36:41 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Austin Clements <amdragon@MIT.EDU>
\r
32 Subject: Re: [PATCH] emacs: logically group def{custom,face}s
\r
33 In-Reply-To: <20120114180828.GD1801@mit.edu>
\r
34 References: <87ty3ypsgp.fsf@praet.org>
\r
35 <1326531898-17356-1-git-send-email-pieter@praet.org>
\r
36 <20120114180828.GD1801@mit.edu>
\r
37 User-Agent: Notmuch/0.11+78~g6c58370 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-unknown-linux-gnu)
\r
39 Date: Mon, 16 Jan 2012 11:34:53 +0100
\r
40 Message-ID: <871ur02awi.fsf@praet.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 16 Jan 2012 10:36:44 -0000
\r
58 On Sat, 14 Jan 2012 13:08:28 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
59 > Quoth Pieter Praet on Jan 14 at 10:04 am:
\r
60 > > To allow for expansion whilst keeping everything tidy and organized,
\r
61 > > move all defcustom/defface variables to the following subgroups,
\r
62 > > defined in notmuch-lib.el:
\r
70 > > - External Commands
\r
73 > > As an added benefit, defcustom keyword args are now consistently
\r
74 > > in order of appearance @ defcustom's docstring (OCD much?).
\r
76 > Thanks for doing this. [...]
\r
78 You're very welcome!
\r
80 > [...] I recently went into customize-group notmuch
\r
81 > and was overwhelmed by the pile of options presented.
\r
86 > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
87 > > index 0f856bf..f6f48e9 100644
\r
88 > > --- a/emacs/notmuch-lib.el
\r
89 > > +++ b/emacs/notmuch-lib.el
\r
90 > > @@ -28,17 +28,58 @@
\r
91 > > "Notmuch mail reader for Emacs."
\r
95 > Group docstrings aren't generally of the form "Options concerning
\r
96 > ..."; they just jump into what they concern. E.g.,
\r
98 > Convenience : Convenience features for faster editing.
\r
100 > Calendar Hooks : Calendar hooks.
\r
103 Couldn't agree more! I must admit, I was rather apathetic at the
\r
104 time due to a lack of sleep.
\r
106 > Also, all but one of the tags you give the groups would be
\r
107 > automatically derived by Emacs, so you can remove those.
\r
110 How very convenient. Removed 'em all: the one @ `notmuch-external'
\r
111 was pretty pointless as well.
\r
113 > > +(defgroup notmuch-hello nil
\r
114 > > + "Options concerning `notmuch-hello-mode'."
\r
115 > > + :tag "Notmuch Hello"
\r
116 > > + :group 'notmuch)
\r
118 > Perhaps "Overview of saved searches, tags, etc."
\r
121 > > +(defgroup notmuch-search nil
\r
122 > > + "Options concerning `notmuch-search-mode'."
\r
123 > > + :tag "Notmuch Search"
\r
124 > > + :group 'notmuch)
\r
126 > "Searching and sorting mail"?
\r
129 > > +(defgroup notmuch-show nil
\r
130 > > + "Options concerning `notmuch-show-mode'."
\r
131 > > + :tag "Notmuch Show"
\r
132 > > + :group 'notmuch)
\r
134 > "Showing messages and threads"?
\r
137 > > +(defgroup notmuch-send nil
\r
138 > > + "Options concerning the sending of messages."
\r
139 > > + :tag "Notmuch Send"
\r
140 > > + :group 'notmuch)
\r
142 > "Sending messages from Notmuch"?
\r
144 > We should probably link to the 'message group, perhaps by adding
\r
145 > :link '(custom-group-link message)
\r
146 > here or maybe to the notmuch group itself. Unfortunately, I don't
\r
147 > think you can actually add a group to another group after it's been
\r
148 > defined (though I could be wrong).
\r
151 Agreed. I've added `notmuch-send' to the `message' group.
\r
154 > > +(defgroup notmuch-crypto nil
\r
155 > > + "Options concerning the processing and fontification of
\r
156 > > +cryptographic MIME parts in `notmuch-show-mode'."
\r
157 > > + :tag "Notmuch Crypto"
\r
158 > > + :group 'notmuch)
\r
160 > "Processing and display of cryptographic MIME parts"? (You also don't
\r
161 > want the docstring to be too long, given how it's displayed.)
\r
164 > > +(defgroup notmuch-hooks nil
\r
165 > > + "Run custom code on well-defined occasions."
\r
166 > > + :tag "Notmuch Hooks"
\r
167 > > + :group 'notmuch)
\r
169 > > +(defgroup notmuch-external nil
\r
170 > > + "Run more custom code on different well-defined occasions."
\r
171 > > + :tag "Notmuch External Commands"
\r
172 > > + :group 'notmuch)
\r
174 > Oof! It's okay to be a little redundant in the docstring. Core Emacs
\r
175 > options do it. "External commands"?
\r
178 > > +(defgroup notmuch-appearance nil
\r
179 > > + "Options concerning how Notmuch looks."
\r
180 > > + :tag "Notmuch Appearance"
\r
181 > > + :group 'notmuch)
\r
183 > "How Notmuch looks"?
\r
185 > I worry that notmuch-appearance is a catch-all that most options
\r
186 > arguably fit in to. In particular, some notmuch-show options are also
\r
187 > in this group and some aren't and it's not clear to me what the rule
\r
190 > Perhaps this should be notmuch-faces and limited to just faces (and
\r
191 > maybe options that aren't technically faces but that affect face
\r
192 > selection)? Then the grouping rule would be obvious, like it is for
\r
193 > all of the other groups.
\r
195 That was my original intention, but due to `notmuch-hello-logo-background',
\r
196 I decided to dump `notmuch-show-logo' in there as well, necessitating a
\r
197 broader designation. Fixed!
\r
projects / notmuch-archives.git / blob