1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 27A1B431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 00:28:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YUuSoaUIox+N for <notmuch@notmuchmail.org>;
\r
16 Sat, 4 Feb 2012 00:28:25 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 721F9431FAE
\r
19 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 00:28:25 -0800 (PST)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 8464A68055; Sat, 4 Feb 2012 10:28:23 +0200 (EET)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for
\r
25 test_expect_equal_file
\r
26 In-Reply-To: <87sjishv3e.fsf@gmail.com>
\r
27 References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
28 <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
29 <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com>
\r
30 User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 04 Feb 2012 10:28:23 +0200
\r
36 Message-ID: <m24nv7t32w.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 04 Feb 2012 08:28:26 -0000
\r
53 On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
54 > On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
55 > > Hey, Dmitry. I'm so sorry I sent my last email on your original patch
\r
56 > > before I saw this new series. I do now like your original proposal
\r
57 > > better, since it shows the diff based the names the caller provides,
\r
58 > > which I now agree is probably the clearest and most robust solution.
\r
59 > > The second patch in this series could still go through, though, no
\r
60 > > matter what version of the change to test_expect_equal_file we go with.
\r
63 > Actually, we can do both: check file name for consistent diff order
\r
64 > (from expected to actual) and use file names that the caller provides.
\r
66 > What do you think?
\r