1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 50926431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 15 Mar 2012 20:34:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5Ssw3vKYHlUj for <notmuch@notmuchmail.org>;
\r
16 Thu, 15 Mar 2012 20:33:59 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id CCA8B431FAE
\r
20 for <notmuch@notmuchmail.org>; Thu, 15 Mar 2012 20:33:59 -0700 (PDT)
\r
21 X-AuditID: 1209190f-b7f8a6d000000914-f4-4f62b4a53406
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 52.98.02324.5A4B26F4; Thu, 15 Mar 2012 23:33:57 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2G3XvRJ006500;
\r
27 Thu, 15 Mar 2012 23:33:57 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2G3XumX029383
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Thu, 15 Mar 2012 23:33:56 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1S8NvQ-0002FS-1x; Thu, 15 Mar 2012 23:33:56 -0400
\r
37 Date: Thu, 15 Mar 2012 23:33:56 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [Patch v2 0/3] Add test and fix exclude bug
\r
41 Message-ID: <20120316033356.GE2670@mit.edu>
\r
42 References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Content-Disposition: inline
\r
46 In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>
\r
47 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
48 X-Brightmail-Tracker:
\r
49 H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0V26Jcnf4PZSE4vVc3ksrt+cyezA
\r
50 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZXTsmMFScIGjomXTH/YGxh9sXYycHBICJhLn
\r
51 n95mh7DFJC7cWw8U5+IQEtjHKPFl+20oZwOjxJQZE5khnJNMEiuv3oXKLGGU2D21iwmkn0VA
\r
52 VeLurw5GEJtNQENi2/7lYLaIgI7E7UMLwHYwC0hLfPvdDFYvLGAhsfP3QbAaXgFtiSUtJ5hB
\r
53 bCEBT4k/D6axQsQFJU7OfMIC0aslcePfS6BeDrA5y/9xgIQ5BbwkHjSuAysXFVCRmHJyG9sE
\r
54 RqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6JXm5miV5qSukmRlBYc0ry
\r
55 72D8dlDpEKMAB6MSD+9K/iR/IdbEsuLK3EOMkhxMSqK8RsuAQnxJ+SmVGYnFGfFFpTmpxYcY
\r
56 JTiYlUR4MwwS/YV4UxIrq1KL8mFS0hwsSuK8alrv/IQE0hNLUrNTUwtSi2CyMhwcShK8YsD4
\r
57 FRIsSk1PrUjLzClBSDNxcIIM5wEa/mozUA1vcUFibnFmOkT+FKMuR/fUR5cYhVjy8vNSpcR5
\r
58 34AUCYAUZZTmwc2BpaNXjOJAbwnz/gKp4gGmMrhJr4CWMAEtKfkWB7KkJBEhJdXAGLRKrHS/
\r
59 82YtVa7UfOU1H7xcH74U+LslT9Tq4DVtE2/OvYei3sYbpe/5ZHf5+0PPnUI7C7hZ+pfc5In4
\r
60 bxq3J2WJvpVAtfTL9EuC3d9Pr2j36dhZMKF8NYPbulWnpA9U5xWt/bPxATfT3rlvPXKmlO2t
\r
61 e23xZerBA9MPJe2s7v+zcmr43QSfK0osxRmJhlrMRcWJADUmDqwiAwAA
\r
62 Cc: notmuch@notmuchmail.org
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Fri, 16 Mar 2012 03:34:00 -0000
\r
77 Quoth Mark Walters on Mar 14 at 12:26 pm:
\r
78 > The test in the previous patches
\r
79 > id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com"
\r
80 > triggered the bug accidentally. It accidentally set the exclude tags
\r
81 > to be "=" and "deleted" rather than just "deleted". The non-existent
\r
82 > "=" tag (i.e., the tag that does not occur anywhere in the Xapian
\r
83 > database) triggered the bug. First we correct the tests to just set
\r
84 > the "deleted" tag, then we add some tests including one with a
\r
85 > deliberately non-existent tag. Finally, we modify the exclusion code
\r
88 > The modification also appears to fix a similar problem for jrollins
\r
89 > that I have not yet been able to reproduce.
\r
91 > Since the code is now more clearly correct, cleaner and we do
\r
92 > definitely avoid a Xapian bug I think these patches can be committed
\r
93 > even without knowing why it fixed jrollins' bug.
\r
95 > Finally these apply to current master (not to the --with-excluded series).
\r
97 LGTM. It would be nice to have the broken tests marked broken in the
\r
98 patch that introduces them, but it's fine.
\r