1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 879B7431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 22:59:15 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id nfHpUGjw5x+r for <notmuch@notmuchmail.org>;
\r
16 Thu, 15 Nov 2012 22:59:14 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 02D02431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 22:59:13 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id D524A1000E2;
\r
22 Fri, 16 Nov 2012 08:59:11 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Blake Jones <blakej@foo.net>
\r
25 Subject: Re: [PATCH v3 00/10] Solaris support
\r
26 In-Reply-To: <15993.1353004975@foo.net>
\r
27 References: <15993.1353004975@foo.net>
\r
28 User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Fri, 16 Nov 2012 08:59:11 +0200
\r
34 Message-ID: <m24nkqm3sw.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 Cc: notmuch@notmuchmail.org
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Fri, 16 Nov 2012 06:59:15 -0000
\r
52 On Thu, Nov 15 2012, Blake Jones <blakej@foo.net> wrote:
\r
54 >> $ gcc compat/have_strsep.c
\r
55 >> compat/have_strsep.c: In function "main":
\r
56 >> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const"
\r
57 >> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function)
\r
58 >> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in
\r
59 >> zsh: exit 1 gcc compat/have_strsep.c
\r
61 >> --- It is very easy to spot the problem ;)
\r
63 > Sigh, yes it is. I started my Solaris port using some patches from
\r
64 > someone else who had done previous work on a Solaris port, and obviously
\r
65 > I didn't look at the patch very closely. In fact, after fixing
\r
66 > have_strsep.c, I saw that I didn't even need it -- Solaris 11 has
\r
67 > strsep() in libc. But I'd prefer to clean up this patch and leave the
\r
68 > compat version available for those compiling on older versions of
\r
69 > Solaris, if that's okay.
\r
71 It sure is okay -- the missing strsep() issue has been there before.
\r
73 >> $ gcc compat/check_asctime.c
\r
74 >> compat/check_asctime.c: In function "main":
\r
75 >> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r"
\r
76 >> In file included from compat/check_asctime.c:8:0:
\r
77 >> /usr/include/time.h:266:14: note: declared here
\r
78 >> zsh: exit 1 gcc compat/check_asctime.c
\r
80 >> --- the posix-semantics way uses the 2-arg format.
\r
82 >> The logic of the test setting in this file doesn't open to
\r
83 >> me. Why not test the same way as in getpwuid_r() case ?
\r
85 > Yeah, that's clearly the right thing to do. I was getting odd behavior
\r
86 > when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks
\r
87 > like I fixed it in the wrong direction.
\r
89 > Did you happen to notice any other issues besides these two? I'd rather
\r
90 > not spam the list with my ten-patch set if there's other silly stuff
\r
91 > that needs cleaning up.
\r
93 Nope, just those 2 :)
\r
96 > Thanks again for testing this.
\r