1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 461BC431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 30 Oct 2012 07:44:39 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2jLZSfkXpgXJ for <notmuch@notmuchmail.org>;
\r
16 Tue, 30 Oct 2012 07:44:38 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 56EE7431FAF
\r
19 for <notmuch@notmuchmail.org>; Tue, 30 Oct 2012 07:44:38 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 2AB5E10007D;
\r
22 Tue, 30 Oct 2012 16:44:38 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] contrib: notmuch-pick: add tests
\r
26 In-Reply-To: <1351499856-14136-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1351499856-14136-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Tue, 30 Oct 2012 16:44:37 +0200
\r
34 Message-ID: <m2ip9srpd6.fsf@guru.guru-group.fi>
\r
36 Content-Type: multipart/mixed; boundary="=-=-="
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Tue, 30 Oct 2012 14:44:39 -0000
\r
52 Content-Type: text/plain
\r
54 On Mon, Oct 29 2012, Mark Walters wrote:
\r
56 > The test should be run using the wrapper test-wrapper.sh. This links
\r
57 > the tests into the normal notmuch TEST_DIRECTORY and runs them from
\r
58 > there. After the test is complete then the links are removed.
\r
61 Looks pretty good. The emacs-pick has leading spaces and tabs mixed;
\r
62 you could run whitespace-cleanup on it.
\r
64 I got a bit irritated to your test-wrapper.sh so I experimented what
\r
65 could be done to make it a bit more robust. Look at the attachment
\r
66 for suggestions (i.e. use and reformat parts of it freely).
\r
72 Content-Type: application/x-sh
\r
73 Content-Disposition: inline; filename=test-wrapper.sh
\r
74 Content-Transfer-Encoding: base64
\r
75 Content-Description: notmuch pick contrib test wrapper suggestions
\r
77 IyEvYmluL3NoCgpzZXQgLWV1CgpmYWlsKCkgewoJZWNobyBFUlJPUiAkMQoJZXhpdCAxCn0KClRF
\r
78 U1RGSUxFUz0nZW1hY3MtcGljayBwaWNrLmV4cGVjdGVkLW91dHB1dCcKClBJQ0tfRElSPWBjZCBc
\r
79 YGRpcm5hbWUgIiQwIlxgICYmIHB3ZGAKCmZvciBmIGluICRURVNURklMRVMKZG8KCXRlc3QgLWYg
\r
80 IiRQSUNLX0RJUi8kZiIgfHwgZmFpbCAiJFBJQ0tfRElSLyRmIGRvZXMgbm90IGV4aXN0Igpkb25l
\r
81 CgpjZCAiJFBJQ0tfRElSLy4uLy4uL3Rlc3QiCgp0ZXN0IC14IC4uL25vdG11Y2ggfHwgZmFpbCAi
\r
82 YGNkIC4uICYmIHB3ZGAvbm90bXVjaCBoYXMgbm90IGJlZW4gYnVpbHQiCgpmb3IgZiBpbiAkVEVT
\r
83 VEZJTEVTCmRvCglpZiB0ZXN0IC1mICIkZiIKCXRoZW4KCQlmYWlsICIkZiBleGlzdHMiCglmaQpk
\r
84 b25lCgp0cmFwICJybSAtZiAkVEVTVEZJTEVTIiAwCgpmb3IgZiBpbiAkVEVTVEZJTEVTCmRvCgls
\r
85 biAtcyAiJFBJQ0tfRElSLyRmIiAuCmRvbmUKCiNkb24ndCBleGVjIC0tIHRyYXBzIHdvdWxkIG5v
\r
86 dCBydW4uCi4vZW1hY3MtcGljawo=
\r
88 Content-Type: text/plain
\r
93 > Here are some tests for notmuch-pick. I would have liked to include
\r
94 > the test structure and run them from inside the pick contrib directory
\r
95 > but I couldn't get all the paths to work.
\r
97 > Hence, this slightly hacky solution of linking the relevant stuff (one
\r
98 > test script and one expected output directory) into the normal notmuch
\r
99 > test directory and running from there.
\r
105 > contrib/notmuch-pick/README | 5 +
\r
106 > contrib/notmuch-pick/test-wrapper.sh | 16 +++
\r
107 > contrib/notmuch-pick/test/emacs-pick | 104 ++++++++++++++++++++
\r
108 > .../notmuch-pick-single-thread | 6 +
\r
109 > .../pick.expected-output/notmuch-pick-tag-inbox | 53 ++++++++++
\r
110 > 5 files changed, 184 insertions(+), 0 deletions(-)
\r
111 > create mode 100755 contrib/notmuch-pick/test-wrapper.sh
\r
112 > create mode 100755 contrib/notmuch-pick/test/emacs-pick
\r
113 > create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-single-thread
\r
114 > create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox
\r