1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 517B4431FC2
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:17:03 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id aFFTMqPlxuWk for <notmuch@notmuchmail.org>;
\r
18 Tue, 13 May 2014 05:16:55 -0700 (PDT)
\r
19 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
\r
20 [209.85.212.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 70E4C431FBD
\r
23 for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:16:55 -0700 (PDT)
\r
24 Received: by mail-wi0-f173.google.com with SMTP id bs8so6115019wib.12
\r
25 for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:16:54 -0700 (PDT)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
28 :mime-version:content-type;
\r
29 bh=agOutuO4LEkd8vEQLt8lrsuTWDuHdqohJo1M5eQaeKA=;
\r
30 b=LhbcRADP9FrpacrlCtoCx+8SSxChVWKR09qH/Fn9EFK3P5SlnV8vMelK9GE5a0qinc
\r
31 LMFBVXFftFaY4K6vCPQ5cXDtut2kYlG2gPZ8En4mQkJrr44LZ6N1a0wM/mFV78TGyBqc
\r
32 b6d1W90UZWG92s5OPoTjn4HEq9AzErpf0jT2aEmlpt2MJRKrMsPu/s+Km4qDfNBV7AxR
\r
33 T4D6fAfBY0GgjPHdVhh1e667KlaV7mZKo+6rfXdmvlAUkWCqoI812frd5nKFrLZ6yPHC
\r
34 Oe1Yg7Ag8CDxviJZQLVAWMlpo5hRGqn0/fz6uV3AqmyI8CsKuDKjOycuudkshutry6yl
\r
36 X-Received: by 10.194.88.230 with SMTP id bj6mr604618wjb.85.1399983414082;
\r
37 Tue, 13 May 2014 05:16:54 -0700 (PDT)
\r
38 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
39 by mx.google.com with ESMTPSA id
\r
40 pj5sm21624701wic.20.2014.05.13.05.16.53 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
42 Tue, 13 May 2014 05:16:53 -0700 (PDT)
\r
43 From: Mark Walters <markwalters1009@gmail.com>
\r
44 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
45 Subject: Re: [PATCH v3 7/9] test: Update the test output to accord with the
\r
47 In-Reply-To: <1399897769-26809-8-git-send-email-dme@dme.org>
\r
48 References: <87sixdujkv.fsf@qmul.ac.uk>
\r
49 <1399897769-26809-1-git-send-email-dme@dme.org>
\r
50 <1399897769-26809-8-git-send-email-dme@dme.org>
\r
51 User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Tue, 13 May 2014 13:16:52 +0100
\r
54 Message-ID: <87vbt9j2kr.fsf@qmul.ac.uk>
\r
56 Content-Type: text/plain; charset=us-ascii
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Tue, 13 May 2014 12:17:04 -0000
\r
71 On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:
\r
72 > Replying to a message with multiple parts will now typically include
\r
73 > content from several parts (whereas previously only the first part was
\r
74 > used). Update the expected output from the emacs reply tests
\r
77 I will reply here rather than to id:cunr43y56wy.fsf@hotblack-desiato.hh.sledj.net
\r
79 My point was that the change in this test is not because we are now
\r
80 looking beyond the first part. It is because a part with content-type
\r
81 application/octet-stream (which we didn't include in replies in the old
\r
82 scheme, and wouldn't generally in the new scheme) is redesignated by
\r
83 notmuch-show as a content-type text/x-diff, and thus displayed in the
\r
84 buffer. Hence the new code includes it in the reply.
\r
86 You can see this more clearly in patch 9/9 when this part gets a header button
\r
88 +> [ 0001-Deal-with-situation-where-sysconf-_SC_GETPW_R_SIZE_M.patch: application/octet-stream (as text/x-diff) ]
\r
90 Anyway, my point is that this is a *good* thing: the change is not a
\r
91 large intrusive thing of showing lots more parts (as this commit message
\r
92 sort of suggests) but a small change of it now correctly including a
\r
93 part which got sent with the wrong content-type.
\r
102 > test/T310-emacs.sh | 32 ++++++++++++++++++++++++++++++++
\r
103 > 1 file changed, 32 insertions(+)
\r
105 > diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
\r
106 > index ac966e5..95bb67e 100755
\r
107 > --- a/test/T310-emacs.sh
\r
108 > +++ b/test/T310-emacs.sh
\r
109 > @@ -473,6 +473,38 @@ Alex Botero-Lowry <alex.boterolowry@gmail.com> writes:
\r
110 > > and http://mail-index.netbsd.org/pkgsrc-bugs/2006/06/07/msg016808.htmlspecifically
\r
113 > +> From e3bc4bbd7b9d0d086816ab5f8f2d6ffea1dd3ea4 Mon Sep 17 00:00:00 2001
\r
114 > +> From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
\r
115 > +> Date: Tue, 17 Nov 2009 11:30:39 -0800
\r
116 > +> Subject: [PATCH] Deal with situation where sysconf(_SC_GETPW_R_SIZE_MAX) returns -1
\r
119 > +> notmuch-config.c | 2 ++
\r
120 > +> 1 files changed, 2 insertions(+), 0 deletions(-)
\r
122 > +> diff --git a/notmuch-config.c b/notmuch-config.c
\r
123 > +> index 248149c..e7220d8 100644
\r
124 > +> --- a/notmuch-config.c
\r
125 > +> +++ b/notmuch-config.c
\r
126 > +> @@ -77,6 +77,7 @@ static char *
\r
127 > +> get_name_from_passwd_file (void *ctx)
\r
129 > +> long pw_buf_size = sysconf(_SC_GETPW_R_SIZE_MAX);
\r
130 > +> + if (pw_buf_size == -1) pw_buf_size = 64;
\r
131 > +> char *pw_buf = talloc_zero_size (ctx, pw_buf_size);
\r
132 > +> struct passwd passwd, *ignored;
\r
134 > +> @@ -101,6 +102,7 @@ static char *
\r
135 > +> get_username_from_passwd_file (void *ctx)
\r
137 > +> long pw_buf_size = sysconf(_SC_GETPW_R_SIZE_MAX);
\r
138 > +> + if (pw_buf_size == -1) pw_buf_size = 64;
\r
139 > +> char *pw_buf = talloc_zero_size (ctx, pw_buf_size);
\r
140 > +> struct passwd passwd, *ignored;
\r
145 > > _______________________________________________
\r
146 > > notmuch mailing list
\r
147 > > notmuch@notmuchmail.org
\r
151 > _______________________________________________
\r
152 > notmuch mailing list
\r
153 > notmuch@notmuchmail.org
\r
154 > http://notmuchmail.org/mailman/listinfo/notmuch
\r