1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1BC19431FD0
\r
6 for <notmuch@notmuchmail.org>; Mon, 11 Jul 2011 09:32:53 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ecW-ZK5Si7tt for <notmuch@notmuchmail.org>;
\r
16 Mon, 11 Jul 2011 09:32:51 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 5AE27431FB6
\r
20 for <notmuch@notmuchmail.org>; Mon, 11 Jul 2011 09:32:51 -0700 (PDT)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 35B0966E0149;
\r
23 Mon, 11 Jul 2011 09:32:49 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from servo.finestructure.net (cpe-98-149-172-122.socal.res.rr.com
\r
26 [98.149.172.122]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 2446366E0348;
\r
28 Mon, 11 Jul 2011 09:32:46 -0700 (PDT)
\r
29 Received: by servo.finestructure.net (Postfix, from userid 1000)
\r
30 id BD8A2244; Mon, 11 Jul 2011 09:32:47 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Felix Geller <fgeller@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] Emacs: Add variable to toggle message indentation in a
\r
35 In-Reply-To: <m2r55xi4yr.fsf@gmail.com>
\r
36 References: <m2r55xi4yr.fsf@gmail.com>
\r
37 User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Mon, 11 Jul 2011 09:32:45 -0700
\r
40 Message-ID: <87aackwzf6.fsf@servo.factory.finestructure.net>
\r
42 Content-Type: multipart/signed; boundary="=-=-=";
\r
43 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 11 Jul 2011 16:32:53 -0000
\r
60 On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
\r
61 > I added a variable to toggle message indentation in Emacs.
\r
63 Hi, Felix. Thanks for submitting this patch. I think it's a good idea.
\r
64 I have a couple of comments below, a couple of which echo what Dmitry
\r
65 has already pointed out.
\r
67 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
69 This patch doesn't include a commit log, which is something we generally
\r
70 require. The preferred way to send patches is with git format-patch or
\r
71 send-email, both of which format patches in such a way that they can be
\r
72 immediately applied to a git repo, including with the commit log.
\r
74 > +(defcustom notmuch-show-indent-messages-in-thread nil
\r
75 > + "Should the messages in a thread be indented according to their respective depth in the thread?"
\r
79 I agres with Dmitry that this should default to 't', to be consistent
\r
80 with the current default behavior.
\r
82 > - (insert (notmuch-show-spaces-n depth)
\r
83 > + (insert (if notmuch-show-indent-messages-in-thread
\r
84 > + (notmuch-show-spaces-n depth)
\r
87 I also agree with Dmitry's suggestion here to use the following slightly
\r
90 (if notmuch-show-indent-messages-in-thread
\r
91 (insert (notmuch-show-spaces-n depth)))
\r
93 Finally, as Dmitry also points out, you'll almost certainly need to
\r
94 construct a test for this feature, since it constitutes a pretty big
\r
95 formatting change. It should probably test for both cases of the
\r
96 customization variable. Check out the tests in tests/emacs for
\r
104 Content-Type: application/pgp-signature
\r
106 -----BEGIN PGP SIGNATURE-----
\r
107 Version: GnuPG v1.4.11 (GNU/Linux)
\r
109 iQIcBAEBCAAGBQJOGyWtAAoJEO00zqvie6q8oWgP/0EThDHhwlBdBeDQSY2jzILY
\r
110 GKUXROMAv20qQFjgzho3rDznz09OpVKPPTbpZuqbF3PuLMhwwDCWbOYEddZm+3ph
\r
111 r3P+L7Xi6esx2TrUrTL7pgrGYGlMX3xrLZLjc2E7a+GY9UO1NODliiXCff93G311
\r
112 1kzDZhPV6s8MjvvsIvD9aH4bbjV3iz+7fkMMcZV1qHXUQskik/TLETUKuJx1bmRz
\r
113 fMrX7fssALCpCNIZFgPdkrhOvU4DUes5AjukWWompE6AwRSdDE9WV5O5P8xSWCb4
\r
114 M4Ptgo8kMEj2IHNvcf1MJtvZgybt2+oX82CxFLQnBvVGj3H/HqXK+ZrTMW8UlwTu
\r
115 5Q2LYELNSv1CilNXye43f/b93dlYLmUwM9RO11i1Gd1e97Nu2Taz7SDD3/M/NAx4
\r
116 +IcumUgDSvx/u+4QDggE9th0ftQ1+KLaoCjukEbl1VYzn6orisJ4GamnmveuRpjK
\r
117 B4uV9KheIVbRABN/ExxiTRQLp0aHEsNIdeHTQu2p8E+APiyqey3NkDJeKoRk6xqy
\r
118 MCEpDy1ReRu74BkfBjAe0UNyvJZmhDk4ni/vGJ/r5Mt8cMYd6iMQpRp4EgguBCdg
\r
119 SpP7HamxSkMpn/WToIv0/o5EVOoRIL10J6WK1Q+ZGTK0tsCgqZqgrCro8eWeJEfs
\r
120 ujSVxTYHWHmzvd+tcJRe
\r
122 -----END PGP SIGNATURE-----
\r