1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DEBE2429E26
\r
6 for <notmuch@notmuchmail.org>; Fri, 16 Dec 2011 04:32:04 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id x63Ow2fpYrqK for <notmuch@notmuchmail.org>;
\r
17 Fri, 16 Dec 2011 04:32:04 -0800 (PST)
\r
18 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
19 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
20 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
21 2D8B9431FD0 for <notmuch@notmuchmail.org>; Fri, 16 Dec 2011 04:32:04 -0800
\r
23 Received: by wgbds13 with SMTP id ds13so4869443wgb.2
\r
24 for <notmuch@notmuchmail.org>; Fri, 16 Dec 2011 04:32:03 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=/xNTS0sUlrSZtCZ9aDZcPCJrT8Vw3B+NqlacBn1Z7nU=;
\r
29 b=PIexlDeAZzupHiznaGO6X5F8l8VY7z7nW15DjC2UJWaqQFgFfmiOuNytfpwfy7q4rf
\r
30 rE8tL2HMrmYr583ysqObZRusSb4qR+0M/7YD1Xihl8Wu6SGO8GKX8j5qCtiHW59nJhyd
\r
31 c3oT7nOMalA3FYuLdjAX74j9UNH9oWA9lVO0A=
\r
32 Received: by 10.180.107.97 with SMTP id hb1mr12111802wib.18.1324038722954;
\r
33 Fri, 16 Dec 2011 04:32:02 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id b5sm14376217wbh.4.2011.12.16.04.32.01
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Fri, 16 Dec 2011 04:32:02 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom
\r
42 <4f5151bf4b16ca977c6cfe7e4bf2bf909281675b.1316804530.git.jani@nikula.org>
\r
44 <864e58d004c991bcb823e0f61f33eb8cbbbb5b76.1316804530.git.jani@nikula.org>
\r
45 <4f5151bf4b16ca977c6cfe7e4bf2bf909281675b.1316804530.git.jani@nikula.org>
\r
46 User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Fri, 16 Dec 2011 16:31:22 +0400
\r
49 Message-ID: <87iplgsnol.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Fri, 16 Dec 2011 12:32:05 -0000
\r
66 On Fri, 23 Sep 2011 22:03:42 +0300, Jani Nikula <jani@nikula.org> wrote:
\r
67 > The :options keyword is not meaningful for function type. Also, it was not
\r
68 > possible to enter nil value, contrary to the notmuch-mua-user-agent
\r
69 > defcustom documentation. Specify the alternatives using choice type, taking
\r
73 I know little about the customize interface. But the patch makes sense
\r
76 Perhaps I would give mode detailed description for the options, but
\r
77 before the change there was none at all, so this is definitely an
\r
83 > Signed-off-by: Jani Nikula <jani@nikula.org>
\r
85 > emacs/notmuch-mua.el | 10 ++++++----
\r
86 > 1 files changed, 6 insertions(+), 4 deletions(-)
\r
88 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
89 > index 8824b08..8b95bd4 100644
\r
90 > --- a/emacs/notmuch-mua.el
\r
91 > +++ b/emacs/notmuch-mua.el
\r
92 > @@ -35,10 +35,12 @@
\r
93 > "Function used to generate a `User-Agent:' string. If this is
\r
94 > `nil' then no `User-Agent:' will be generated."
\r
97 > - :options '(notmuch-mua-user-agent-full
\r
98 > - notmuch-mua-user-agent-notmuch
\r
99 > - notmuch-mua-user-agent-emacs))
\r
100 > + :type '(choice (const :tag "No user agent string" nil)
\r
101 > + (const :tag "Full" notmuch-mua-user-agent-full)
\r
102 > + (const :tag "Notmuch" notmuch-mua-user-agent-notmuch)
\r
103 > + (const :tag "Emacs" notmuch-mua-user-agent-emacs)
\r
104 > + (function :tag "Custom user agent function"
\r
105 > + :value notmuch-mua-user-agent-full)))
\r
107 > (defcustom notmuch-mua-hidden-headers '("^User-Agent:")
\r
108 > "Headers that are added to the `message-mode' hidden headers
\r
112 > _______________________________________________
\r
113 > notmuch mailing list
\r
114 > notmuch@notmuchmail.org
\r
115 > http://notmuchmail.org/mailman/listinfo/notmuch
\r