1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EF969431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 28 Dec 2011 12:35:31 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RGVGwd8WxO98 for <notmuch@notmuchmail.org>;
\r
16 Wed, 28 Dec 2011 12:35:31 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 14ED0431FB6
\r
20 for <notmuch@notmuchmail.org>; Wed, 28 Dec 2011 12:35:31 -0800 (PST)
\r
21 X-AuditID: 12074425-b7f4a6d0000008e0-e6-4efb7d92312a
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 74.A6.02272.29D7BFE4; Wed, 28 Dec 2011 15:35:30 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pBSKZTFw017121;
\r
27 Wed, 28 Dec 2011 15:35:30 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBSKZSWX013232
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Wed, 28 Dec 2011 15:35:29 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1Rg0ER-0002uO-QD; Wed, 28 Dec 2011 15:36:15 -0500
\r
37 Date: Wed, 28 Dec 2011 15:36:15 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>
\r
40 Subject: Re: [PATCH v2] Ignore encrypted parts when indexing.
\r
41 Message-ID: <20111228203615.GE30150@mit.edu>
\r
42 References: <1325005901-21374-1-git-send-email-jrollins@finestructure.net>
\r
43 <1325103269-14599-1-git-send-email-jrollins@finestructure.net>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <1325103269-14599-1-git-send-email-jrollins@finestructure.net>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT151U+9vP4MEjRYs9+7wsrt+cyezA
\r
51 5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyNkz4yF6whKPizEW/BsZNbF2MnBwSAiYS/W2r
\r
52 GSFsMYkL99aDxYUE9jFKfH5Z2sXIBWRvYJT4/XgHG4Rzkkmi5eRVKGcJo0TruV6mLkYODhYB
\r
53 VYlvf4NButkENCS27V8ONlVEwEyi58sfMJtZQEti68YPYLawgK3EgfUtTCA2r4COxLe9j1kh
\r
54 ZnYzSuzbu4EdIiEocXLmExaY5hv/XoLtYhaQllj+jwMkzCngLdH/fS/Y1aICKhJTTm5jm8Ao
\r
55 NAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3StdDLzSzRS00p3cQIDmgX1R2M
\r
56 Ew4pHWIU4GBU4uH1NPztJ8SaWFZcmXuIUZKDSUmU9145UIgvKT+lMiOxOCO+qDQntfgQowQH
\r
57 s5II74JKoBxvSmJlVWpRPkxKmoNFSZxXU+udn5BAemJJanZqakFqEUxWhoNDSYL3Sg1Qo2BR
\r
58 anpqRVpmTglCmomDE2Q4D9DwzSA1vMUFibnFmekQ+VOMilLivKdBEgIgiYzSPLheWMJ5xSgO
\r
59 9Iow73aQKh5gsoLrfgU0mAlo8Llzv0AGlyQipKQaGCvKp+0NfRW/g5FVfZFg3IroM6c4zQo3
\r
60 y7WqixT5/Lq+PVC21PuGTkcWh+Ksz2Yzf8+v3+jVV9Jm1tSnv3d6WmzWNs0Lyy1n/fvS9Da8
\r
61 4UdeTaR1RPS5/EA/kdWlMZ1zff5YiG/628l94lHva7G9M7RKr15uus5y4OlRw0jlyE/isWJs
\r
62 gSxblViKMxINtZiLihMBCOVskxMDAAA=
\r
63 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Wed, 28 Dec 2011 20:35:32 -0000
\r
80 Quoth Jameson Graef Rollins on Dec 28 at 12:14 pm:
\r
81 > It appears to be an oversight that encrypted parts were indexed
\r
82 > previously. The terms generated from encrypted parts are meaningless
\r
83 > and do nothing but add bloat to the database. It is not worth
\r
84 > indexing the encrypted content, just as it's not worth indexing the
\r
85 > signatures in signed parts.
\r
87 > Fixes missing colon. Thanks Austin, Xavier.
\r
89 > lib/index.cc | 4 ++++
\r
90 > 1 files changed, 4 insertions(+), 0 deletions(-)
\r
92 > diff --git a/lib/index.cc b/lib/index.cc
\r
93 > index e8e9922..d8f8b2b 100644
\r
94 > --- a/lib/index.cc
\r
95 > +++ b/lib/index.cc
\r
96 > @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
\r
98 > fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
\r
100 > + if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
\r
101 > + /* Don't index encrypted parts. */
\r
104 > _index_mime_part (message,
\r
105 > g_mime_multipart_get_part (multipart, i));
\r