1 Return-Path: <stewart@flamingspork.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4B67F431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 15 Feb 2010 00:13:37 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.688 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.689, BAYES_50=0.001] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ti8uNfJDBVd7 for <notmuch@notmuchmail.org>;
\r
16 Mon, 15 Feb 2010 00:13:36 -0800 (PST)
\r
17 Received: from kaylee.flamingspork.com (kaylee.flamingspork.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id 8F9E3431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 15 Feb 2010 00:13:36 -0800 (PST)
\r
21 Received: from willster (localhost [127.0.0.1])
\r
22 by kaylee.flamingspork.com (Postfix) with ESMTPS id ADA646393;
\r
23 Mon, 15 Feb 2010 08:10:36 +0000 (UTC)
\r
24 Received: from flamingspork.com (localhost.localdomain [127.0.0.1])
\r
25 by willster (Postfix) with ESMTPS id 8569E1023DAE;
\r
26 Mon, 15 Feb 2010 19:13:33 +1100 (EST)
\r
27 Date: Mon, 15 Feb 2010 19:13:31 +1100
\r
28 From: Stewart Smith <stewart@flamingspork.com>
\r
29 To: Tim Stoakes <notmuch@stoakes.net>
\r
30 Message-ID: <20100215081331.GD22402@flamingspork.com>
\r
31 References: <87y6lz39nd.fsf@yoom.home.cworth.org>
\r
32 <20091121221207.GB17268@jukie.net>
\r
33 <9cce5525b093b87fe74d427954ffad89@localhost>
\r
34 <87d43b2oif.fsf@yoom.home.cworth.org>
\r
35 <9bfdedddeab9c58cd45d8d448323d0fc@localhost>
\r
36 <87skc23327.fsf@yoom.home.cworth.org>
\r
37 <4b0eef22.JwxdgTGElffx149F%michiel@michielbuddingh.net>
\r
38 <87ws1bjpmm.fsf@yoom.home.cworth.org> <878wdfkhcl.fsf@aegir.org.uk>
\r
39 <20100210031339.GH16686@mail.rocksoft.com>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 Content-Disposition: inline
\r
43 In-Reply-To: <20100210031339.GH16686@mail.rocksoft.com>
\r
44 User-Agent: Mutt/1.5.20 (2009-06-14)
\r
45 Cc: notmuch@notmuchmail.org
\r
46 Subject: Re: [notmuch] [PATCH] notmuch: Respect maildir message flags
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Mon, 15 Feb 2010 08:13:37 -0000
\r
61 On Wed, Feb 10, 2010 at 01:43:39PM +1030, Tim Stoakes wrote:
\r
62 > My apologies for dredging up an old thread. I don't want to restart the
\r
63 > religious war over whether notmuch should respect Maildir flags -
\r
64 > suffice to say that *I* want that, and the patch posted by Michiel
\r
65 > seemed to be the best way to make that happen.
\r
69 I also found a bug....
\r
71 > @@ -301,6 +357,28 @@ add_files_recursive (notmuch_database_t *notmuch,
\r
75 > + /* If this directory is a Maildir folder, we need to
\r
76 > + * ignore any subdirectories marked tmp/, and scan for
\r
77 > + * Maildir attributes on messages contained in the sub-
\r
78 > + * directories 'new' and 'cur'. */
\r
79 > + if (maildir_detected != 0 &&
\r
80 > + entry->d_type == DT_DIR &&
\r
81 > + ((strcmp (entry->d_name, "tmp") == 0) ||
\r
82 > + (strcmp (entry->d_name, "new") == 0) ||
\r
83 > + (strcmp (entry->d_name, "cur") == 0))) {
\r
86 (entry->d_type == DT_DIR || entry->d_type == DT_UNKNOWN) &&
\r
88 as not everywhere is going to give you d_type (e.g. my machine).
\r
91 (took me a while to find/figure that out :)
\r