1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id F0A0C6DE14FD
\r
6 for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:47 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.955 tagged_above=-999 required=5 tests=[AWL=0.303,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id L1Wc9mhUF0pp for <notmuch@notmuchmail.org>;
\r
16 Mon, 27 Jul 2015 12:36:45 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 0952B6DE14D9
\r
19 for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:45 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 27AB8100086;
\r
22 Mon, 27 Jul 2015 22:36:24 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] build: add "set -e" to version script generation
\r
26 In-Reply-To: <1438022552-24342-1-git-send-email-david@tethera.net>
\r
27 References: <1438022552-24342-1-git-send-email-david@tethera.net>
\r
28 User-Agent: Notmuch/0.20.2+31~g967a7a3 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 27 Jul 2015 22:36:23 +0300
\r
34 Message-ID: <m2a8uh75qg.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.18
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 27 Jul 2015 19:36:48 -0000
\r
51 On Mon, Jul 27 2015, David Bremner <david@tethera.net> wrote:
\r
53 > It turns out that on certain systems like FreeBSD, c++filt is not
\r
54 > installed by default. It's basically OK if we fail the build in that
\r
55 > case, but what's really not OK is for the build to continue and
\r
56 > generate bad binaries.
\r
58 > lib/gen-version-script.sh | 1 +
\r
59 > 1 file changed, 1 insertion(+)
\r
61 > diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
\r
62 > index 64a7374..aa1ca43 100644
\r
63 > --- a/lib/gen-version-script.sh
\r
64 > +++ b/lib/gen-version-script.sh
\r
68 LGTM, although I'd prefer 'set -eu' (both visual observation and testing
\r
69 with set -eux worked for me).
\r
75 > # we go through a bit of work to get the unmangled names of the
\r
76 > # typeinfo symbols because of
\r
80 > _______________________________________________
\r
81 > notmuch mailing list
\r
82 > notmuch@notmuchmail.org
\r
83 > http://notmuchmail.org/mailman/listinfo/notmuch
\r