1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E894B431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 15:57:50 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01]
\r
13 autolearn=unavailable
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Zu00du2VH-ol for <notmuch@notmuchmail.org>;
\r
17 Fri, 3 Jun 2011 15:57:50 -0700 (PDT)
\r
18 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
20 by olra.theworths.org (Postfix) with ESMTP id A4CFB431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 15:57:50 -0700 (PDT)
\r
22 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
23 by earth-doxen-postvirus (Postfix) with ESMTP id AE5E966E0380;
\r
24 Fri, 3 Jun 2011 15:57:46 -0700 (PDT)
\r
25 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
26 Received: from servo.finestructure.net (gwave-79.ligo.caltech.edu
\r
27 [131.215.114.79]) (Authenticated sender: jrollins)
\r
28 by earth-doxen-submit (Postfix) with ESMTP id A3B1666E0398;
\r
29 Fri, 3 Jun 2011 15:57:43 -0700 (PDT)
\r
30 Received: by servo.finestructure.net (Postfix, from userid 1000)
\r
31 id C0BB5AD6; Fri, 3 Jun 2011 15:57:44 -0700 (PDT)
\r
32 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
33 To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
\r
34 Subject: Re: [PATCH 25/25] Fix stdout stream grabbing in
\r
35 format_part_content_text
\r
36 In-Reply-To: <87d3iulevu.fsf@yoom.home.cworth.org>
\r
37 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
\r
38 <1306619520-25730-2-git-send-email-jrollins@finestructure.net>
\r
39 <1306619520-25730-3-git-send-email-jrollins@finestructure.net>
\r
40 <1306619520-25730-4-git-send-email-jrollins@finestructure.net>
\r
41 <1306619520-25730-5-git-send-email-jrollins@finestructure.net>
\r
42 <1306619520-25730-6-git-send-email-jrollins@finestructure.net>
\r
43 <1306619520-25730-7-git-send-email-jrollins@finestructure.net>
\r
44 <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
\r
45 <1306619520-25730-9-git-send-email-jrollins@finestructure.net>
\r
46 <1306619520-25730-10-git-send-email-jrollins@finestructure.net>
\r
47 <1306619520-25730-11-git-send-email-jrollins@finestructure.net>
\r
48 <1306619520-25730-12-git-send-email-jrollins@finestructure.net>
\r
49 <1306619520-25730-13-git-send-email-jrollins@finestructure.net>
\r
50 <1306619520-25730-14-git-send-email-jrollins@finestructure.net>
\r
51 <1306619520-25730-15-git-send-email-jrollins@finestructure.net>
\r
52 <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net>
\r
53 <1306619520-25730-17-git-send-email-jrollins@finestructure.net>
\r
54 <1306619520-25730-18-git-send-email-jrollins@finestructure.net>
\r
55 <1306619520-25730-19-git-send-email-jrollins@finestructure.net>
\r
56 <1306619520-25730-20-git-send-email-jrollins@finestructure.net>
\r
57 <1306619520-25730-21-git-send-email-jrollins@finestructure.net>
\r
58 <1306619520-25730-22-git-send-email-jrollins@finestructure.net>
\r
59 <1306619520-25730-23-git-send-email-jrollins@finestructure.net>
\r
60 <1306619520-25730-24-git-send-email-jrollins@finestructure.net>
\r
61 <1306619520-25730-25-git-send-email-jrollins@finestructure.net>
\r
62 <1306619520-25730-26-git-send-email-jrollins@finestructure.net>
\r
63 <87r57almd9.fsf@yoom.home.cworth.org>
\r
64 <87lixihahz.fsf@servo.factory.finestructure.net>
\r
65 <87d3iulevu.fsf@yoom.home.cworth.org>
\r
66 User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1
\r
67 (x86_64-pc-linux-gnu)
\r
68 Date: Fri, 03 Jun 2011 15:57:42 -0700
\r
69 Message-ID: <87d3iuh6ah.fsf@servo.factory.finestructure.net>
\r
71 Content-Type: multipart/signed; boundary="=-=-=";
\r
72 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
73 X-BeenThere: notmuch@notmuchmail.org
\r
74 X-Mailman-Version: 2.1.13
\r
76 List-Id: "Use and development of the notmuch mail system."
\r
77 <notmuch.notmuchmail.org>
\r
78 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
79 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
80 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
81 List-Post: <mailto:notmuch@notmuchmail.org>
\r
82 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
83 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
84 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
85 X-List-Received-Date: Fri, 03 Jun 2011 22:57:51 -0000
\r
88 Content-Transfer-Encoding: quoted-printable
\r
90 On Fri, 03 Jun 2011 15:38:29 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
91 > commit d5b4d950245605b84c56ce991fa3c59a073a70e5
\r
92 > Author: Jameson Graef Rollins <jrollins@finestructure.net>
\r
93 > Date: Sat May 28 14:52:00 2011 -0700
\r
95 > show: Avoid inadvertently closing stdout
\r
97 > GMime has a nasty habit of taking ownership by default of any FILE*
\r
98 > handed to it va g_mime_stream_file_new. Specifically it will close the
\r
99 > FILE* when the stream is destroyed---even though GMime didn't open the
\r
102 > To avoid this bad behavior, we have to carefully set_owner(FALSE)
\r
103 > after calling g_mime_stream_file_new. In the format_part_content_text
\r
104 > function, since commit d92146d3a6809f8ad940302af49cd99a0820665e we've
\r
105 > been calling g_mime_stream_file_new unconditionally, but only calling
\r
106 > g_mime_stream_file_set_owner(FALSE) conditionally.
\r
108 > This led to the FILE* being closed early when notmuch show output was
\r
109 > redirected to a file.
\r
111 > Fixing this fixes the test-suite cases that broke with the previous
\r
112 > commit, (which added redirected "notmuch show" calls to the test suite
\r
113 > to expose this bug).
\r
115 > Edited-by: Carl Worth <cworth@cworth.org> with a new commit message to
\r
116 > explain the bug and fix.
\r
118 Now I sound like I know what I'm talking about! Thanks, Carl.
\r
123 Content-Type: application/pgp-signature
\r
125 -----BEGIN PGP SIGNATURE-----
\r
126 Version: GnuPG v1.4.11 (GNU/Linux)
\r
128 iQIcBAEBCAAGBQJN6WbmAAoJEO00zqvie6q8fUQP/2m/MOO0xkY1mX72gkQeB4xS
\r
129 U4niQQhIX1484t8+jCbHMtMPNwkXBA2vfxC2j2wE3tfyXfolRGDgTtJqo8SLSFx1
\r
130 3GY0Jfrvsld7kK7vXzpa2anyqae0x0R0vhZMoFtR24m7CmNIl1K938MdJkJvJK0k
\r
131 Q96EG4lT0rwMX8OgKjPewUd7o8myhq3RnxYCZ7QOMfB5zlpbVQ6A1jiFg3pQmSXE
\r
132 IT/49Ik5ijVVPHAygbT3v9lZx2+IbHMDb0IlQCbu0eAQYZvOysptD4rJqA6DuM8M
\r
133 km/jupzszfGZ3vt1UJSdno6FGFdNN9rs5i/nvQcB7D836YFCKbB+V8lBDpQzPY+c
\r
134 duBimK6FogImrfR0hhn/Cf4v53dDqAk016jF+O1SDJZDiSxkboDnCr/adIV0eK/t
\r
135 8ddlfMOLohwqxU1RrsYGnbrWJu60cwZsl5tJj38payd1Ijp9Du62yAAracTIrXn1
\r
136 4Wi0uXrnKJg1pL09UaBtEmt2+e5bDWANDWa/KFRejBNhpJXijDuTWMimOLAFvE6c
\r
137 rn35GJCT1cWEaGhEYx8vDkm6hYTX9gukWhtJ7+bcWxIepoqKEFJRU1bhiAnqV9MK
\r
138 PfqeJ2qZTKr4Vnnfd279AT0xqzzG9mFpUkHSJmumLt52tbxz4cCpaTEceOdMAc10
\r
139 sECcCwt8hC9ZW1tinHIE
\r
141 -----END PGP SIGNATURE-----
\r