Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email

[notmuch-archives.git] / 03 / ac54e272950c5045fdc1d3e7d7b99d06cea8c3

Return-Path: <tomi.ollila@iki.fi>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id 3C61D431FBF\r
        for <notmuch@notmuchmail.org>; Sun, 31 Mar 2013 02:27:54 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: 0\r
X-Spam-Level: \r
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
        autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id 7+hJ9xTYSlBy for <notmuch@notmuchmail.org>;\r
        Sun, 31 Mar 2013 02:27:52 -0700 (PDT)\r
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
        by olra.theworths.org (Postfix) with ESMTP id 5E053431FAE\r
        for <notmuch@notmuchmail.org>; Sun, 31 Mar 2013 02:27:52 -0700 (PDT)\r
Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
        by guru.guru-group.fi (Postfix) with ESMTP id 4A737100086;\r
        Sun, 31 Mar 2013 12:27:51 +0300 (EEST)\r
From: Tomi Ollila <tomi.ollila@iki.fi>\r
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
Subject: Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build\r
In-Reply-To: <m2ppyggdh0.fsf@guru.guru-group.fi>\r
References: <cover.1364651359.git.jani@nikula.org>\r
        <m2ppyggdh0.fsf@guru.guru-group.fi>\r
User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1\r
        (x86_64-unknown-linux-gnu)\r
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
        $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
        !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
Date: Sun, 31 Mar 2013 12:27:51 +0300\r
Message-ID: <m2mwtjhqaw.fsf@guru.guru-group.fi>\r
MIME-Version: 1.0\r
Content-Type: text/plain\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Sun, 31 Mar 2013 09:27:54 -0000\r
\r
On Sun, Mar 31 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
\r
> On Sat, Mar 30 2013, Jani Nikula <jani@nikula.org> wrote:\r
>\r
>> This is v2 of [1]. Added comments per David's request, and while at it,\r
>> added a third patch to conform the existing conditional build in notmuch\r
>> show to the same style. The whole series should have no functional\r
>> changes, and thus v2 should have no functional changes since v1. ;)\r
>>\r
>> I have not tested this on gmime 2.4.\r
>\r
> I have gmime 2.4(.24) on this system. The code compiles and\r
> exactly the same set of tests pass/fail as without this patch\r
> (unfortunately this system cannot cope with just some of the\r
> crypto patches, so I cannot give absolute guarantee:\r
\r
Ok, the failure cases below are just those which are changed in\r
this patch. So I had to dig further...\r
\r
... actually this\r
  'PASS   emacs delivery of encrypted message with attachment'\r
fails to deliver the message.\r
\r
After the following change:\r
\r
--- a/test/test-lib.sh\r
+++ b/test/test-lib.sh\r
@@ -442,7 +442,8 @@ emacs_deliver_message ()\r
 \r
     test_emacs \\r
        "(let ((message-send-mail-function 'message-smtpmail-send-it)\r
-              (smtpmail-smtp-server \"localhost\")\r
+              (smtpmail-smtp-server 'local)\r
+              ;;(smtpmail-smtp-server \"localhost\")\r
               (smtpmail-smtp-service \"25025\"))\r
           (notmuch-hello)\r
           (notmuch-mua-mail)\r
\r
The failured cases below PASSes.\r
\r
(I've stumbled the same problem a few cases before but haven't \r
figured out a good patch so far...)\r
\r
>\r
> crypto: Testing PGP/MIME signature verification and decryption\r
>  PASS   emacs delivery of signed message\r
>  PASS   signature verification\r
>  PASS   signature verification with full owner trust\r
>  PASS   signature verification with signer key unavailable\r
>  PASS   emacs delivery of encrypted message with attachment\r
>  FAIL   decryption, --format=text\r
>  FAIL   decryption, --format=json\r
>  FAIL   decryption, --format=json, --part=4\r
>  FAIL   decrypt attachment (--part=5 --format=raw)\r
>  FAIL   decryption failure with missing key\r
>  PASS   emacs delivery of encrypted + signed message\r
>  FAIL   decryption + signature verification\r
>  FAIL   reply to encrypted message\r
>  FAIL   signature verification with revoked key\r
>\r
> anyway, as said, exactly the same set fails without these pathes\r
>\r
> The reason for failure is most probably in my system and not something\r
> w/ notmuch crypto support -- If I run `emacs foo.org.gpg` this just\r
> hangs waiting me to give passphrase in (invisible?) curses request)\r
>\r
> So, bottom line: LGTM.\r
>\r
>> BR,\r
>> Jani.\r
>\r
> Tomi\r
>\r
>\r
>> [1] id:a9f12ba474fc51df71e2fd2b7a20a8d101729c6e.1362319765.git.jani@nikula.org\r
>>\r
>> Jani Nikula (3):\r
>>   cli: crypto: abstract gpg context creation for clarity\r
>>   cli: mime node: abstract decryption and signature verification\r
>>   cli: conform to same conditional build style as elsewhere in\r
>>     notmuch-show\r
>>\r
>>  crypto.c       |   66 ++++++++++++-----\r
>>  mime-node.c    |  218 ++++++++++++++++++++++++++++++++++++--------------------\r
>>  notmuch-show.c |   46 ++++++------\r
>>  3 files changed, 215 insertions(+), 115 deletions(-)\r
>>\r
>> -- \r
>> 1.7.10.4\r