1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E6F2A431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 26 Apr 2014 03:51:14 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.502 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id I1RDV94LB3DQ for <notmuch@notmuchmail.org>;
\r
17 Sat, 26 Apr 2014 03:51:07 -0700 (PDT)
\r
18 Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 760FE431FAF
\r
22 for <notmuch@notmuchmail.org>; Sat, 26 Apr 2014 03:51:07 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail1.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1We0CC-0006JS-OO; Sat, 26 Apr 2014 11:51:03 +0100
\r
27 Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1We0CC-0006Lg-H6; Sat, 26 Apr 2014 11:51:00 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 00/11] Improve charset and cid: handling
\r
34 In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu>
\r
35 References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>
\r
36 User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Sat, 26 Apr 2014 11:50:56 +0100
\r
39 Message-ID: <87tx9gl5yn.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 87.81.223.162
\r
43 X-QM-Geographic: According to ripencc,
\r
44 this message was delivered by a machine in Britain (UK) (GB).
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: a0adc557c4a0351168ac667c3bd0f1dd (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -0.1
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -0.1 points.
\r
53 Summary of the scoring:
\r
54 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
55 provider * (markwalters1009[at]gmail.com)
\r
56 * -0.1 AWL AWL: From: address is in the auto white-list
\r
57 X-QM-Scan-Virus: ClamAV says the message is clean
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sat, 26 Apr 2014 10:51:15 -0000
\r
73 Aside from the minor comments I mentioned in previous emails and one
\r
74 more comment below this looks good.
\r
76 The extra comment is that on emacs23 I get the following when compiling:
\r
79 notmuch-show.el:2188:1:Warning: the following functions are not known to be
\r
80 defined: libxml-parse-html-region, shr-insert-document
\r
82 Finally, I have not really tested it as I mainly use emacs23
\r
91 On Mon, 21 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:
\r
92 > I set out to quickly add support for cid: links in the shr renderer
\r
93 > and wound up making our charset handling more robust and rewriting our
\r
94 > content-ID handling. The test introduced in patch 2 passes in all but
\r
95 > one really obscure case, but only because of many unwritten and
\r
96 > potentially fragile assumptions that Emacs and the CLI make about each
\r
99 > The first three patches could reasonably go in to 0.18. The rest of
\r
100 > this series is certainly post-0.18, but I didn't want to lose track of
\r
103 > This series comes in three stages. Each depends on the earlier ones,
\r
104 > but each prefix makes sense on its own and could be pushed without the
\r
107 > Patch 1 is a simple clean up patch.
\r
109 > Patches 2 through 7 robust-ify our charset handling in Emacs, mostly
\r
110 > by splitting the broken `notmuch-get-bodypart-content' API into
\r
111 > `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a
\r
112 > caller can explicitly convey their requirements.
\r
114 > The remaining patches improve our content-ID handling and add support
\r
115 > for cid: links for shr.
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r