1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 52BD5431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 00:09:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id nMKcSX29HrEw for <notmuch@notmuchmail.org>;
\r
16 Wed, 21 Nov 2012 00:09:54 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 678AB431FAF
\r
19 for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 00:09:54 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 9E96B10010B;
\r
22 Wed, 21 Nov 2012 10:09:51 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>, "Tom Prince" <tom.prince@ualberta.net>
\r
25 Subject: Re: [PATCH] test: Produce useful output when the HTML with images
\r
27 In-Reply-To: <1353427125-13854-1-git-send-email-amdragon@mit.edu>
\r
28 References: <1353427125-13854-1-git-send-email-amdragon@mit.edu>
\r
29 User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 21 Nov 2012 10:09:51 +0200
\r
35 Message-ID: <m2haojgywg.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 Cc: notmuch@notmuchmail.org
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Wed, 21 Nov 2012 08:09:58 -0000
\r
53 On Tue, Nov 20 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
55 > Previously, this would simply indicate that the grep failed without
\r
56 > any indication of the Emacs output it failed on. Now we take
\r
57 > advantage of the test framework's handling of stdout to display the
\r
58 > incorrect Emacs output if the test fails.
\r
61 > Besides being a good idea in general, this is the first step toward
\r
62 > fixing this test on the Notmuch buildbot, since right now there's no
\r
63 > indication of why it's failing.
\r
65 Tom: could you do separate test on the buildbot machine (master-emacs24
\r
66 config) with this patch applied and then running
\r
67 NOTMUCH_TESTS=emacs make test
\r
71 > test/emacs | 5 +++--
\r
72 > 1 file changed, 3 insertions(+), 2 deletions(-)
\r
74 > diff --git a/test/emacs b/test/emacs
\r
75 > index 77265b0..5649d55 100755
\r
78 > @@ -809,9 +809,10 @@ test_emacs "(let ((mm-text-html-renderer
\r
79 > (notmuch-show \"id:${gen_msg_id}\"))
\r
80 > (test-output)" > /dev/null
\r
81 > # Different Emacs versions and renderers give very different results,
\r
82 > -# so just check that something reasonable showed up.
\r
83 > +# so just check that something reasonable showed up. We first cat the
\r
84 > +# output so the test framework will print it if the test fails.
\r
85 > test_expect_success "Rendering HTML mail with images" \
\r
86 > - 'grep -q smiley OUTPUT'
\r
87 > + 'cat OUTPUT && grep -q smiley OUTPUT'
\r
94 > _______________________________________________
\r
95 > notmuch mailing list
\r
96 > notmuch@notmuchmail.org
\r
97 > http://notmuchmail.org/mailman/listinfo/notmuch
\r