1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 6959C6DE1104
\r
6 for <notmuch@notmuchmail.org>; Mon, 9 Nov 2015 04:51:01 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-1.135 tagged_above=-999 required=5 tests=[AWL=1.715,
\r
12 RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.55] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id f1grokkLq803 for <notmuch@notmuchmail.org>;
\r
16 Mon, 9 Nov 2015 04:50:59 -0800 (PST)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 136D96DE020B
\r
19 for <notmuch@notmuchmail.org>; Mon, 9 Nov 2015 04:50:58 -0800 (PST)
\r
20 Received: from localhost (unknown [192.168.200.7])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 49CA319F4575;
\r
22 Mon, 9 Nov 2015 13:50:56 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP STYX AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044)
\r
26 with ESMTP id aIIAG29-imuF; Mon, 9 Nov 2015 13:50:54 +0100 (CET)
\r
27 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
28 by max.feld.cvut.cz (Postfix) with ESMTP id 8C1DB19F41ED;
\r
29 Mon, 9 Nov 2015 13:50:53 +0100 (CET)
\r
30 Received: from wsh by steelpick.2x.cz with local (Exim 4.86)
\r
31 (envelope-from <sojkam1@fel.cvut.cz>)
\r
32 id 1ZvluO-0000vu-Fs; Mon, 09 Nov 2015 13:50:52 +0100
\r
33 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
34 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
35 Subject: Re: [PATCH] emacs: Fix regression in (notmuch-)message-mode
\r
37 In-Reply-To: <87d1vj4b9z.fsf@zancas.localnet>
\r
38 References: <1446573161-28068-1-git-send-email-sojkam1@fel.cvut.cz>
\r
39 <87d1vj4b9z.fsf@zancas.localnet>
\r
40 User-Agent: Notmuch/0.21+9~ga3f5262 (http://notmuchmail.org) Emacs/24.5.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Mon, 09 Nov 2015 13:50:52 +0100
\r
43 Message-ID: <87bnb38hg3.fsf@steelpick.2x.cz>
\r
45 Content-Type: text/plain
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.20
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Mon, 09 Nov 2015 12:51:01 -0000
\r
60 On Mon, Nov 09 2015, David Bremner wrote:
\r
61 > Michal Sojka <sojkam1@fel.cvut.cz> writes:
\r
63 >> This commit uses advice mechanism to call notmuch-message-mode instead
\r
64 >> of message-mode. This way, a call to message-mail initializes directly
\r
65 >> notmuch-message-mode rather than message-mode which is later changed
\r
66 >> to notmuch-message-mode. The advice is constructed in such a way, that
\r
67 >> it is effective only once and when called by notmuch. The second call
\r
68 >> to message-mode (from notmuch-message-mode) calls the original
\r
71 > I wanted to answer this with an alternative patch, but I haven't had
\r
74 > I admit to being somewhat prejudiced against shipping code with advice
\r
75 > in it (IMHO it's fine for user specific customization, but not very
\r
78 > I think we might be better off in the long run replacing the call to
\r
79 > message-mail. Code duplication is obviously not great, but perhaps some
\r
80 > of the complexity of message-mail / message-pop-to-buffer can be
\r
81 > eliminated, since we don't need to support all of the use cases of
\r
84 OK. I'll try implement notmuch-message-mail as a simpler alternative to
\r
85 message-mail. Let's see how it will look like.
\r
88 >> This implementation uses the new advice mechanism introduced in Emacs
\r
89 >> 24.4. If we want to support older version, this must be changed.
\r
91 > We do try to support Emacs 23 still (except for some optional
\r
92 > features). Unfortunately old advice is even nastier.
\r
94 Hopefully, advises won't be needed then.
\r