Ken Raeburn [Sat, 16 Sep 2006 01:49:52 +0000 (01:49 +0000)]
Update dependencies
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18590
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 16 Sep 2006 01:32:40 +0000 (01:32 +0000)]
Move RPC header files to include/gssrpc, which we copy to them at
build time, and which is the only place we use them from anyways.
Update Makefile references and dependencies.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18589
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 16 Sep 2006 01:25:12 +0000 (01:25 +0000)]
Export krb5_ldap_release_errcode_string
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18588
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 15 Sep 2006 22:57:09 +0000 (22:57 +0000)]
Make it easier to ignore additional directories, like, oh, say, local
install paths for OpenLDAP.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18587
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 13 Sep 2006 20:30:23 +0000 (20:30 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18584
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 12 Sep 2006 00:25:34 +0000 (00:25 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18583
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 12 Sep 2006 00:20:01 +0000 (00:20 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18582
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 7 Sep 2006 22:16:45 +0000 (22:16 +0000)]
* Makefile.in (krb5/krb5.h): Wrap the content in macro test for
multiple-inclusion protection.
ticket: 3522
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18571
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 6 Sep 2006 20:31:54 +0000 (20:31 +0000)]
Make database plugin responsible for releasing the error-message string, so
that we can use the krb5_get_error_message interface internally.
* kdb5.h: Add release_errcode_string field to the interface.
* db2_exp.c, ldap_exp.c: Initialize it.
* ldap_misc.c: Use krb5_get/free_error_message for error message strings.
* kdb_ldap.h: Declare krb5_ldap_release_errcode_string.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18565
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 6 Sep 2006 19:54:06 +0000 (19:54 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18564
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 6 Sep 2006 17:15:12 +0000 (17:15 +0000)]
comment formatting for 80 columns
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18563
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 5 Sep 2006 21:54:47 +0000 (21:54 +0000)]
(prof_get_integer_def, prof_get_string_def): New functions: check specified
config section in the profile, then the default section, then fall back to
passed default value (for integer only). Set error string on error.
(krb5_ldap_read_server_params): Use them, instead of explicitly doubling each
profile_get call.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18562
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Tue, 5 Sep 2006 18:47:29 +0000 (18:47 +0000)]
windows ccache and keytab file paths without a prefix
ktbase.c, ccbase.c: When a file path is specified without
the prefix we must infer the use of the "FILE" prefix.
However, we were setting the prefix including the colon
separator when the separator should have been ignored.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18561
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 1 Sep 2006 02:51:38 +0000 (02:51 +0000)]
Reject old OpenLDAP versions with bugs tickled by this code.
Clean up some warnings during the build.
* ldap_misc.c (strptime) [NEED_STRPTIME_PROTO]: Declare, conditionally.
(krb5_ldap_errcode_2_string): Return string, not error code, to fit with DAL
interface spec.
* kdb_ldap.h: Error out for OpenLDAP versions before 2.2.24.
(LDAP_DEPRECATED): Define; openldap-2.3.27 defaults to undefined.
(krb5_ldap_lib_init): Prototype.
(krb5_get_policydn): Declare.
(krb5_ldap_errcode_2_string): Fix return type.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18558
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Aug 2006 22:12:36 +0000 (22:12 +0000)]
(krb5_ldap_destroy_policy): krb5_ldap_delete_policy takes a mask arg, not pointer-to
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18557
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Aug 2006 22:08:45 +0000 (22:08 +0000)]
Declare get_date() used from kadmin cli code.
In calls, delete the second argument that get_date doesn't take.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18556
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Aug 2006 21:30:30 +0000 (21:30 +0000)]
Remove or conditionalize unused variables
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18555
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Aug 2006 21:17:34 +0000 (21:17 +0000)]
Patches from Will Fiveash to allow for configuration and building on
Solaris. Tested (configured & built) on RHEL 4 and Solaris 10. One
minor bugfix added.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18554
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 30 Aug 2006 19:44:54 +0000 (19:44 +0000)]
* shlib.conf (*-*-linux*): Use LDFLAGS in LDCOMBINE
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18553
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 30 Aug 2006 00:10:54 +0000 (00:10 +0000)]
Some mechanical changes (mostly whitespace, like indentation levels)
to match up better with MIT coding style.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18552
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 29 Aug 2006 22:54:46 +0000 (22:54 +0000)]
Some mechanical changes (mainly whitespace) to match up better with
MIT coding style.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18551
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 29 Aug 2006 20:41:50 +0000 (20:41 +0000)]
Rename KRB5_KDB_PLUGIN_OP_NOTSUPP to KRB5_PLUGIN_OP_NOTSUPP and move to krb5 table
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18550
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 29 Aug 2006 20:13:27 +0000 (20:13 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18549
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 29 Aug 2006 19:52:38 +0000 (19:52 +0000)]
Patch from Savitha R:
ldap_util
1. Kdb5_ldap_util interface
Removed supp enctypes, suppsalttypes from create realm and modify
realm since they are currently not used
2. memset passwd strings to zero when not used any more
3. Using krb5_sname_to_principal in place of gethostbyname while
creating the kadmin principal with hostname.
libkdb_ldap
1. Added mandatory functions which were missing in the LDAP plug-in
2. Error handling changes - Setting the error message in the
kerberos context when decryption of the service passwd fails or
connection to the LDAP server fails during initialization.
Additional changes:
libkdb_ldap: Link against com_err library, to provide error_message().
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18548
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 23 Aug 2006 22:58:02 +0000 (22:58 +0000)]
make depend
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18519
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 23 Aug 2006 22:56:29 +0000 (22:56 +0000)]
Merge Todd's TCP changepw support, with a few fixups
* include/cm.h (state_strings, enum conn_states, struct incoming_krb5_message,
struct conn_state): Moved here from lib/krb5/os/sendto_kdc.c.
(stuct sendto_callback_info): New type.
* lib/krb5/os/sendto_kdc.c (set_conn_state_msg_length): New function.
(setup_connection): Deleted argument message_len_buf. Don't store message
length; call set_conn_state_msg_length instead.
(start_connection): New arguments callback_info and callback_buffer. Invoke
callback function if any, and set message length on success.
(maybe_send): New arguments callback_info and callback_buffer; pass them to
start_connection.
(krb5int_sendto): New arguments callback_info, remoteaddr, remoteaddrlen. If
callback info is provided, allocate per-connection buffers, and pass them to
maybe_send. On cleanup, invoke the cleanup callback function if any.
(krb5_sendto_kdc): Update krb5int_sendto call.
* include/k5-int.h (struct sendto_callback_info): Add forward declaration.
(krb5int_sendto, struct _krb5int_access.sendto_udp): Update for new signature.
* lib/krb5/os/send524 (krb5int_524_sendto_kdc): Update krb5int_sendto call.
* lib/krb4/send_to_kdc.c (krb5int_send_to_kdc_addr): Update sendto_udp call.
* lib/krb5/os/changepw.c (struct sendto_callback_context): New type.
(krb5_locate_kpasswd): New argument useTcp, used to select socket type in
krb5int_locate_server call.
(kpasswd_sendto_msg_cleanup, kpasswd_sendto_msg_callback): New functions.
(krb5_change_set_password): Call krb5int_sendto with callbacks, instead of
managing the exchange here. On RESPONSE_TOO_BIG error, try again with TCP
only.
* lib/krb5/krb/chpw.c (krb5int_rd_chpw_rep): If length is wrong, check if a
buggy server sent a KRB_ERROR.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18518
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 23 Aug 2006 16:33:58 +0000 (16:33 +0000)]
Update auxiliary version number for NetIDMgr
ticket: 4172
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18499
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 23 Aug 2006 02:28:05 +0000 (02:28 +0000)]
* install NetIDMgr plug-in sample as part of SDK
* install netidmgr.exe (win2000 version)
ticket: 4172
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18498
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 23 Aug 2006 02:18:00 +0000 (02:18 +0000)]
* newcredwnd.c - erase the password field on error
during new credential acquisition
ticket: 4172
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18497
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 23 Aug 2006 02:17:12 +0000 (02:17 +0000)]
* Fix auto-registration of plug-in modules
if there is no plug-in list specified
ticket: 4172
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18496
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 23 Aug 2006 02:15:52 +0000 (02:15 +0000)]
* Makefile - do not etag the Win2000 version of
the NetIDMgr.exe
ticket: 4172
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18495
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Tue, 22 Aug 2006 22:12:15 +0000 (22:12 +0000)]
improvements to netidmgr dialogs
* ensure that buttons are disabled while
actions are in process
* allow plug-ins to specify italic text
* fix some documentation
* reformat langres.rc
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18494
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 21 Aug 2006 20:31:51 +0000 (20:31 +0000)]
clean up mkrel patchlevel.h editing etc
* src/util/mkrel: Be more careful editing KRB5_RELDATE. Delete
'$ac_config_fragdir' autoconf droppings.
ticket: new
tags: pullup
target_version: 1.5.1
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18475
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Thu, 17 Aug 2006 01:21:00 +0000 (01:21 +0000)]
NetIDMgr Credential Provider Sample Code and Documentation
This commit provides a template for a Network Identity Manager
Credential Provider. It doesn't provide any real functionality
but it does provide all of the functions that need to be specified
and filled in as part of the process of producing a NetIdMgr plug-in.
This code should be pulled up to 1.4.x for inclusion in the KFW 3.1
SDK as well as to 1.5.x.
ticket: new
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18464
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 16 Aug 2006 21:01:43 +0000 (21:01 +0000)]
cc_err_xlate: Updated error mappings to generate the same errors as ccapiv2.
stdccv3_setup: Don't translate errors since cc_err_xlate isn't idempotent.
krb5_stdccv3_resolve: Don't fail if we can't open the ccache.
ticket: 3936
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18458
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 15 Aug 2006 23:45:54 +0000 (23:45 +0000)]
* kdb5_ldap_realm.c (kdb5_ldap_create): In assertion test of hardcoded char
array sizes, test against the size we actually need.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18449
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 15 Aug 2006 23:43:27 +0000 (23:43 +0000)]
* kdb_default.c (krb5_def_store_mkey): If the file can't be opened, construct
an error message that includes the file's name.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18448
dc483132-0cff-0310-8789-
dd5450dbe970
Russ Allbery [Tue, 15 Aug 2006 22:49:57 +0000 (22:49 +0000)]
Set datarootdir in each Makefile to make Autoconf 2.60 happier
Ticket: 3965
Component: krb5-build
Version_Reported: 1.5
Tags: pullup
Target_Version: 1.5.1
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18444
dc483132-0cff-0310-8789-
dd5450dbe970
Russ Allbery [Tue, 15 Aug 2006 22:27:17 +0000 (22:27 +0000)]
Document prerequisites for make check
Document the prerequisites for running make check, since some of them are
a bit surprising.
Ticket: new
Component: krb5-doc
Tags: pullup
Version_Reported: 1.5
Target_Version: 1.5.1
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18441
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 15 Aug 2006 19:27:08 +0000 (19:27 +0000)]
* src/clients/ksu/main.c (sweep_up): Don't check return value of
krb5_seteuid(0), as it is not harmful for it to fail, and it will
fail after setuid(target_user). Correct error message.
ticket: 4137
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18438
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 8 Aug 2006 19:26:40 +0000 (19:26 +0000)]
fix MITKRB5-SA-2006-001: multiple local privilege escalation vulnerabilities
* src/appl/gssftp/ftpd/ftpd.c (getdatasock, passive):
* src/appl/bsd/v4rcp.c (main):
* src/appl/bsd/krcp.c (main):
* src/appl/bsd/krshd.c (doit):
* src/appl/bsd/login.c (main):
* src/clients/ksu/main.c (sweep_up):
* src/lib/krb4/kuserok.c (kuserok): Check return values from
setuid() and related functions to avoid privilege escalation
vulnerabilities. Fixes MITKRB5-SA-2006-001. [CVE-2006-3083,
VU#580124, CVE-2006-3084, VU#401660]
ticket: new
target_version: 1.5.1
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18420
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 7 Aug 2006 23:33:39 +0000 (23:33 +0000)]
* src/lib/gssapi/mechglue/mglueP.h: Add loopback field to opaque
structs of gss_ctx_id_t, gss_name_t, gss_cred_id_t to catch some
application programming errors. Add new macro GSSINT_CHK_LOOP()
which returns non-zero if loopback field doesn't point to itself.
* src/lib/gssapi/mechglue/g_accept_sec_context.c
(gss_accept_sec_context):
* src/lib/gssapi/mechglue/g_acquire_cred.c (gss_add_cred)
(gss_acquire_cred):
* src/lib/gssapi/mechglue/g_delete_sec_context.c
(gss_delete_sec_context):
* src/lib/gssapi/mechglue/g_glue.c
(gssint_convert_name_to_union_name):
* src/lib/gssapi/mechglue/g_imp_name.c (gss_import_name):
* src/lib/gssapi/mechglue/g_imp_sec_context.c
(gss_import_sec_context):
* src/lib/gssapi/mechglue/g_init_sec_context.c
(gss_init_sec_context): Set loopback pointers.
* src/lib/gssapi/mechglue/g_delete_sec_context.c
(gss_delete_sec_context):
* src/lib/gssapi/mechglue/g_rel_cred.c (gss_release_cred):
* src/lib/gssapi/mechglue/g_rel_name.c (gss_release_name): Call
GSSINT_CHK_LOOP() to validate loopback pointer.
ticket: 4063
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18417
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 2 Aug 2006 20:51:50 +0000 (20:51 +0000)]
Apply patch from Michael Calmer to fix some uninitialized variables
* src/appl/gssftp/ftpd/ftpd.c (auth_data): Initialize stat_maj,
accept_maj, acquire_maj.
* src/appl/telnet/libtelnet/kerberos5.c (kerberos5_send):
Intialize rdata.
* src/kdc/do_tgs_req.c (process_tgs_req): Initialize magic and
tr_contents.magic.
* src/lib/krb5/asn.1/krb5_decode.c (decode_krb5_safe_with_body):
Initialize tmpbody.magic.
* src/plugins/kdb/db2/libdb2/hash/dbm.c (kdb2_fetch)
(kdb2_firstkey, kdb2_nextkey): Initialize dsize.
ticket: 3904
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18404
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 1 Aug 2006 21:09:43 +0000 (21:09 +0000)]
* src/lib/gssapi/mechglue/g_initialize.c (gss_release_oid): Call
gssint_initialize_library to ensure mutex is initialized.
ticket: 4088
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18397
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 25 Jul 2006 20:29:43 +0000 (20:29 +0000)]
Changed GSSAPI opaque types (gss_name_t, gss_cred_id_t, gss_ctx_id_t) from
void* to pointers to opaque structs. This change removed some casts and
introduced or changed a bunch of other casts to suppress warnings.
krb5_gss_accept_sec_context(): Fixed a bug found by the above changes
where krb5_gss_release_cred() was being called with the wrong argument 2
(gss_cred_id_t instead of gss_cred_id_t*).
ticket: 4057
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18396
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 25 Jul 2006 18:51:54 +0000 (18:51 +0000)]
gss_canonicalize_name(): Added parens to remove
warning from if statement.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18395
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 25 Jul 2006 17:58:25 +0000 (17:58 +0000)]
Removed unused Metrowerks compiler support.
(Since there's no universal binary support for CodeWarrior there's
no point in having this here.)
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18394
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 25 Jul 2006 17:56:18 +0000 (17:56 +0000)]
Switched from "#pragma options align" to "#pragma pack".
Removed Metrowerks "#pragma import" since other framework
headers don't specify it.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18392
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Tue, 25 Jul 2006 13:59:30 +0000 (13:59 +0000)]
Windows - fix kfwlogon for Windows 2000
Windows 2000 does not support the ability to generate SIDs
from symbolic names.
Add more debugging and error condition checks.
ticket: new
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18387
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Mon, 24 Jul 2006 20:39:31 +0000 (20:39 +0000)]
commit again without using patch to apply the diff
ticket: 4048
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18382
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Mon, 24 Jul 2006 20:37:36 +0000 (20:37 +0000)]
undo previous commit due to EOL issues
ticket: 4048
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18381
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 24 Jul 2006 19:27:04 +0000 (19:27 +0000)]
Switched from "#pragma options align" to "#pragma pack".
Removed Metrowerks "#pragma import" since other framework
headers don't specify it.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18380
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Mon, 24 Jul 2006 06:58:23 +0000 (06:58 +0000)]
Windows Integrated Login Fixes for KFW 3.1
KFW integrated login was failing when the user is
not a power user or administrator. This was occurring
because the temporary file ccache was being created in
a directory the user could not read. While fixing this
it was noticed that the ACLs on the ccache were too broad.
Instead of applying a fix to the FILE: krb5_ccache
implementation it was decided that simply applying a new
set of ACLs (SYSTEM and "user" with no inheritance) to
the file immediately after the krb5_cc_initialize() call
would close the broadest security issues.
The file is initially created in the SYSTEM %TEMP% directory
with "SYSTEM" ACL only. Then it is moved to the user's %TEMP%
directory with "SYSTEM" and "user" ACLs. Finally, after
copying the credentials to the API: ccache, the file is deleted.
ticket: new
tags: pullup
component: windows
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18379
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 21 Jul 2006 19:03:02 +0000 (19:03 +0000)]
* aclocal.m4 (KRB5_LIB_AUX): Disallow --enable-profiled and --disable-shared
options as well. Don't generate help messages for these options.
ticket: 4036
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18352
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 21 Jul 2006 18:29:25 +0000 (18:29 +0000)]
* ldap_service_stash.c (krb5_ldap_readpassword): Don't require strerror_r, fall
back to strerror if needed.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18351
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 21 Jul 2006 17:49:07 +0000 (17:49 +0000)]
respect LDFLAGS in NetBSD build
An LDFLAGS setting at configure time is ignored in parts of the build.
* shlib.conf (*-*-netbsd*): Use $(CC) for LDCOMBINE, and include $(LDFLAGS).
ticket: new
target: 1.5.1
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18350
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 21 Jul 2006 17:41:43 +0000 (17:41 +0000)]
reject configure option for static libraries
We shouldn't accept --enable-static at configure time when we know
it's not going to work at build time.
* aclocal.m4 (KRB5_LIB_AUX): Error out if --enable-static.
ticket: new
target_version: 1.5.1
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18348
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 21 Jul 2006 13:48:37 +0000 (13:48 +0000)]
Windows - kfw 3.1 msi deployment guide updates
documentation updates for the kfw 3.1 msi deployment guide.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18346
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 21 Jul 2006 03:12:00 +0000 (03:12 +0000)]
Windows NetIDMgr documentation
NetIDMgr 1.1 documentation for KFW 3.1 release
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18345
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Wed, 19 Jul 2006 22:36:00 +0000 (22:36 +0000)]
Windows NetIDMgr post-1.5 branch commits
The following patch updates the NetIDMgr:
* allow plug-ins to be marked "do not unload" in order
to support DLLs that create threads that are not
properly cleaned up as part of library unload.
* allow plug-ins to be marked "disabled"
* Additional changes to deal with Microsoft's efforts
to deprecate all of the str C runtime functions.
* Improvements to Manifest processing in the build
system
* Addition of Tooltip support to the Toolbar. Dragging
the mouse over toolbar buttons displays textual
descriptions.
* Correct the behavior of the New Credentials Dialog
to disable the "Ok" button after it has been pressed.
* Add support to allow plugin configuration data to
be distributed as part of transforms to the MSI
installer.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18344
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 19 Jul 2006 18:14:01 +0000 (18:14 +0000)]
acquire_cred(), kg_caller_provided_ccache_name(): On further reflection
and testing the correct thing appears to be to have gss_krb5_ccache_name()
stop gss_acquire_cred() from searching for the desired name in the cache
collection. If the caller sets the ccache name then gss_acquire_cred will only
look in that ccache. Added kg_caller_provided_ccache_name() to tell whether
or not the caller has actually set the ccache. This should fix the problem for
both Mac OS X and Windows.
ticket: 4024
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18343
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 19 Jul 2006 16:14:57 +0000 (16:14 +0000)]
need to look harder for tclConfig.sh
Our current scheme doesn't find tclConfig.sh as installed by NetBSD's
pkg system, even if it finds tclsh and gets the library pathname from
it. The problem is that tclConfig.sh is one directory up.
* aclocal.m4 (AC_KRB5_TCL_FIND_CONFIG): Check $tcl_dir/.. for tclConfig.sh.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18342
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 19 Jul 2006 02:28:24 +0000 (02:28 +0000)]
acquire_cred(): Realized that my previous patch now basically favors the
ccache over the desired name. Added a KLL function to search for the
desired name, favoring the default ccache.
ticket: 4024
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18341
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 18 Jul 2006 20:11:39 +0000 (20:11 +0000)]
acquire_cred(): Fixed KLL support to try the default ccache first if
it is set.
ticket: 4024
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18340
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 18 Jul 2006 20:03:10 +0000 (20:03 +0000)]
kadmin_startup(): Turn off KLL automatic prompting support in kadmin
ticket: 4023
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18339
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 18 Jul 2006 19:51:37 +0000 (19:51 +0000)]
Project cleanup:
Removed kipc APIs and deleted files.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18338
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 18 Jul 2006 19:43:52 +0000 (19:43 +0000)]
authgss_refresh(): Use GSS_C_NO_CHANNEL_BINDINGS macro
instead of NULL with gss_init_sec_context to increase readbility.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18337
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Tue, 18 Jul 2006 19:29:32 +0000 (19:29 +0000)]
Windows: NSIS updates for 2.18 release
This commit corrects errors in the NSIS installer scripts
that prevent installer builds using NSIS 2.18.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18336
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Tue, 18 Jul 2006 19:24:23 +0000 (19:24 +0000)]
Windows: Wix 2.0.4221 updates
This commit corrects errors in the Wix installer script
files that violate the Wix schema but which were not
caught by earlier releases of the Wix 2.0 installer.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18335
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Tue, 18 Jul 2006 00:40:19 +0000 (00:40 +0000)]
Merge remaining changes from LDAP integration branch
svn+ssh://svn.mit.edu/krb5/branches/ldap-integ@18333.
* plugins/kdb/ldap: New directory.
* aclocal.m4 (WITH_LDAP): New macro.
(CONFIG_RULES): Invoke it.
* configure.in: Test ldap option, maybe configure and generate makefiles for
new directories, and set and substitute ldap_plugin_dir.
* Makefile.in (SUBDIRS): Add @ldap_plugin_dir@.
* kdc/krb5kdc.M, kadmin/server/kadmind.M, kadmin/cli/kadmin.M,
config-files/krb5.conf.M: Document LDAP changes (new options, config file
entries, etc).
* lib/kdb/kdb5.c (kdb_load_library): Put more info in error message.
* lib/kadm5/admin.h (KADM5_CPW_FUNCTION, KADM5_RANDKEY_USED,
KADM5_CONFIG_PASSWD_SERVER): New macros, disabled for now.
(struct _kadm5_config_params): New field kpasswd_server, commented out for now.
* lib/krb5/error_tables/kdb5_err.et: Add error codes KRB5_KDB_ACCESS_ERROR,
KRB5_KDB_INTERNAL_ERROR, KRB5_KDB_CONSTRAINT_VIOLATION.
ticket: 2935
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18334
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 17 Jul 2006 19:25:02 +0000 (19:25 +0000)]
make depend
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18332
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 17 Jul 2006 17:55:54 +0000 (17:55 +0000)]
(KRB5_AC_FIND_DLOPEN): Use AC_SEARCH_LIBS
ticket: 3971
target_version: 1.5.1
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18331
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 17 Jul 2006 16:39:35 +0000 (16:39 +0000)]
reverse test for copy_oid_set in lib/gssapi/krb5/indicate_mechs.c
* src/lib/gssapi/krb5/indicate_mechs.c: Reverse sense of test,
since gssint_copy_oid_set() returns 0 on success.
ticket: new
target_version: 1.5.1
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18330
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Mon, 17 Jul 2006 15:44:24 +0000 (15:44 +0000)]
stdcc.c: fix v2 version of krb5_stdcc_resolve()
cc_open() returning CC_NOEXIST should not be
considered fatal.
ticket: 3961
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18329
dc483132-0cff-0310-8789-
dd5450dbe970
Russ Allbery [Wed, 12 Jul 2006 22:17:34 +0000 (22:17 +0000)]
Document add_entry in ktutil man page
Apply patch from Mike Dopheide to document ktutil add_entry in the man
page and fix some other spelling errors in the ktutil man page.
Ticket: new
Version_Reported: 1.3.6
Target_Version: 1.5.2
Tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18328
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 11 Jul 2006 17:28:07 +0000 (17:28 +0000)]
Cleaned up CCAPI v3 code to remove memory leaks. Fixed crashes in
cc_ccache <-> krb5_ccache translation code. Still testing edge cases but
the code seems to work now with the KfM CCAPI implementation.
ticket: 3936
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18327
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 10 Jul 2006 18:52:37 +0000 (18:52 +0000)]
Fixed up warnings and whitespace issues which were confusing the
Xcode auto-indenter.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18326
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 10 Jul 2006 18:51:23 +0000 (18:51 +0000)]
Fixed up warnings and converted to Unix line endings
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18325
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 10 Jul 2006 18:34:19 +0000 (18:34 +0000)]
Removed user preferences which were accidentally added
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18324
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Mon, 3 Jul 2006 05:23:16 +0000 (05:23 +0000)]
GetModuleHandle needs extension on Win64
cc_mslsa.c: some versions of Win64 require the extension
to be specified as part of the parameter to GetModuleHandle()
in order to find a match.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18320
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 1 Jul 2006 01:50:37 +0000 (01:50 +0000)]
work around failure to load into nonexistent db
* src/tests/Makefile.in (kdb_check): Run kdb5_util create after
destroying to work around a behavior change from DAL integration.
ticket: new
target_version: 1.5
tags: pullup
version_reported: 1.5
component: test
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18313
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 1 Jul 2006 01:18:53 +0000 (01:18 +0000)]
make gss_unwrap match prototype
* src/lib/gssapi/mechglue/g_unseal.c (gss_unwrap): Make match
prototype.
ticket: new
tags: pullup
target_version: 1.5
version_reported: 1.5
component: krb5-libs
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18310
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 23:22:32 +0000 (23:22 +0000)]
test kdb5_util dump/load functionality in dejagnu
This new test just dumps and reloads the database. It doesn't examine
the resulting database, but kinit and other tests are run after it,
using the reloaded database.
* standalone.exp (dump_and_reload): New proc.
(doit): Invoke it.
ticket: new
target_version: 1.5
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18308
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 21:39:36 +0000 (21:39 +0000)]
copyright dates
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18297
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 21:07:25 +0000 (21:07 +0000)]
* dump.c (load_db): Call krb5_db_promote instead of krb5_db_fini
ticket: 3964
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18296
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 21:05:21 +0000 (21:05 +0000)]
* kdb_db2.c: Don't include kdb_compat.h.
(OLD_COMPAT_VERSION_1): Don't define.
(krb5_db2_db_create): For temporary db, use different names for all files.
(krb5_db2_open, krb5_db2_create, krb5_db2_destroy): Fix check for "temporary"
in supplied db_args.
(krb5_db2_db_rename): New function, restored from pre-DAL code and hacked up
a lot to mostly work.
(krb5_db2_promote_db): New function.
* db2_exp.c: Add promote_db entry.
ticket: 3964
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18295
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 20:18:39 +0000 (20:18 +0000)]
* kdb_default.c (krb5_def_promote_db): New function.
* kdb5.c (kdb_setup_opt_functions): Use it if promote_db is null.
* libkdb5.exports: Export krb5_db_promote.
ticket: 3964
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18292
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 20:17:04 +0000 (20:17 +0000)]
* kdb.h (krb5_def_promote_db): Declare
ticket: 3964
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18291
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 30 Jun 2006 18:20:26 +0000 (18:20 +0000)]
g_delete_sec_context.c: undo type cast change from last
commit that is wrong.
ticket: 3968
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18289
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 30 Jun 2006 09:22:32 +0000 (09:22 +0000)]
corrections to gssapi mechglue
g_delete_sec_context.c: use the correct type during assignment
g_init_sec_context.c; prevent memory leak and make code more
readable
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18288
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 30 Jun 2006 09:20:59 +0000 (09:20 +0000)]
stdcc.c: undo change which broke the opening of ccaches
ticket: 3961
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18287
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Jun 2006 05:59:46 +0000 (05:59 +0000)]
* src/lib/krb5/krb/srv_rcache.c (krb5_get_server_rcache):
Oops, krb5_rc_close actually does free rcache, so actually do null
rcache on error from krb5_rc_recover_or_initialize. Thanks to
Shawn Emery for noticing.
ticket: 3962
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18286
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Fri, 30 Jun 2006 05:43:40 +0000 (05:43 +0000)]
* plugins/kdb/db2/kdb_db2.c (krb5_db2_db_init): Support tempdb
(krb5_db2_db_set_name): likewise
(krb5_db2_open): likewise
(krb5_db2_create): likewise
(krb5_db2_db_create): likewise
(krb5_db2_db_set_option): likewise
(krb5_db2_destroy): likewise
* plugins/kdb/db2/kdb_db2.h: Add tempdb to db context
* plugins/kdb/db2/kdb_db2.c (k5db2_dbopen): Take flag for
temporary databases.
Ticket: 3964
Status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18285
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Jun 2006 03:57:20 +0000 (03:57 +0000)]
* src/lib/krb5/krb/srv_rcache.c (krb5_get_server_rcache): Adapted
patch from Shawn Emery to set rcache = 0 in case of
krb5_rc_resolve_full failure because krb5_rc_resolve_full frees
but doesn't null rcache. Also restore free of rcache in cleanup
code. Continue to not null rcache in failure on
krb5_rc_recover_or_initialize because krb5_rc_close doesn't free
rcache.
ticket: 3962
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18283
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 03:51:48 +0000 (03:51 +0000)]
New kdb backend operation promote_db, makes a temporary database become the
live database. New function krb5_db_promote invokes it.
ticket: 3964
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18282
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Fri, 30 Jun 2006 03:02:23 +0000 (03:02 +0000)]
* plugins/kdb/db2/kdb_db2.c (krb5_db2_create): Remove incorrect
comment.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18281
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Fri, 30 Jun 2006 02:42:22 +0000 (02:42 +0000)]
* lib/kdb/kdb5.h: Remove macros also defined in include/kdb5.h
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18280
dc483132-0cff-0310-8789-
dd5450dbe970
Jeffrey Altman [Fri, 30 Jun 2006 00:46:14 +0000 (00:46 +0000)]
fix stdcc.c to build without USE_CCAPI_V3
stdcc.c: should build without USE_CCAPI_V3
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18278
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 30 Jun 2006 00:17:43 +0000 (00:17 +0000)]
(add_db_arg): Fix silly bug.
(extended_com_err_fn): Don't look up or print error message if the error code
is 0.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18277
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 29 Jun 2006 23:51:55 +0000 (23:51 +0000)]
* kdb5_util.c (add_db_arg): New function.
(main): Use it.
* kdb5_util.h (add_db_arg): Declare it.
* kdb5_create.c (kdb5_create): Use it.
* dump.c (load_db): Use it.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18276
dc483132-0cff-0310-8789-
dd5450dbe970