63/80916a1a4f9d8da6e542dd10be92f2ba31292e

   1 Return-Path: <wking@tremily.us>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 19EF5431FC9\r
   6         for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 17:17:37 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.1\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id nSdiMf0oJXFR for <notmuch@notmuchmail.org>;\r
  17         Tue, 15 Jul 2014 17:17:33 -0700 (PDT)\r
  18 Received: from qmta07.emeryville.ca.mail.comcast.net\r
  19         (qmta07.emeryville.ca.mail.comcast.net [76.96.30.64])\r
  20         by olra.theworths.org (Postfix) with ESMTP id DA279431FC0\r
  21         for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 17:17:32 -0700 (PDT)\r
  22 Received: from omta22.emeryville.ca.mail.comcast.net ([76.96.30.89])\r
  23         by qmta07.emeryville.ca.mail.comcast.net with comcast\r
  24         id SnsH1o0021vN32cA7oHYSx; Wed, 16 Jul 2014 00:17:32 +0000\r
  25 Received: from odin.tremily.us ([24.18.63.50])\r
  26         by omta22.emeryville.ca.mail.comcast.net with comcast\r
  27         id SoHX1o001152l3L8ioHXkE; Wed, 16 Jul 2014 00:17:32 +0000\r
  28 Received: by odin.tremily.us (Postfix, from userid 1000)\r
  29         id D24C11295243; Tue, 15 Jul 2014 17:17:30 -0700 (PDT)\r
  30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
  31         t=1405469850; bh=dEK9AnJRrSA6unU41YugsVc9igTOJdQiatj3UhbglJ8=;\r
  32         h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
  33         b=hv3MCmHtrEVbkhoS86eQyCWWwyNNBhnrXuoZkdECe8wYJWPunjUP2dLRbPJsoybF0\r
  34         KJmS6MarfAIypoWIEpwd957SlVz7fmbuFhshdtnV34OlDW5XZIlLfl9iutzbRh2/aH\r
  35         fIMov6cnMkDxiH6yKDMHK71e1OmLIloRswEtAiIU=\r
  36 Date: Tue, 15 Jul 2014 17:17:30 -0700\r
  37 From: "W. Trevor King" <wking@tremily.us>\r
  38 To: David Bremner <bremner@debian.org>\r
  39 Subject: Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged\r
  40 Message-ID: <20140716001730.GI30232@odin>\r
  41 References: <cover.1404678709.git.wking@tremily.us>\r
  42         <d55cf02465c5f2d83f2dd0bc666831ee524b0fb7.1404678709.git.wking@tremily.us>\r
  43         <871ttm89nd.fsf@maritornes.cs.unb.ca>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: multipart/signed; micalg=pgp-sha1;\r
  46         protocol="application/pgp-signature"; boundary="TA4f0niHM6tHt3xR"\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <871ttm89nd.fsf@maritornes.cs.unb.ca>\r
  49 OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
  50         url=http://tremily.us/pubkey.txt\r
  51 User-Agent: Mutt/1.5.23 (2014-03-12)\r
  52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
  53         s=q20140121; t=1405469852;\r
  54         bh=t7X1pZHdbWsxsdDpqp3PlQ9n+OuBTbTiYdwalQpjjBw=;\r
  55         h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
  56         MIME-Version:Content-Type;\r
  57         b=C3FYyqdNup4BIYhezqorK4HpMJttH0nzOX2rLp36e87hYSj53rc/ldbl2HwzFDvNp\r
  58         bEoD4+XUAvcyEv6Km1mWRb8vD+nEG3s0LZZXH8wE+eQBPqEow3CNlYfzPopTSsKVZ1\r
  59         xb9FecTsKWTFM1+t4RYN/u3u2PczFyaFA3Xh7M9XaoeBA6skKODl3tYJJg8a8jYy6D\r
  60         0PrElh6Upqc/Zu8NoYc/2cb9xtTpmS9eO1NSqJCuY0NJPlOWb7+PoEIGzyI6vNAquJ\r
  61         1SWfOobFFEyEpnr6nmCta4mh78GmjFUCjJdGmYikNW+yNpdmWaiV2tRzOkrf3IHZjN\r
  62         LRfydYhzgKj/w==\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Wed, 16 Jul 2014 00:17:37 -0000\r
  77 \r
  78 \r
  79 --TA4f0niHM6tHt3xR\r
  80 Content-Type: text/plain; charset=utf-8\r
  81 Content-Disposition: inline\r
  82 Content-Transfer-Encoding: quoted-printable\r
  83 \r
  84 On Tue, Jul 15, 2014 at 08:49:58PM -0300, David Bremner wrote:\r
  85 > "W. Trevor King" <wking@tremily.us> writes:\r
  86 >=20\r
  87 > > +  if ($dir eq '-2|') {\r
  88 > > +    $dir =3D '-|';\r
  89 > > +  }\r
  90 > > +\r
  91 >=20\r
  92 > I think I'd prefer an extra flag, rather than making new syntax.\r
  93 > The existing syntax is not pretty, but it is standard perl\r
  94 \r
  95 There should be standard Perl syntax for capturing both streams ;).  I\r
  96 can add a separate parameter instead, but Perl doesn't seem to have\r
  97 keyword-arguments.  At least, nmbug relies on assumptions about\r
  98 argument values:\r
  99 \r
 100   sub git_pipe {\r
 101     my $envref =3D (ref $_[0] eq 'HASH') ? shift : {};\r
 102     my $ioref  =3D (ref $_[0] eq 'ARRAY') ? shift : undef;\r
 103     my $dir =3D ($_[0] eq '-|' or $_[0] eq '|-') ? shift : undef;\r
 104     =E2=80=A6\r
 105   }\r
 106 \r
 107 to map positional arguments back into particular semantic meanings.\r
 108 That seemed ugly enough (can we only have a single boolean argument\r
 109 with this pattern?) that I'd prefer piggy-backing on Perl's\r
 110 stream-direction syntax.  But let me know what you like best, and I'll\r
 111 go that way with v2.  I'd be happy to rewrite nmbug in Python too,\r
 112 which has (to my eyes) much saner kwargs and subprocess handling.\r
 113 \r
 114 Cheers,\r
 115 Trevor\r
 116 \r
 117 --=20\r
 118 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
 119 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
 120 \r
 121 --TA4f0niHM6tHt3xR\r
 122 Content-Type: application/pgp-signature; name="signature.asc"\r
 123 Content-Description: OpenPGP digital signature\r
 124 \r
 125 -----BEGIN PGP SIGNATURE-----\r
 126 Version: GnuPG v2\r
 127 \r
 128 iQIcBAEBAgAGBQJTxcSZAAoJEG8/JgBt8ol8FPIQANNwWT84kmfekKyaKep6v4Af\r
 129 r+kyvbzu+HmYmEO6dVcfraMOj1nM1gJrsKXR7OnlPeEetmbTeixfSkXG4M7VYIcr\r
 130 LuPNSwYm5e13ZGoYiWeZP4bdWtsvOuR9qn66T/GCdsuX99vTNZsXPiyfuyx+FzZS\r
 131 C+ADb4kCeI1zI3zyFu6FmNA/pxBhSalFNZ7cMk76yVcT9Slq/dL57G/c3GjFx9hR\r
 132 0lQTILZ4tn5iHbFPxOVO/7grZTbDWox5qUaXiFtx5DHREfxF5TfCRJnPCzHvcIV3\r
 133 lle3WZiPMr0o3dc2PUmn2j7A49sM206lK//Z4WTkdzxZW2tI+bu8YMn5yCkHa+Ck\r
 134 3wJAO6HPJZ9ylGCyqLqSZ9WMILABwN3LaNlIMio/0llFRWzK0tZpzpUv76WO2cTo\r
 135 GGFFTEvWs4MqkPQEGU8iBLqv0+7T8c6m635vMIla9gn+u9C+2+74BV6/sUOhSRu1\r
 136 /BhoRVB2znRRnbVcpn/tTFJh4+PVmm+CmzfO99ugEqu69fRM5Qd+/zpRXYYopWpO\r
 137 kFQvyGfrLDHFXVIX48pMO8MsJ8fuTAHy9/QvFBro/Xr77iJ8Li8adCi7VXCDvVsK\r
 138 9CYq9NoZAjvM4KWKKzWd3DRt118dChOHGy3RPXFnzlCFyj+AjWVKVzMpD0GpgjUA\r
 139 t8HLgz8endMzhoi5tGLq\r
 140 =MGv8\r
 141 -----END PGP SIGNATURE-----\r
 142 \r
 143 --TA4f0niHM6tHt3xR--\r