Date: Tue, 15 Jul 2014 17:17:30 -0700
From: "W. Trevor King" <wking@tremily.us>
To: David Bremner <bremner@debian.org>
Subject: Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged
Message-ID: <20140716001730.GI30232@odin>
References: <cover.1404678709.git.wking@tremily.us>
	<d55cf02465c5f2d83f2dd0bc666831ee524b0fb7.1404678709.git.wking@tremily.us>
	<871ttm89nd.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="TA4f0niHM6tHt3xR"
Content-Disposition: inline
In-Reply-To: <871ttm89nd.fsf@maritornes.cs.unb.ca>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--TA4f0niHM6tHt3xR
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 15, 2014 at 08:49:58PM -0300, David Bremner wrote:
> "W. Trevor King" <wking@tremily.us> writes:
>=20
> > +  if ($dir eq '-2|') {
> > +    $dir =3D '-|';
> > +  }
> > +
>=20
> I think I'd prefer an extra flag, rather than making new syntax.
> The existing syntax is not pretty, but it is standard perl

There should be standard Perl syntax for capturing both streams ;).  I
can add a separate parameter instead, but Perl doesn't seem to have
keyword-arguments.  At least, nmbug relies on assumptions about
argument values:

  sub git_pipe {
    my $envref =3D (ref $_[0] eq 'HASH') ? shift : {};
    my $ioref  =3D (ref $_[0] eq 'ARRAY') ? shift : undef;
    my $dir =3D ($_[0] eq '-|' or $_[0] eq '|-') ? shift : undef;
    =E2=80=A6
  }

to map positional arguments back into particular semantic meanings.
That seemed ugly enough (can we only have a single boolean argument
with this pattern?) that I'd prefer piggy-backing on Perl's
stream-direction syntax.  But let me know what you like best, and I'll
go that way with v2.  I'd be happy to rewrite nmbug in Python too,
which has (to my eyes) much saner kwargs and subprocess handling.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--TA4f0niHM6tHt3xR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJTxcSZAAoJEG8/JgBt8ol8FPIQANNwWT84kmfekKyaKep6v4Af
r+kyvbzu+HmYmEO6dVcfraMOj1nM1gJrsKXR7OnlPeEetmbTeixfSkXG4M7VYIcr
LuPNSwYm5e13ZGoYiWeZP4bdWtsvOuR9qn66T/GCdsuX99vTNZsXPiyfuyx+FzZS
C+ADb4kCeI1zI3zyFu6FmNA/pxBhSalFNZ7cMk76yVcT9Slq/dL57G/c3GjFx9hR
0lQTILZ4tn5iHbFPxOVO/7grZTbDWox5qUaXiFtx5DHREfxF5TfCRJnPCzHvcIV3
lle3WZiPMr0o3dc2PUmn2j7A49sM206lK//Z4WTkdzxZW2tI+bu8YMn5yCkHa+Ck
3wJAO6HPJZ9ylGCyqLqSZ9WMILABwN3LaNlIMio/0llFRWzK0tZpzpUv76WO2cTo
GGFFTEvWs4MqkPQEGU8iBLqv0+7T8c6m635vMIla9gn+u9C+2+74BV6/sUOhSRu1
/BhoRVB2znRRnbVcpn/tTFJh4+PVmm+CmzfO99ugEqu69fRM5Qd+/zpRXYYopWpO
kFQvyGfrLDHFXVIX48pMO8MsJ8fuTAHy9/QvFBro/Xr77iJ8Li8adCi7VXCDvVsK
9CYq9NoZAjvM4KWKKzWd3DRt118dChOHGy3RPXFnzlCFyj+AjWVKVzMpD0GpgjUA
t8HLgz8endMzhoi5tGLq
=MGv8
-----END PGP SIGNATURE-----

--TA4f0niHM6tHt3xR--